From: Tomi Ollila Date: Wed, 10 Feb 2016 08:17:29 +0000 (+0200) Subject: Re: [PATCH v5 3/3] emacs: Bind filter in search to 'l' X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=d1e4c5ee172a1c5f8300c2b72b81808f65eaf43b;p=notmuch-archives.git Re: [PATCH v5 3/3] emacs: Bind filter in search to 'l' --- diff --git a/dc/30b3dfad9612f5ecd28dd2ff76a6eeff3c124b b/dc/30b3dfad9612f5ecd28dd2ff76a6eeff3c124b new file mode 100644 index 000000000..37b550260 --- /dev/null +++ b/dc/30b3dfad9612f5ecd28dd2ff76a6eeff3c124b @@ -0,0 +1,113 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id 05DB76DE0231 + for ; Wed, 10 Feb 2016 00:17:16 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: 0.645 +X-Spam-Level: +X-Spam-Status: No, score=0.645 tagged_above=-999 required=5 tests=[AWL=-0.007, + SPF_NEUTRAL=0.652] autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id SMagaZ6eu1Q2 for ; + Wed, 10 Feb 2016 00:17:13 -0800 (PST) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by arlo.cworth.org (Postfix) with ESMTP id 819616DE021E + for ; Wed, 10 Feb 2016 00:17:13 -0800 (PST) +Received: from guru.guru-group.fi (localhost [IPv6:::1]) + by guru.guru-group.fi (Postfix) with ESMTP id 0991910007F; + Wed, 10 Feb 2016 10:17:30 +0200 (EET) +From: Tomi Ollila +To: Mark Walters , David Edmondson , + notmuch@notmuchmail.org +Subject: Re: [PATCH v5 3/3] emacs: Bind filter in search to 'l' +In-Reply-To: <87wpqd61ez.fsf@qmul.ac.uk> +References: <1434182890-8047-1-git-send-email-markwalters1009@gmail.com> + <1434182890-8047-4-git-send-email-markwalters1009@gmail.com> + <87wpqd61ez.fsf@qmul.ac.uk> +User-Agent: Notmuch/0.21+32~g73439f8 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.20 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 10 Feb 2016 08:17:16 -0000 + +On Tue, Feb 09 2016, Mark Walters wrote: + +> On Tue, 09 Feb 2016, David Edmondson wrote: +>> On Sat, Jun 13 2015, Mark Walters wrote: +>>> Change the key binding for filter (or "limit") in search-mode. This +>>> gives consistency with the new filter in show-mode, and frees 'f' for +>>> forward-thread in the future. +>> +>> Is there a conclusion on this change? The patch itself seems obviously +>> fine from a code perspective, at issue is more whether it's acceptable +>> to change the key binding. +>> +>> The equivalent binding in notmuch-show mode is already "l", and I think +>> that it makes sense to be consistent (i.e. the change should be +>> applied). +> +> I broadly agree, particularly as it will free up f for forwarding a +> thread in search view (which is easy to do on top of +> id:1454931262-21362-1-git-send-email-dme@dme.org). +> +> It will be annoying in the short term to learn the change, but I don't +> see a way round that. + +In short, +1 for the change. + +Tomi + +> +> Best wishes +> +> Mark +> +>>> --- +>>> emacs/notmuch.el | 4 ++-- +>>> 1 file changed, 2 insertions(+), 2 deletions(-) +>>> +>>> diff --git a/emacs/notmuch.el b/emacs/notmuch.el +>>> index 6564816..06e3b94 100644 +>>> --- a/emacs/notmuch.el +>>> +++ b/emacs/notmuch.el +>>> @@ -166,7 +166,7 @@ (defvar notmuch-search-mode-map +>>> (define-key map "o" 'notmuch-search-toggle-order) +>>> (define-key map "c" 'notmuch-search-stash-map) +>>> (define-key map "t" 'notmuch-search-filter-by-tag) +>>> - (define-key map "f" 'notmuch-search-filter) +>>> + (define-key map "l" 'notmuch-search-filter) +>>> (define-key map [mouse-1] 'notmuch-search-show-thread) +>>> (define-key map "*" 'notmuch-search-tag-all) +>>> (define-key map "a" 'notmuch-search-archive-thread) +>>> @@ -983,7 +983,7 @@ (defun notmuch-search-toggle-order () +>>> (notmuch-search-refresh-view)) +>>> +>>> (defun notmuch-search-filter (query) +>>> - "Filter the current search results based on an additional query string. +>>> + "Filter or LIMIT the current search results based on an additional query string. +>>> +>>> Runs a new search matching only messages that match both the +>>> current search results AND the additional query string provided." +>>> -- +>>> 2.1.4