From: David Bremner <david@tethera.net>
Date: Sat, 7 May 2016 20:29:44 +0000 (+2100)
Subject: Re: [Patch v3 07/11] CLI: add optional config data to dump output.
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=d1cf43818ffa5a083abbc8841ec5a5660b1bf65e;p=notmuch-archives.git

Re: [Patch v3 07/11] CLI: add optional config data to dump output.
---

diff --git a/c0/9e2f57bc903e790dcec7a700414dcbe042b00f b/c0/9e2f57bc903e790dcec7a700414dcbe042b00f
new file mode 100644
index 000000000..ce6948268
--- /dev/null
+++ b/c0/9e2f57bc903e790dcec7a700414dcbe042b00f
@@ -0,0 +1,67 @@
+Return-Path: <david@tethera.net>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+ by arlo.cworth.org (Postfix) with ESMTP id BB8706DE0217
+ for <notmuch@notmuchmail.org>; Sat,  7 May 2016 13:29:58 -0700 (PDT)
+X-Virus-Scanned: Debian amavisd-new at cworth.org
+X-Spam-Flag: NO
+X-Spam-Score: -0.013
+X-Spam-Level: 
+X-Spam-Status: No, score=-0.013 tagged_above=-999 required=5
+ tests=[AWL=-0.002, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01]
+ autolearn=disabled
+Received: from arlo.cworth.org ([127.0.0.1])
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
+ with ESMTP id 5TF3hA8nnO5O for <notmuch@notmuchmail.org>;
+ Sat,  7 May 2016 13:29:50 -0700 (PDT)
+Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197])
+ by arlo.cworth.org (Postfix) with ESMTPS id 4AD586DE00EB
+ for <notmuch@notmuchmail.org>; Sat,  7 May 2016 13:29:50 -0700 (PDT)
+Received: from remotemail by fethera.tethera.net with local (Exim 4.84)
+ (envelope-from <david@tethera.net>)
+ id 1az8r6-0006vc-FM; Sat, 07 May 2016 16:29:40 -0400
+Received: (nullmailer pid 20649 invoked by uid 1000);
+ Sat, 07 May 2016 20:29:44 -0000
+From: David Bremner <david@tethera.net>
+To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org
+Subject: Re: [Patch v3 07/11] CLI: add optional config data to dump output.
+In-Reply-To: <m2wpn5epmk.fsf@guru.guru-group.fi>
+References: <1462065879-29860-1-git-send-email-david@tethera.net>
+ <1462065879-29860-8-git-send-email-david@tethera.net>
+ <m2wpn5epmk.fsf@guru.guru-group.fi>
+User-Agent: Notmuch/0.21+99~gd93d377 (http://notmuchmail.org) Emacs/24.5.1
+ (x86_64-pc-linux-gnu)
+Date: Sat, 07 May 2016 17:29:44 -0300
+Message-ID: <877ff54nnr.fsf@zancas.localnet>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.20
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+ <notmuch.notmuchmail.org>
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Sat, 07 May 2016 20:29:58 -0000
+
+Tomi Ollila <tomi.ollila@iki.fi> writes:
+
+>>  test_begin_subtest 'format=batch-tag, checking encoded output'
+>> -notmuch dump --format=batch-tag -- from:cworth |\
+>> +NOTMUCH_DUMP_TAGS --format=batch-tag -- from:cworth |\
+>>  	 awk "{ print \"+$enc1 +$enc2 +$enc3 -- \" \$5 }" > EXPECTED.$test_count
+>
+> The above I don't understand, $enc1, $enc2 and $enc3 should be expanded by
+> the shell into the awk command -- I don't see these set anywhere, so to
+> me it looks like these are empty strings...
+
+I'm not sure why it drifted so far away, but these are defined on line
+161
+
+d