From: Peter Wang Date: Sat, 27 Jul 2013 05:15:10 +0000 (+1000) Subject: Re: [PATCH 1/3] cli: add insert --must-index option X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=d14e22e4012079a92be8d83a3838636686ad8c53;p=notmuch-archives.git Re: [PATCH 1/3] cli: add insert --must-index option --- diff --git a/9d/b3d4f7a3da87aac360d854f3cd33dbce42ee9b b/9d/b3d4f7a3da87aac360d854f3cd33dbce42ee9b new file mode 100644 index 000000000..8d480905e --- /dev/null +++ b/9d/b3d4f7a3da87aac360d854f3cd33dbce42ee9b @@ -0,0 +1,88 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 1FE1D431FAF + for ; Fri, 26 Jul 2013 22:15:56 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.799 +X-Spam-Level: +X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5 + tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, + FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id eiUCUaYWHs7Z for ; + Fri, 26 Jul 2013 22:15:50 -0700 (PDT) +Received: from mail-pa0-f45.google.com (mail-pa0-f45.google.com + [209.85.220.45]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 8BF59431FAE + for ; Fri, 26 Jul 2013 22:15:50 -0700 (PDT) +Received: by mail-pa0-f45.google.com with SMTP id bg4so3968263pad.32 + for ; Fri, 26 Jul 2013 22:15:49 -0700 (PDT) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; + h=date:message-id:from:to:cc:subject:in-reply-to:references + :mime-version:content-type:content-disposition + :content-transfer-encoding; + bh=NmEEzZzb4J7NPcEaFchAlqRVdCCIymoDRMKd/LYIn8Y=; + b=VxcrzMjeSZoLm/B2AZ8B7wvh6R4M8BI5FolhvepRGXfFMftiFJ0SnmIhV0Lh2GQgwj + InuUh/VmzFWVKwG3z77iQUIYKAuKQFEUG2xpcCOBR0ZXNWckeeBy6WNl6k0wV7/8n8oE + qRIeQxfYqXod/jAg4ZzASrz93aGO3tLlnT5QFz4HhlBVqykr539juYL3Tsg8iUaM4C73 + s9z2bdZdRV7jTq/vWQYQhDcQl9L+Q/02Cq0+XyuoW8BHmU5x+6C6VBG/JGsTqYo3ROjt + o9c//t0DcpTfGkT5/Nxf44P5+TyTrWZFI1ARLhGvVYXqysYR0jbrIGj2LIicBeYQS/vo + UcOA== +X-Received: by 10.66.139.227 with SMTP id rb3mr58655066pab.121.1374902149707; + Fri, 26 Jul 2013 22:15:49 -0700 (PDT) +Received: from localhost (215.42.233.220.static.exetel.com.au. + [220.233.42.215]) + by mx.google.com with ESMTPSA id 7sm7277904paf.22.2013.07.26.22.15.47 + for + (version=TLSv1.2 cipher=RC4-SHA bits=128/128); + Fri, 26 Jul 2013 22:15:48 -0700 (PDT) +Date: Sat, 27 Jul 2013 15:15:10 +1000 +Message-ID: <20130727151510.GA13750@hili.localdomain> +From: Peter Wang +To: Mark Walters +Subject: Re: [PATCH 1/3] cli: add insert --must-index option +In-Reply-To: <87ip048gbj.fsf@qmul.ac.uk> +References: <1374365254-13227-1-git-send-email-novalazy@gmail.com> + <87ip048gbj.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain; charset=utf-8 +Content-Disposition: inline +Content-Transfer-Encoding: 8bit +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 27 Jul 2013 05:15:56 -0000 + +On Sun, 21 Jul 2013 09:31:28 +0100, Mark Walters wrote: +> +> Do you have a particular use case where indexing is required but tagging +> is not? For my uses I would prefer failing if either indexing or tagging +> failed. (My use being postponing messages; If they don't get the +> postponed tag they could be hard to find) + +You're right. + +What about a failure to sync tags to maildir flags? + +I now noticed that database modifications aren't flushed until the +notmuch_database_destroy call (right?), which has no return value and +failure of which is silently ignored. That's acceptable in the default +mode, but with --must-index the failure should be reported (and the +file deleted). + +Peter