From: David Edmondson Date: Tue, 25 Nov 2014 08:16:22 +0000 (+0000) Subject: Re: [RFC][PATCH v1] emacs: Replace `notmuch-search-result-format' evaluation. X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=d12f52049d3254c7b5a3d9a552d8bd0d57ab8492;p=notmuch-archives.git Re: [RFC][PATCH v1] emacs: Replace `notmuch-search-result-format' evaluation. --- diff --git a/0f/aa2ba66b807aeebebbaada028f7ee4e3ea3517 b/0f/aa2ba66b807aeebebbaada028f7ee4e3ea3517 new file mode 100644 index 000000000..f8db1c927 --- /dev/null +++ b/0f/aa2ba66b807aeebebbaada028f7ee4e3ea3517 @@ -0,0 +1,107 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id A0B77431FC3 + for ; Tue, 25 Nov 2014 00:16:32 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.699 +X-Spam-Level: +X-Spam-Status: No, score=-0.699 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7, UNPARSEABLE_RELAY=0.001] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 4E5Y+fnycksP for ; + Tue, 25 Nov 2014 00:16:27 -0800 (PST) +Received: from mail-wg0-f42.google.com (mail-wg0-f42.google.com + [74.125.82.42]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client + certificate requested) by olra.theworths.org (Postfix) with ESMTPS id + A9F72431FAF for ; Tue, 25 Nov 2014 00:16:27 -0800 + (PST) +Received: by mail-wg0-f42.google.com with SMTP id z12so135328wgg.1 + for ; Tue, 25 Nov 2014 00:16:25 -0800 (PST) +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=1e100.net; s=20130820; + h=x-gm-message-state:to:subject:in-reply-to:references:user-agent + :from:date:message-id:mime-version:content-type; + bh=Tu64Z8XkByWAs1+C3v+3xQ12389ccqPud0klV4hFqVg=; + b=dSlyTtVgtPmgUhKtM5MhQYhtyaU14O6fUisvUiLmivlrkBV/GTzq6wX2bzV70iZjA0 + KfOPX2tWjMBU9t6+Ziocha7SJHn/4+/kIMWVHx3Wt3uIfW6BJFzEiTzWm0oM6tCWXhtu + RDjERTNfSg6c4cIRlZnp762xw2mKWlH1RwmWrC/QAScqcgv+feFatTaHERWFP++dXCGv + roP9z8ttLxf2DaodCYvY/NFPvW5V6Q5zJJDh81o+5d0OkaurJXb1TqbZ0vlqdrjPhPqT + eMup/yd4fQMFmxy8MrwxR/riMa4n/hAmbXFD+MDt7XvoE0eY7WdQG3tYWjIAQhoEwDM+ + K6Rw== +X-Gm-Message-State: + ALoCoQnWcVzNKkJrKceX95NhnfBpUSmMzhhFdWLwlxJNkNRPrB/4cFZtOtZJsyUqTQALvNlBxkVd +X-Received: by 10.194.209.180 with SMTP id mn20mr41767491wjc.49.1416903385317; + Tue, 25 Nov 2014 00:16:25 -0800 (PST) +Received: from disaster-area.hh.sledj.net + ([2a01:348:1a2:1:ea39:35ff:fe2c:a227]) + by mx.google.com with ESMTPSA id + lp14sm1721442wic.20.2014.11.25.00.16.24 for + (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); + Tue, 25 Nov 2014 00:16:24 -0800 (PST) +Received: from localhost (30000@localhost [local]); + by localhost (OpenSMTPD) with ESMTPA id 4a215841; + Tue, 25 Nov 2014 08:16:22 +0000 (UTC) +To: David Bremner , notmuch@notmuchmail.org +Subject: Re: [RFC][PATCH v1] emacs: Replace `notmuch-search-result-format' + evaluation. +In-Reply-To: <87ppcbdb7n.fsf@maritornes.cs.unb.ca> +References: <1416825869-28472-1-git-send-email-dme@dme.org> + <87ppcbdb7n.fsf@maritornes.cs.unb.ca> +User-Agent: Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 + (x86_64-pc-linux-gnu) +From: David Edmondson +Date: Tue, 25 Nov 2014 08:16:22 +0000 +Message-ID: +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 25 Nov 2014 08:16:32 -0000 + +On Tue, Nov 25 2014, David Bremner wrote: +>> +A symbol corresponding to an attribute of the +>> + thread (e.g. `:date_relative' or `:subject'). +> +> It'd be nice for the user to have a pointer here to figure out what +> the possible attributes are. + +I don't believe that we currently document these anywhere. I'll add a +list in the form "this will include such attributes as ...". + +Something that I didn't mention is that this implementation behaves +differently from the current one in two ways: + +- The invisible authors are not available to isearch. That is, the + current implementation hides the authors that couldn't be shown in the + available space using invisible text that can be exposed during an + isearch in the buffer. This isn't done with the new implementation. + +- The truncation of author names is hard - they are just chopped at the + defined width (minus space for the ellipsis). The current code tries + to find a nice break point (between authors). That was done to better + support the the above feature (as isearch won't match text across a + visible/invisible boundary). + +The first of these is complex to fix. The current implementation relies +on overlays, which in turn require direct access to the buffer where the +text will be rendered. The buffer isn't available to the formatting +function in the new implementation. + +The second could be fixed relatively straightforwardly, but without a +fix for the invisible text, I'm not clear that it's useful (and in fact +may be harmful).