From: Mark Walters Date: Thu, 30 Jan 2014 21:15:40 +0000 (+0000) Subject: Re: [PATCH 0/5] lib: make folder: prefix literal X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=d1003c769dcd217c78f19645488c5d52fcc08dee;p=notmuch-archives.git Re: [PATCH 0/5] lib: make folder: prefix literal --- diff --git a/84/2656c61286f79b37336c2e8cd022516222d661 b/84/2656c61286f79b37336c2e8cd022516222d661 new file mode 100644 index 000000000..a0ad92690 --- /dev/null +++ b/84/2656c61286f79b37336c2e8cd022516222d661 @@ -0,0 +1,106 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id DBABE431FBD + for ; Thu, 30 Jan 2014 13:19:25 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -1.098 +X-Spam-Level: +X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5 + tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, + NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id j5ai6Ctz7QQi for ; + Thu, 30 Jan 2014 13:19:20 -0800 (PST) +Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id C3E1E431FB6 + for ; Thu, 30 Jan 2014 13:19:19 -0800 (PST) +Received: from smtp.qmul.ac.uk ([138.37.6.40]) + by mail2.qmul.ac.uk with esmtp (Exim 4.71) + (envelope-from ) + id 1W8z0o-0002dI-4M; Thu, 30 Jan 2014 21:19:12 +0000 +Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost) + by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71) + (envelope-from ) + id 1W8yzQ-0005IP-Rp; Thu, 30 Jan 2014 21:17:36 +0000 +From: Mark Walters +To: Jani Nikula , Carl Worth , + Austin Clements +Subject: Re: [PATCH 0/5] lib: make folder: prefix literal +In-Reply-To: <87a9eeou4v.fsf@nikula.org> +References: + <87y525m649.fsf@awakening.csail.mit.edu> + <87r47wfltb.fsf@nikula.org> <87iot8f4vg.fsf@nikula.org> + <874n4rvcvo.fsf@yoom.home.cworth.org> <874n4mfw1x.fsf@nikula.org> + <87k3dir3ci.fsf@yoom.home.cworth.org> + <20140129204608.GE4375@mit.edu> + <87bnyuqw60.fsf@yoom.home.cworth.org> <87a9eeou4v.fsf@nikula.org> +User-Agent: Notmuch/0.15.2+484~gfb59956 (http://notmuchmail.org) Emacs/23.4.1 + (x86_64-pc-linux-gnu) +Date: Thu, 30 Jan 2014 21:15:40 +0000 +Message-ID: <8761p19nnn.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Sender-Host-Address: 93.97.24.31 +X-QM-Geographic: According to ripencc, + this message was delivered by a machine in Britain (UK) (GB). +X-QM-SPAM-Info: Sender has good ham record. :) +X-QM-Body-MD5: f9c71bda3b28e3b99ef85df533a7452d (of first 20000 bytes) +X-SpamAssassin-Score: 0.0 +X-SpamAssassin-SpamBar: / +X-SpamAssassin-Report: The QM spam filters have analysed this message to + determine if it is + spam. We require at least 5.0 points to mark a message as spam. + This message scored 0.0 points. Summary of the scoring: + * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail + provider * (markwalters1009[at]gmail.com) + * 0.0 AWL AWL: From: address is in the auto white-list +X-QM-Scan-Virus: ClamAV says the message is clean +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 30 Jan 2014 21:19:26 -0000 + + +Dear Jani + +> That is the unicorn... many of the query improvements I have in mind +> depend on a custom query parser. So I'd like to have that. And a +> pony. But in the mean time, I'm left wondering whether I should pursue +> folder: as a boolean prefix, or try to figure out if there are +> improvements to be made as a probabilistic prefix, or just put this work +> on hold. With the db upgrade and upgrade tests, it's not exactly a +> trivial amount of work. + +I think a boolean prefix sounds good. As you say there are lots of +things we could do with a custom parser but I don't think its worth +delaying things like this for it. + +I also think it's not worth aiming for something perfect, just "good +enough". In a bike-shedding spirit I like the suggestion above (and on +irc) of a path: prefix which is basically literal. Either ^ or a +starting / to root the folder and a terminal $ or / to fix the end. + +(I don't have a preference between these: / avoids a clash with folder +name with a $ or ^ in them but $ ^ are more familiar.) + +Best wishes + +Mark + +