From: Jani Nikula Date: Tue, 4 Dec 2012 17:07:46 +0000 (+0200) Subject: Re: [PATCH v2 0/5] New output format sexp (Lisp S-Expressions) X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=d05841428d547a07667ec0cf88fb013ff87bea5c;p=notmuch-archives.git Re: [PATCH v2 0/5] New output format sexp (Lisp S-Expressions) --- diff --git a/b9/a254a5f88aa60fd79b3d00dc4535bf2df71d71 b/b9/a254a5f88aa60fd79b3d00dc4535bf2df71d71 new file mode 100644 index 000000000..c915cdd58 --- /dev/null +++ b/b9/a254a5f88aa60fd79b3d00dc4535bf2df71d71 @@ -0,0 +1,127 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 7C170431FB6 + for ; Tue, 4 Dec 2012 09:07:58 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id Y43z74OHqf+N for ; + Tue, 4 Dec 2012 09:07:54 -0800 (PST) +Received: from mail-la0-f53.google.com (mail-la0-f53.google.com + [209.85.215.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 3C076431FAE + for ; Tue, 4 Dec 2012 09:07:54 -0800 (PST) +Received: by mail-la0-f53.google.com with SMTP id w12so3572120lag.26 + for ; Tue, 04 Dec 2012 09:07:52 -0800 (PST) +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=google.com; s=20120113; + h=from:to:subject:in-reply-to:references:user-agent:date:message-id + :mime-version:content-type:x-gm-message-state; + bh=44fUyli5oPeB2mTyDhZCSircK2AGRbDBM0Z85iCRyaI=; + b=elREwdkk31y5oqSClhUI1uKRvn86Iu2dkAlyBfhSk1+hDuIM+bu+zZVIhkG4kg8I7A + MYlmZ9vUxqrhynM92Uu39uVmqyijoKoWx9+NP4XOYB/nG721WsOpTL0qUipXGapj3PFc + 2Pv61aLW+RK0FTi4AKCYsqwwkAwaQrfDkZI+892x2pa+PecfDHGjQDPz6Y3zxYga3nzL + 3GJf8DksvU3HZwBh03tQxd85Xue8vDl8pLQNLLkr5Btn84GjuxDso5EkM+oGm0pOzNGo + N+dNaOOwesFcGUXZxqUdhrhrgoozEAvXKzr2gffHj5QKzc18frDUj58L/Rhlqx2CVdVq + hOfQ== +Received: by 10.152.144.10 with SMTP id si10mr13623174lab.55.1354640872324; + Tue, 04 Dec 2012 09:07:52 -0800 (PST) +Received: from localhost (dsl-hkibrasgw4-fe51df00-27.dhcp.inet.fi. + [80.223.81.27]) + by mx.google.com with ESMTPS id pw17sm976447lab.5.2012.12.04.09.07.47 + (version=SSLv3 cipher=OTHER); Tue, 04 Dec 2012 09:07:49 -0800 (PST) +From: Jani Nikula +To: Peter Feigl , notmuch@notmuchmail.org +Subject: Re: [PATCH v2 0/5] New output format sexp (Lisp S-Expressions) +In-Reply-To: <1354632382-15609-1-git-send-email-craven@gmx.net> +References: <1354264143-30173-1-git-send-email-craven@gmx.net> + <1354632382-15609-1-git-send-email-craven@gmx.net> +User-Agent: Notmuch/0.14+137~g9203c35 (http://notmuchmail.org) Emacs/23.4.1 + (i686-pc-linux-gnu) +Date: Tue, 04 Dec 2012 19:07:46 +0200 +Message-ID: <87boe9lp99.fsf@nikula.org> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Gm-Message-State: + ALoCoQk0ZWefhJrj2fR85I7MfObeMixCWihiyysk8Ete6TWXD7wcrszqd5xX2NCrFXSNgC+3egrg +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 04 Dec 2012 17:07:58 -0000 + + +Hi Peter - + +On Tue, 04 Dec 2012, Peter Feigl wrote: +> This patch series adds a new output format "sexp" to notmuch-reply, +> notmuch-show and notmuch-search. These are useful for the Android mobile +> client and perhaps other Lisp programs as well. +> After the switch to a generic structured output printer, which was +> committed some months ago, these patches just add another one (like the +> json structured output printer). +> Basic tests and updates to the man pages are also included. +> +> +> Peter Feigl (5): +> Adding an S-expression structured output printer. +> Rename the -json printer functions in notmuch-reply and +> notmuch-show to generic -sprinter functions. +> Use the S-Expression structured printer in notmuch-show, +> notmuch-reply and notmuch-search. + +Patches 1-3 look good. + +> Adding tests for --format=sexp. + +Did not review. + +> Updating man pages for new S-Expression output format. + +Did not review, but noticed it adds lines with trailing whitespace. + + +BR, +Jani. + + +> +> Makefile.local | 1 + +> man/man1/notmuch-reply.1 | 14 ++- +> man/man1/notmuch-search.1 | 15 +-- +> man/man1/notmuch-show.1 | 36 +++++-- +> notmuch-client.h | 8 +- +> notmuch-reply.c | 43 ++++---- +> notmuch-search.c | 6 +- +> notmuch-show.c | 48 +++++---- +> sprinter-sexp.c | 250 ++++++++++++++++++++++++++++++++++++++++++++++ +> sprinter.h | 4 + +> test/notmuch-test | 1 + +> test/sexp | 48 +++++++++ +> 12 files changed, 414 insertions(+), 60 deletions(-) +> create mode 100644 sprinter-sexp.c +> create mode 100755 test/sexp +> +> -- +> 1.8.0 +> +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> http://notmuchmail.org/mailman/listinfo/notmuch