From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Date: Tue, 2 May 2006 19:54:12 +0000 (-0700)
Subject: repo-config: fix segfault with no argument.
X-Git-Tag: v1.4.0-rc1~198
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=cfa24e184a67cc36f414d913cf705d31e70a7a1a;p=git.git

repo-config: fix segfault with no argument.

An earlier addition of --list feature was carelessly done and
caused an invalid access to argv[1] when it was not given.

Signed-off-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Signed-off-by: Junio C Hamano <junkio@cox.net>
---

diff --git a/repo-config.c b/repo-config.c
index fa8aba7a1..e35063034 100644
--- a/repo-config.c
+++ b/repo-config.c
@@ -102,15 +102,14 @@ int main(int argc, const char **argv)
 			type = T_INT;
 		else if (!strcmp(argv[1], "--bool"))
 			type = T_BOOL;
+		else if (!strcmp(argv[1], "--list") || !strcmp(argv[1], "-l"))
+			return git_config(show_all_config);
 		else
 			break;
 		argc--;
 		argv++;
 	}
 
-	if (!strcmp(argv[1], "--list") || !strcmp(argv[1], "-l"))
-		return git_config(show_all_config);
-
 	switch (argc) {
 	case 2:
 		return get_value(argv[1], NULL);