From: Tomi Ollila <tomi.ollila@iki.fi>
Date: Sun, 2 Jun 2013 14:34:17 +0000 (+0300)
Subject: Re: [PATCH] contrib: pick: bugfix. use notmuch-show-only-matching-messages rather... 
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=cfa0244b9ea84fe923d1e40614ccbad74198d4b2;p=notmuch-archives.git

Re: [PATCH] contrib: pick: bugfix. use notmuch-show-only-matching-messages rather than prefix
---

diff --git a/1c/9b12487acfedcfc80f55317843e21ea4c16a7d b/1c/9b12487acfedcfc80f55317843e21ea4c16a7d
new file mode 100644
index 000000000..5fb40dff5
--- /dev/null
+++ b/1c/9b12487acfedcfc80f55317843e21ea4c16a7d
@@ -0,0 +1,90 @@
+Return-Path: <tomi.ollila@iki.fi>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+	by olra.theworths.org (Postfix) with ESMTP id EC738429E55
+	for <notmuch@notmuchmail.org>; Sun,  2 Jun 2013 07:34:23 -0700 (PDT)
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
+X-Spam-Flag: NO
+X-Spam-Score: 0
+X-Spam-Level: 
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
+	autolearn=disabled
+Received: from olra.theworths.org ([127.0.0.1])
+	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
+	with ESMTP id N2zcNEJ+PPA0 for <notmuch@notmuchmail.org>;
+	Sun,  2 Jun 2013 07:34:18 -0700 (PDT)
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
+	by olra.theworths.org (Postfix) with ESMTP id 95C53429E4C
+	for <notmuch@notmuchmail.org>; Sun,  2 Jun 2013 07:34:18 -0700 (PDT)
+Received: from guru.guru-group.fi (localhost [IPv6:::1])
+	by guru.guru-group.fi (Postfix) with ESMTP id EF418100030;
+	Sun,  2 Jun 2013 17:34:17 +0300 (EEST)
+From: Tomi Ollila <tomi.ollila@iki.fi>
+To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
+Subject: Re: [PATCH] contrib: pick: bugfix. use
+	notmuch-show-only-matching-messages rather than prefix
+In-Reply-To: <1370123491-13902-1-git-send-email-markwalters1009@gmail.com>
+References: <1370123491-13902-1-git-send-email-markwalters1009@gmail.com>
+User-Agent: Notmuch/0.15.2+115~g12cf6af (http://notmuchmail.org) Emacs/24.3.1
+	(x86_64-unknown-linux-gnu)
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
+	$[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
+	!)g;OY^,BjTbr)Np:%c_o'jj,Z
+Date: Sun, 02 Jun 2013 17:34:17 +0300
+Message-ID: <m2a9n8d1jq.fsf@guru.guru-group.fi>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.13
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+	<notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Sun, 02 Jun 2013 14:34:24 -0000
+
+On Sun, Jun 02 2013, Mark Walters <markwalters1009@gmail.com> wrote:
+
+> Previously pick set a prefix argument prior to calling show in the
+> message pane to tell show to only show matching messages. This sets
+> notmuch-show-only-matching-messages instead which is much cleaner and
+> will work even if the user has configured show to default to showing
+> only matching messages.
+> ---
+
+LGTM.
+
+Tomi
+
+
+>  contrib/notmuch-pick/notmuch-pick.el |    4 ++--
+>  1 files changed, 2 insertions(+), 2 deletions(-)
+>
+> diff --git a/contrib/notmuch-pick/notmuch-pick.el b/contrib/notmuch-pick/notmuch-pick.el
+> index 9079acf..2da43ea 100644
+> --- a/contrib/notmuch-pick/notmuch-pick.el
+> +++ b/contrib/notmuch-pick/notmuch-pick.el
+> @@ -376,8 +376,8 @@ Does NOT change the database."
+>  	    (split-window-vertically (/ (window-height) 4)))
+>        (with-selected-window notmuch-pick-message-window
+>  	;; Since we are only displaying one message do not indent.
+> -	(let ((notmuch-show-indent-messages-width 0))
+> -	  (setq current-prefix-arg '(4))
+> +	(let ((notmuch-show-indent-messages-width 0)
+> +	      (notmuch-show-only-matching-messages t))
+>  	  (setq buffer (notmuch-show id nil nil nil))))
+>        ;; We need the `let' as notmuch-pick-message-window is buffer local.
+>        (let ((window notmuch-pick-message-window))
+> -- 
+> 1.7.9.1
+>
+> _______________________________________________
+> notmuch mailing list
+> notmuch@notmuchmail.org
+> http://notmuchmail.org/mailman/listinfo/notmuch