From: Junio C Hamano Date: Mon, 4 Feb 2008 01:02:28 +0000 (-0800) Subject: Documentation/SubmittingPatches: What's Acked-by and Tested-by? X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=cf66023da9121f3d9224b569ed8ecb80e5641a4c;p=signed-off-by.git Documentation/SubmittingPatches: What's Acked-by and Tested-by? We used to talk about "internal company procedures", but this document is about submitting patches to the git mailing list. More useful information is when to say Acked-by: and Tested-by:. Signed-off-by: Junio C Hamano [wking@tremily.us: removed diff context to merge with Linux kernel version] Signed-off-by: W. Trevor King --- diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches index 4be4625..4c82e08 100644 --- a/Documentation/SubmittingPatches +++ b/Documentation/SubmittingPatches @@ -44,9 +44,18 @@ using your real name (sorry, no pseudonyms or anonymous contributions.) This line can be automatically added by git if you run the git-commit command with the -s option. -Some people also put extra tags at the end. They'll just be ignored for -now, but you can do this to mark internal company procedures or just -point out some special detail about the sign-off. +Notice that you can place your own Signed-off-by: line when +forwarding somebody else's patch with the above rules for +D-C-O. Indeed you are encouraged to do so. Do not forget to +place an in-body "From: " line at the beginning to properly attribute +the change to its true author (see (2) above). + +Some people also put extra tags at the end. + +"Acked-by:" says that the patch was reviewed by the person who +is more familiar with the issues and the area the patch attempts +to modify. "Tested-by:" says the patch was tested by the person +and found to have the desired effect. If you are a subsystem or branch maintainer, sometimes you need to slightly modify patches you receive in order to merge them, because the code is not