From: David Bremner Date: Mon, 7 Apr 2014 10:15:15 +0000 (+2100) Subject: Re: [PATCH v4 2/3] emacs: add notmuch-version.el.tmpl and create notmuch-version... X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=cf1faa78b829485b05fe64758283111c3ccdd2b0;p=notmuch-archives.git Re: [PATCH v4 2/3] emacs: add notmuch-version.el.tmpl and create notmuch-version.el from it --- diff --git a/07/31ded682662cb9498ab10d232327e6e50eed96 b/07/31ded682662cb9498ab10d232327e6e50eed96 new file mode 100644 index 000000000..8db9eec36 --- /dev/null +++ b/07/31ded682662cb9498ab10d232327e6e50eed96 @@ -0,0 +1,75 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 8EC8E431FBC + for ; Mon, 7 Apr 2014 03:16:51 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id B9SJWriuI1Q9 for ; + Mon, 7 Apr 2014 03:16:45 -0700 (PDT) +Received: from mx.xen14.node3324.gplhost.com (gitolite.debian.net + [87.98.215.224]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id C665A431FB6 + for ; Mon, 7 Apr 2014 03:16:45 -0700 (PDT) +Received: from remotemail by mx.xen14.node3324.gplhost.com with local (Exim + 4.72) (envelope-from ) + id 1WX6aW-0007Td-Pz; Mon, 07 Apr 2014 10:15:36 +0000 +Received: (nullmailer pid 20491 invoked by uid 1000); Mon, 07 Apr 2014 + 10:15:15 -0000 +From: David Bremner +To: Tomi Ollila , notmuch@notmuchmail.org +Subject: Re: [PATCH v4 2/3] emacs: add notmuch-version.el.tmpl and create + notmuch-version.el from it +In-Reply-To: +References: <1395261431-24668-1-git-send-email-tomi.ollila@iki.fi> + <1395261431-24668-2-git-send-email-tomi.ollila@iki.fi> + <87a9by47wh.fsf@maritornes.cs.unb.ca> + +User-Agent: Notmuch/0.17+174~g4efbc9f (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-pc-linux-gnu) +Date: Mon, 07 Apr 2014 07:15:15 -0300 +Message-ID: <871tx9h2do.fsf@maritornes.cs.unb.ca> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 07 Apr 2014 10:16:51 -0000 + +Tomi Ollila writes: + +> +> This is more due to the template-to-file conversion simplicity than need +> and I thought there is no harm having the copyright there. At least the +> file is consistent with others in that sense. + +OK, I can live with it. + +> +> All of these are of type string, and the documentation states whether +> it is (at least close to) numeric or not within string. But there is +> no tradition of what *-version should contain. + +I think depending on the contents of a string to be parseable in any +particular way is probably a bad idea in any case, particularly in a +lisp where you can just make the variable the appropriate type... + +d +