From: Vladimir.Marek Date: Mon, 6 May 2013 15:15:59 +0000 (+0200) Subject: [PATCH 1/4] getpwuid: check for standards compliance (Solaris support) X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=cef790de6e7ed02bc09d7146b286fafbe07925d6;p=notmuch-archives.git [PATCH 1/4] getpwuid: check for standards compliance (Solaris support) --- diff --git a/94/241f1da9aefab7de119fba5002be254eb1d65a b/94/241f1da9aefab7de119fba5002be254eb1d65a new file mode 100644 index 000000000..94ddf7728 --- /dev/null +++ b/94/241f1da9aefab7de119fba5002be254eb1d65a @@ -0,0 +1,168 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 0538C431FBD + for ; Mon, 6 May 2013 08:16:43 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -2.299 +X-Spam-Level: +X-Spam-Status: No, score=-2.299 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_MED=-2.3, UNPARSEABLE_RELAY=0.001] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id yAgNQIxPC2ur for ; + Mon, 6 May 2013 08:16:38 -0700 (PDT) +Received: from aserp1040.oracle.com (aserp1040.oracle.com [141.146.126.69]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 83A29431FAE + for ; Mon, 6 May 2013 08:16:34 -0700 (PDT) +Received: from acsinet21.oracle.com (acsinet21.oracle.com [141.146.126.237]) + by aserp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with + ESMTP id r46FGPht009934 + (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); + Mon, 6 May 2013 15:16:26 GMT +Received: from aserz7022.oracle.com (aserz7022.oracle.com [141.146.126.231]) + by acsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id + r46FGNhF027183 + (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); + Mon, 6 May 2013 15:16:24 GMT +Received: from abhmt119.oracle.com (abhmt119.oracle.com [141.146.116.71]) + by aserz7022.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id + r46FGN0d003609; Mon, 6 May 2013 15:16:23 GMT +Received: from vi64-x3-2e-prg06.cz.oracle.com (/10.163.102.127) + by default (Oracle Beehive Gateway v4.0) + with ESMTP ; Mon, 06 May 2013 08:16:23 -0700 +From: Vladimir.Marek@oracle.com +To: notmuch@notmuchmail.org +Subject: [PATCH 1/4] getpwuid: check for standards compliance (Solaris + support) +Date: Mon, 6 May 2013 17:15:59 +0200 +Message-Id: <1367853362-11846-2-git-send-email-Vladimir.Marek@oracle.com> +X-Mailer: git-send-email 1.7.9.2 +In-Reply-To: <1367853362-11846-1-git-send-email-Vladimir.Marek@oracle.com> +References: <1367853362-11846-1-git-send-email-Vladimir.Marek@oracle.com> +X-Source-IP: acsinet21.oracle.com [141.146.126.237] +Cc: Vladimir Marek +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 06 May 2013 15:16:43 -0000 + +From: Blake Jones + +Add checks to "configure" to see whether _POSIX_PTHREAD_SEMANTICS needs +to be defined to get the right number of arguments in the prototypes for +getpwuid_r(). Solaris' default implementation conforms to POSIX.1c +Draft 6, rather than the final POSIX.1c spec. The standards-compliant +version can be used by defining _POSIX_PTHREAD_SEMANTICS. + +This change also adds the file "compat/check_getpwuid.c", which +configure uses to perform its check, and modifies compat/compat.h to +define _POSIX_PTHREAD_SEMANTICS if configure detected it was needed. + +Signed-off-by: Vladimir Marek +--- + compat/check_getpwuid.c | 11 +++++++++++ + compat/compat.h | 4 ++++ + configure | 23 +++++++++++++++++++++-- + 3 files changed, 36 insertions(+), 2 deletions(-) + create mode 100644 compat/check_getpwuid.c + +diff --git a/compat/check_getpwuid.c b/compat/check_getpwuid.c +new file mode 100644 +index 0000000..c435eb8 +--- /dev/null ++++ b/compat/check_getpwuid.c +@@ -0,0 +1,11 @@ ++#include ++#include ++ ++int main() ++{ ++ struct passwd passwd, *ignored; ++ ++ (void) getpwuid_r (0, &passwd, NULL, 0, &ignored); ++ ++ return (0); ++} +diff --git a/compat/compat.h b/compat/compat.h +index b2e2736..c1ee0f9 100644 +--- a/compat/compat.h ++++ b/compat/compat.h +@@ -30,6 +30,10 @@ + extern "C" { + #endif + ++#if !STD_GETPWUID ++#define _POSIX_PTHREAD_SEMANTICS 1 ++#endif ++ + #if !HAVE_GETLINE + #include + #include +diff --git a/configure b/configure +index 460fcfc..8ef7bac 100755 +--- a/configure ++++ b/configure +@@ -517,6 +517,17 @@ else + fi + rm -f compat/have_strcasestr + ++printf "Checking for standard version of getpwuid_r... " ++if ${CC} -o compat/check_getpwuid "$srcdir"/compat/check_getpwuid.c > /dev/null 2>&1 ++then ++ printf "Yes.\n" ++ std_getpwuid=1 ++else ++ printf "No (will define _POSIX_PTHREAD_SEMANTICS to get it).\n" ++ std_getpwuid=0 ++fi ++rm -f compat/check_getpwuid ++ + printf "int main(void){return 0;}\n" > minimal.c + + printf "Checking for rpath support... " +@@ -676,6 +687,11 @@ HAVE_GETLINE = ${have_getline} + # build its own version) + HAVE_STRCASESTR = ${have_strcasestr} + ++# Whether the getpwuid_r function is standards-compliant ++# (if not, then notmuch will #define _POSIX_PTHREAD_SEMANTICS ++# to enable the standards-compliant version -- needed for Solaris) ++STD_GETPWUID = ${std_getpwuid} ++ + # Supported platforms (so far) are: LINUX, MACOSX, SOLARIS, FREEBSD, OPENBSD + PLATFORM = ${platform} + +@@ -720,10 +736,13 @@ WITH_ZSH = ${WITH_ZSH} + # Combined flags for compiling and linking against all of the above + CONFIGURE_CFLAGS = -DHAVE_GETLINE=\$(HAVE_GETLINE) \$(GMIME_CFLAGS) \\ + \$(TALLOC_CFLAGS) -DHAVE_VALGRIND=\$(HAVE_VALGRIND) \\ +- \$(VALGRIND_CFLAGS) -DHAVE_STRCASESTR=\$(HAVE_STRCASESTR) ++ \$(VALGRIND_CFLAGS) \\ ++ -DHAVE_STRCASESTR=\$(HAVE_STRCASESTR) \\ ++ -DSTD_GETPWUID=\$(STD_GETPWUID) + CONFIGURE_CXXFLAGS = -DHAVE_GETLINE=\$(HAVE_GETLINE) \$(GMIME_CFLAGS) \\ + \$(TALLOC_CFLAGS) -DHAVE_VALGRIND=\$(HAVE_VALGRIND) \\ + \$(VALGRIND_CFLAGS) \$(XAPIAN_CXXFLAGS) \\ +- -DHAVE_STRCASESTR=\$(HAVE_STRCASESTR) ++ -DHAVE_STRCASESTR=\$(HAVE_STRCASESTR) \\ ++ -DSTD_GETPWUID=\$(STD_GETPWUID) + CONFIGURE_LDFLAGS = \$(GMIME_LDFLAGS) \$(TALLOC_LDFLAGS) \$(XAPIAN_LDFLAGS) + EOF +-- +1.7.9.2 +