From: Sergei Trofimovich <slyfox@gentoo.org>
Date: Wed, 25 Sep 2019 07:19:16 +0000 (+0100)
Subject: toolchain-glibc.eclass: drop prepallstrip, bug #587296
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=cdb645361e3e3f20bb6f1250ada03e802285ffc3;p=gentoo.git

toolchain-glibc.eclass: drop prepallstrip, bug #587296

This effectively reverts https://bugs.gentoo.org/46186.
Modern gdb can inspect threads without debugging symbols
in libpthread/libthread_db.

Reported-by: Michał Górny
Bug: https://bugs.gentoo.org/587296
Bug: https://bugs.gentoo.org/46186
Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
---

diff --git a/eclass/toolchain-glibc.eclass b/eclass/toolchain-glibc.eclass
index 81d494c6fd53..4aa06db55293 100644
--- a/eclass/toolchain-glibc.eclass
+++ b/eclass/toolchain-glibc.eclass
@@ -1395,23 +1395,6 @@ toolchain-glibc_headers_install() {
 	dosym usr/include $(alt_prefix)/sys-include
 }
 
-src_strip() {
-	# gdb is lame and requires some debugging information to remain in
-	# libpthread, so we need to strip it by hand.  libthread_db makes no
-	# sense stripped as it is only used when debugging.
-	local pthread=$(has splitdebug ${FEATURES} && echo "libthread_db" || echo "lib{pthread,thread_db}")
-	env \
-		-uRESTRICT \
-		CHOST=${CTARGET} \
-		STRIP_MASK="/*/{,tls/}${pthread}*" \
-		prepallstrip
-	# if user has stripping enabled and does not have split debug turned on,
-	# then leave the debugging sections in libpthread.
-	if ! has nostrip ${FEATURES} && ! has splitdebug ${FEATURES} ; then
-		${STRIP:-${CTARGET}-strip} --strip-debug "${ED}"/*/libpthread-*.so
-	fi
-}
-
 toolchain-glibc_src_install() {
 	if just_headers ; then
 		export ABI=default
@@ -1420,7 +1403,6 @@ toolchain-glibc_src_install() {
 	fi
 
 	foreach_abi toolchain-glibc_do_src_install
-	src_strip
 }
 
 # Simple test to make sure our new glibc isn't completely broken.