From: Mark Walters Date: Thu, 4 Jul 2013 08:07:24 +0000 (+0100) Subject: Re: [PATCH] contrib: pick: use notmuch-start-notmuch X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=cd35682c653e896c654cd537ada0b496a7d24004;p=notmuch-archives.git Re: [PATCH] contrib: pick: use notmuch-start-notmuch --- diff --git a/93/f04deb478d3d1df70234b325aa4099528bb5fd b/93/f04deb478d3d1df70234b325aa4099528bb5fd new file mode 100644 index 000000000..55a9f1560 --- /dev/null +++ b/93/f04deb478d3d1df70234b325aa4099528bb5fd @@ -0,0 +1,133 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id D1F41431FDD + for ; Thu, 4 Jul 2013 01:07:40 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -1.098 +X-Spam-Level: +X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5 + tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, + NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id gf7PjwaIwF2w for ; + Thu, 4 Jul 2013 01:07:32 -0700 (PDT) +Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 59B32431FBF + for ; Thu, 4 Jul 2013 01:07:32 -0700 (PDT) +Received: from smtp.qmul.ac.uk ([138.37.6.40]) + by mail2.qmul.ac.uk with esmtp (Exim 4.71) + (envelope-from ) + id 1UueZa-0003uY-7D; Thu, 04 Jul 2013 09:07:28 +0100 +Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost) + by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71) + (envelope-from ) + id 1UueZZ-0007tU-VZ; Thu, 04 Jul 2013 09:07:26 +0100 +From: Mark Walters +To: Tomi Ollila , notmuch@notmuchmail.org +Subject: Re: [PATCH] contrib: pick: use notmuch-start-notmuch +In-Reply-To: +References: <1372921788-16042-1-git-send-email-markwalters1009@gmail.com> + +User-Agent: Notmuch/0.15.2+192~g8222af3 (http://notmuchmail.org) Emacs/23.4.1 + (i486-pc-linux-gnu) +Date: Thu, 04 Jul 2013 09:07:24 +0100 +Message-ID: <87ip0qg343.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Sender-Host-Address: 93.97.24.31 +X-QM-SPAM-Info: Sender has good ham record. :) +X-QM-Body-MD5: b34aa5a27364e928f28a4ee6b6f8d364 (of first 20000 bytes) +X-SpamAssassin-Score: 0.0 +X-SpamAssassin-SpamBar: / +X-SpamAssassin-Report: The QM spam filters have analysed this message to + determine if it is + spam. We require at least 5.0 points to mark a message as spam. + This message scored 0.0 points. Summary of the scoring: + * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail + provider * (markwalters1009[at]gmail.com) + * 0.0 AWL AWL: From: address is in the auto white-list +X-QM-Scan-Virus: ClamAV says the message is clean +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 04 Jul 2013 08:07:41 -0000 + + +Tomi Ollila writes: + +> FWIW the code LGTM. Do the pick tests use this and do those pass ? + +Thanks for the review. + +The tests do all pass. There are two sets of pick tests: one uses the +async parser (the default) which uses this code and the other uses the +sync parser (which probably should be removed as the async parser seems +stable). + +Best wishes + +Mark + + + + + + +> +> Tomi +> +>> +>> Best wishes +>> +>> Mark +>> +>> +>> contrib/notmuch-pick/notmuch-pick.el | 7 +++---- +>> 1 files changed, 3 insertions(+), 4 deletions(-) +>> +>> diff --git a/contrib/notmuch-pick/notmuch-pick.el b/contrib/notmuch-pick/notmuch-pick.el +>> index fbd7c0b..7f5f729 100644 +>> --- a/contrib/notmuch-pick/notmuch-pick.el +>> +++ b/contrib/notmuch-pick/notmuch-pick.el +>> @@ -817,16 +817,15 @@ Complete list of currently available key bindings: +>> (if (equal (car (process-lines notmuch-command "count" search-args)) "0") +>> (setq search-args basic-query)) +>> (if notmuch-pick-asynchronous-parser +>> - (let ((proc (start-process +>> - "notmuch-pick" buffer +>> - notmuch-command "show" "--body=false" "--format=sexp" +>> + (let ((proc (notmuch-start-notmuch +>> + "notmuch-pick" buffer #'notmuch-pick-process-sentinel +>> + "show" "--body=false" "--format=sexp" +>> message-arg search-args)) +>> ;; Use a scratch buffer to accumulate partial output. +>> ;; This buffer will be killed by the sentinel, which +>> ;; should be called no matter how the process dies. +>> (parse-buf (generate-new-buffer " *notmuch pick parse*"))) +>> (process-put proc 'parse-buf parse-buf) +>> - (set-process-sentinel proc 'notmuch-pick-process-sentinel) +>> (set-process-filter proc 'notmuch-pick-process-filter) +>> (set-process-query-on-exit-flag proc nil)) +>> (progn +>> -- +>> 1.7.9.1 +>> +>> _______________________________________________ +>> notmuch mailing list +>> notmuch@notmuchmail.org +>> http://notmuchmail.org/mailman/listinfo/notmuch