From: Mark Walters Date: Fri, 9 May 2014 11:28:51 +0000 (+0100) Subject: Re: [PATCH v4 0/2] emacs: show: redesign unread/read logic X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=ccedc13390f91f80c6d60fe95952f39d51f98375;p=notmuch-archives.git Re: [PATCH v4 0/2] emacs: show: redesign unread/read logic --- diff --git a/ec/ab905f5428f8c15862550ac97d8f1ec3f86a8e b/ec/ab905f5428f8c15862550ac97d8f1ec3f86a8e new file mode 100644 index 000000000..ccd12a450 --- /dev/null +++ b/ec/ab905f5428f8c15862550ac97d8f1ec3f86a8e @@ -0,0 +1,114 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 2A592431FBF + for ; Fri, 9 May 2014 04:29:07 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 3.001 +X-Spam-Level: *** +X-Spam-Status: No, score=3.001 tagged_above=-999 required=5 + tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, + FREEMAIL_REPLY=2.499, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_LOW=-0.7] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id GSFW1N+n+v9h for ; + Fri, 9 May 2014 04:28:59 -0700 (PDT) +Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 0AC98431FBC + for ; Fri, 9 May 2014 04:28:59 -0700 (PDT) +Received: from smtp.qmul.ac.uk ([138.37.6.40]) + by mail2.qmul.ac.uk with esmtp (Exim 4.71) + (envelope-from ) + id 1Wiiyz-0005gO-5v; Fri, 09 May 2014 12:28:53 +0100 +Received: from 5751dfa2.skybroadband.com ([87.81.223.162] helo=localhost) + by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71) + (envelope-from ) + id 1Wiiyy-00034k-RV; Fri, 09 May 2014 12:28:53 +0100 +From: Mark Walters +To: David Edmondson , notmuch@notmuchmail.org +Subject: Re: [PATCH v4 0/2] emacs: show: redesign unread/read logic +In-Reply-To: +References: <1399594808-2815-1-git-send-email-markwalters1009@gmail.com> + +User-Agent: Notmuch/0.15.2+615~g78e3a93 (http://notmuchmail.org) Emacs/23.4.1 + (x86_64-pc-linux-gnu) +Date: Fri, 09 May 2014 12:28:51 +0100 +Message-ID: <87d2fnmbrg.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Sender-Host-Address: 87.81.223.162 +X-QM-Geographic: According to ripencc, + this message was delivered by a machine in Britain (UK) (GB). +X-QM-SPAM-Info: Sender has good ham record. :) +X-QM-Body-MD5: 6040852ddba9712bacda32d8ffd41e75 (of first 20000 bytes) +X-SpamAssassin-Score: 0.5 +X-SpamAssassin-SpamBar: / +X-SpamAssassin-Report: The QM spam filters have analysed this message to + determine if it is + spam. We require at least 5.0 points to mark a message as spam. + This message scored 0.5 points. Summary of the scoring: + * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail + provider * (markwalters1009[at]gmail.com) + * 1.0 FREEMAIL_REPLY From and body contain different freemails + * -0.5 AWL AWL: From: address is in the auto white-list +X-QM-Scan-Virus: ClamAV says the message is clean +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Fri, 09 May 2014 11:29:07 -0000 + +On Fri, 09 May 2014, David Edmondson wrote: +> On Fri, May 09 2014, Mark Walters wrote: +>> This is v4 of this set. v3 is at id:1395777793-13297-1-git-send-email-markwalters1009@gmail.com +>> +>> David (dme) was not keen on the logic in the previous patch so I have +>> tried to make it rather more customisable and made this version much +>> closer to the existing logic. +>> +>> This version marks the current message read if it is open. It doesn't +>> care how you get there: whether it is notmuch commands n/N/p/P next +>> message etc, emacs commands like scroll up, mouse clicks etc. +>> +>> The only proviso is it will only mark a message read once (in a single +>> buffer and between refreshes) as otherwise it is impossible for a user +>> to choose to mark a message unread. +> +> This version looks good to me, thanks for considering the feedback. + +Hi + +Thanks for looking and testing. + +>> I, personally, like my previous logic much more. But with this setup +>> that can be customized easily in my .emacs (we may choose to add other +>> options into mainline later). Also I think this series fixes all of +>> the problems with the current read/unread logic mentioned in +>> id:87a9atmpkf.fsf@qmul.ac.uk are fixed. +> +> Just to confirm: you can get your desired behaviour by writing an +> alternative `notmuch-show-mark-read-function'? + +Yes I can confirm that. So if this went in I can get the behaviour of +the earlier series without needing to patch notmuch. + +We can decide later if we want to include it (and other possible mark +read functions) as an option, or as a contrib file, or just on the wiki. + +Best wishes + +Mark +