From: Mark Walters Date: Thu, 23 Jan 2014 17:50:39 +0000 (+0000) Subject: Re: Round 2: fix for notmuch show segfault X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=ccc0c07e3d59bb3823315d4fa05aadfe92cb80e9;p=notmuch-archives.git Re: Round 2: fix for notmuch show segfault --- diff --git a/3a/0f8fc3fbd85c1677a3f3f0a00d5104167b106e b/3a/0f8fc3fbd85c1677a3f3f0a00d5104167b106e new file mode 100644 index 000000000..1bb6d997d --- /dev/null +++ b/3a/0f8fc3fbd85c1677a3f3f0a00d5104167b106e @@ -0,0 +1,90 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 219E9431FB6 + for ; Thu, 23 Jan 2014 09:53:25 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -1.098 +X-Spam-Level: +X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5 + tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, + NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 5ITFZlWA0jp7 for ; + Thu, 23 Jan 2014 09:53:17 -0800 (PST) +Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id D6C5F431FAF + for ; Thu, 23 Jan 2014 09:53:16 -0800 (PST) +Received: from smtp.qmul.ac.uk ([138.37.6.40]) + by mail2.qmul.ac.uk with esmtp (Exim 4.71) + (envelope-from ) + id 1W6OSa-0007Is-FG; Thu, 23 Jan 2014 17:53:04 +0000 +Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost) + by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71) + (envelope-from ) + id 1W6ORh-0004hr-75; Thu, 23 Jan 2014 17:52:05 +0000 +From: Mark Walters +To: David Bremner , notmuch@notmuchmail.org +Subject: Re: Round 2: fix for notmuch show segfault +In-Reply-To: <1390479841-17045-1-git-send-email-david@tethera.net> +References: + <1390479841-17045-1-git-send-email-david@tethera.net> +User-Agent: Notmuch/0.15.2+484~gfb59956 (http://notmuchmail.org) Emacs/23.4.1 + (x86_64-pc-linux-gnu) +Date: Thu, 23 Jan 2014 17:50:39 +0000 +Message-ID: <87a9emzixc.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Sender-Host-Address: 93.97.24.31 +X-QM-Geographic: According to ripencc, + this message was delivered by a machine in Britain (UK) (GB). +X-QM-SPAM-Info: Sender has good ham record. :) +X-QM-Body-MD5: 696d373655d574e3c5610e7b3d50afb2 (of first 20000 bytes) +X-SpamAssassin-Score: 0.0 +X-SpamAssassin-SpamBar: / +X-SpamAssassin-Report: The QM spam filters have analysed this message to + determine if it is + spam. We require at least 5.0 points to mark a message as spam. + This message scored 0.0 points. Summary of the scoring: + * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail + provider * (markwalters1009[at]gmail.com) + * 0.0 AWL AWL: From: address is in the auto white-list +X-QM-Scan-Virus: ClamAV says the message is clean +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 23 Jan 2014 17:53:25 -0000 + + +This looks good and works (tested without patch 2/3). I don't have a +view on whether we should do the second patch or just update the docs. + +Best wishes + +Mark + + + +On Thu, 23 Jan 2014, David Bremner wrote: +> Second try. The second patch is now not really needed (although I +> didn't test without it). If omitted, the library docs should probably +> be updated. +> +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> http://notmuchmail.org/mailman/listinfo/notmuch