From: David Bremner <david@tethera.net>
Date: Sun, 5 Oct 2014 08:30:30 +0000 (+0200)
Subject: Re: [PATCH 06/11] lib: Internal support for querying and creating ghost	messages
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=cc6cf2ba8a554aa6c9a50c860af160a7fdba2a99;p=notmuch-archives.git

Re: [PATCH 06/11] lib: Internal support for querying and creating ghost	messages
---

diff --git a/2a/69e54e416e52834220dc5527d4375212ba828e b/2a/69e54e416e52834220dc5527d4375212ba828e
new file mode 100644
index 000000000..92c78246e
--- /dev/null
+++ b/2a/69e54e416e52834220dc5527d4375212ba828e
@@ -0,0 +1,66 @@
+Return-Path: <david@tethera.net>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+	by olra.theworths.org (Postfix) with ESMTP id 15CA5431FC3
+	for <notmuch@notmuchmail.org>; Sun,  5 Oct 2014 01:30:45 -0700 (PDT)
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
+X-Spam-Flag: NO
+X-Spam-Score: 0
+X-Spam-Level: 
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
+	autolearn=disabled
+Received: from olra.theworths.org ([127.0.0.1])
+	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
+	with ESMTP id 0ToNfnSRcPjS for <notmuch@notmuchmail.org>;
+	Sun,  5 Oct 2014 01:30:40 -0700 (PDT)
+Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])
+	(using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
+	(No client certificate requested)
+	by olra.theworths.org (Postfix) with ESMTPS id E5D44431FB6
+	for <notmuch@notmuchmail.org>; Sun,  5 Oct 2014 01:30:40 -0700 (PDT)
+Received: from remotemail by yantan.tethera.net with local (Exim 4.80)
+	(envelope-from <david@tethera.net>)
+	id 1XahDE-0007iE-1w; Sun, 05 Oct 2014 05:30:40 -0300
+Received: (nullmailer pid 24641 invoked by uid 1000); Sun, 05 Oct 2014
+	08:30:30 -0000
+From: David Bremner <david@tethera.net>
+To: Austin Clements <aclements@csail.mit.edu>, notmuch@notmuchmail.org
+Subject: Re: [PATCH 06/11] lib: Internal support for querying and creating
+	ghost	messages
+In-Reply-To: <1412345958-8278-7-git-send-email-aclements@csail.mit.edu>
+References: <1412345958-8278-1-git-send-email-aclements@csail.mit.edu>
+	<1412345958-8278-7-git-send-email-aclements@csail.mit.edu>
+User-Agent: Notmuch/0.18.1+98~gae27403 (http://notmuchmail.org) Emacs/24.3.1
+	(x86_64-pc-linux-gnu)
+Date: Sun, 05 Oct 2014 10:30:30 +0200
+Message-ID: <87fvf2q5p5.fsf@maritornes.cs.unb.ca>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.13
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+	<notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Sun, 05 Oct 2014 08:30:45 -0000
+
+Austin Clements <aclements@csail.mit.edu> writes:
+
+> +	    message->flags &= ~(1 << NOTMUCH_MESSAGE_FLAG_GHOST);
+
+What do you think about using bit set / clear / read macros?  I don't
+insist, but I wonder if it would make this part more readable.
+
+> +	else if (*i == "Tghost")
+> +	    message->flags |= (1 << NOTMUCH_MESSAGE_FLAG_GHOST);
+> +	else
+
+It makes me faintly unhappy to have the prefix hardcoded here.
+Not sure if there is a sensible solution.