From: Rüdiger Sonderfeld <ruediger@c-plusplus.de>
Date: Sun, 10 Jun 2012 07:38:03 +0000 (-0500)
Subject: git-blame.el: use mapc instead of mapcar
X-Git-Tag: v1.7.12-rc0~84^2
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=cbbc935ce0ce51ecb51bea7f841d578297f8b8ae;p=git.git

git-blame.el: use mapc instead of mapcar

Using mapcar here is a waste of memory because the mapped result
is not used.

Noticed by emacs ("Warning: `mapcar' called for effect").

[jn: split from a larger patch, with new description]

Signed-off-by: Rüdiger Sonderfeld <ruediger@c-plusplus.de>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/contrib/emacs/git-blame.el b/contrib/emacs/git-blame.el
index d351cfb6e..37d797e12 100644
--- a/contrib/emacs/git-blame.el
+++ b/contrib/emacs/git-blame.el
@@ -304,7 +304,7 @@ See also function `git-blame-mode'."
 
 (defun git-blame-cleanup ()
   "Remove all blame properties"
-    (mapcar 'delete-overlay git-blame-overlays)
+    (mapc 'delete-overlay git-blame-overlays)
     (setq git-blame-overlays nil)
     (remove-git-blame-text-properties (point-min) (point-max)))