From: Shawn O. Pearce Date: Sat, 18 Nov 2006 06:20:37 +0000 (-0500) Subject: git-gui: Display error dialog on Mac OS X when no .git found. X-Git-Tag: gitgui-0.6.0~201 X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=cbbaa28bc0a2b607b0f5e2e23f910d1619b52b0f;p=git.git git-gui: Display error dialog on Mac OS X when no .git found. If we can't locate a .git directory for the given directory we need to show a message to the user to let them know the directory wasn't found. But since this is before we have shown our main application window we cannot use that as the parent for the error popup; on Mac OS X this causes an error and prevents the dialog from showing. Instead only add -parent . to the popup call if we have mapped (shown) the main window. Signed-off-by: Shawn O. Pearce --- diff --git a/git-gui b/git-gui index 472bcb7e3..12a46e976 100755 --- a/git-gui +++ b/git-gui @@ -130,12 +130,15 @@ proc error_popup {msg} { end] append title {)} } - tk_messageBox \ - -parent . \ + set cmd [list tk_messageBox \ -icon error \ -type ok \ -title "$title: error" \ - -message $msg + -message $msg] + if {[winfo ismapped .]} { + lappend cmd -parent . + } + eval $cmd } proc info_popup {msg} {