From: Tim Harder <radhermit@gentoo.org>
Date: Fri, 27 Sep 2019 06:58:01 +0000 (-0600)
Subject: flag-o-matic.eclass: test-flag-PROG(): verify selected compiler exists
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=cab160d3c614472e20f145e65a2d7f72bdf615b7;p=gentoo.git

flag-o-matic.eclass: test-flag-PROG(): verify selected compiler exists

Before trying to use it. Fixes stricter phase running done by pkgcore
which explicitly dies when encountering unknown commands.

Closes: https://bugs.gentoo.org/695706

Signed-off-by: Tim Harder <radhermit@gentoo.org>
---

diff --git a/eclass/flag-o-matic.eclass b/eclass/flag-o-matic.eclass
index 3b32bd9d6319..89b259cc222f 100644
--- a/eclass/flag-o-matic.eclass
+++ b/eclass/flag-o-matic.eclass
@@ -435,8 +435,12 @@ test-flag-PROG() {
 
 	[[ -z ${comp} || -z $1 ]] && return 1
 
+	# verify selected compiler exists before using it
+	comp=$(tc-get${comp})
+	type -p ${comp} >/dev/null || return 1
+
 	local cmdline=(
-		$(tc-get${comp})
+		${comp}
 		# Clang will warn about unknown gcc flags but exit 0.
 		# Need -Werror to force it to exit non-zero.
 		-Werror