From: david Date: Sun, 2 Jun 2013 12:16:10 +0000 (+2100) Subject: [PATCH] emacs: replace (funcall 'foo ...) with (foo ...) X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=ca78fd9e212e959f7da6fc3bb1db7d19257145ec;p=notmuch-archives.git [PATCH] emacs: replace (funcall 'foo ...) with (foo ...) --- diff --git a/54/f80ed9c0f612da408d981519696868c64d1c3c b/54/f80ed9c0f612da408d981519696868c64d1c3c new file mode 100644 index 000000000..30e67ff12 --- /dev/null +++ b/54/f80ed9c0f612da408d981519696868c64d1c3c @@ -0,0 +1,143 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 11564429E25 + for ; Sun, 2 Jun 2013 05:16:40 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -2.3 +X-Spam-Level: +X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 35zpnU-uHUll for ; + Sun, 2 Jun 2013 05:16:32 -0700 (PDT) +Received: from tempo.its.unb.ca (tempo.its.unb.ca [131.202.1.21]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id DCD08431E64 + for ; Sun, 2 Jun 2013 05:16:31 -0700 (PDT) +Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238]) + by tempo.its.unb.ca (8.13.8/8.13.8) with ESMTP id r52CGO9d009519; + Sun, 2 Jun 2013 09:16:24 -0300 +Received: from fctnnbsc30w-156034082078.dhcp-dynamic.fibreop.nb.bellaliant.net + ([156.34.82.78] helo=zancas.localnet) + by tesseract.cs.unb.ca with esmtpsa + (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) + (envelope-from ) + id 1Uj7Cx-0005jE-Dw; Sun, 02 Jun 2013 09:16:23 -0300 +Received: from bremner by zancas.localnet with local (Exim 4.80) + (envelope-from ) + id 1Uj7Cr-0003Ym-RY; Sun, 02 Jun 2013 09:16:17 -0300 +From: david@tethera.net +To: notmuch@notmuchmail.org +Subject: [PATCH] emacs: replace (funcall 'foo ...) with (foo ...) +Date: Sun, 2 Jun 2013 09:16:10 -0300 +Message-Id: <1370175370-13561-1-git-send-email-david@tethera.net> +X-Mailer: git-send-email 1.8.2.rc2 +X-Spam_bar: - +Cc: David Bremner +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 02 Jun 2013 12:16:40 -0000 + +From: David Bremner + +I can't see any benefit to the funcall, and it looks like the result +of cut-and-paste from some code that actually used a variable for the +function to call. +--- + +Mark and I were discussing some style issues in the context of pick, +and it seems to me that some of the elisp style in the current code +could be improved. I don't claim to be an elisp style expert by any +stretch of the imagination. It would be great if some experts could +add a section to devel/STYLE about elisp. + + + emacs/notmuch-message.el | 2 +- + emacs/notmuch-show.el | 6 +++--- + emacs/notmuch.el | 4 ++-- + 3 files changed, 6 insertions(+), 6 deletions(-) + +diff --git a/emacs/notmuch-message.el b/emacs/notmuch-message.el +index 4dc4883..914bdd1 100644 +--- a/emacs/notmuch-message.el ++++ b/emacs/notmuch-message.el +@@ -40,7 +40,7 @@ the \"inbox\" and \"todo\" tags, you would set: + ;; get the in-reply-to header and parse it for the message id. + (let ((rep (mail-header-parse-addresses (message-field-value "In-Reply-To")))) + (when (and notmuch-message-replied-tags rep) +- (funcall 'notmuch-tag (notmuch-id-to-query (car (car rep))) ++ (notmuch-tag (notmuch-id-to-query (car (car rep))) + (notmuch-tag-change-list notmuch-message-replied-tags))))) + + (add-hook 'message-send-hook 'notmuch-message-mark-replied) +diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el +index 613e666..18b4671 100644 +--- a/emacs/notmuch-show.el ++++ b/emacs/notmuch-show.el +@@ -1726,7 +1726,7 @@ TAG-CHANGES is a list of tag operations for `notmuch-tag'." + (let* ((current-tags (notmuch-show-get-tags)) + (new-tags (notmuch-update-tags current-tags tag-changes))) + (unless (equal current-tags new-tags) +- (funcall 'notmuch-tag (notmuch-show-get-message-id) tag-changes) ++ (notmuch-tag (notmuch-show-get-message-id) tag-changes) + (notmuch-show-set-tags new-tags)))) + + (defun notmuch-show-tag (&optional tag-changes) +@@ -1734,7 +1734,7 @@ TAG-CHANGES is a list of tag operations for `notmuch-tag'." + + See `notmuch-tag' for information on the format of TAG-CHANGES." + (interactive) +- (setq tag-changes (funcall 'notmuch-tag (notmuch-show-get-message-id) tag-changes)) ++ (setq tag-changes (notmuch-tag (notmuch-show-get-message-id) tag-changes)) + (let* ((current-tags (notmuch-show-get-tags)) + (new-tags (notmuch-update-tags current-tags tag-changes))) + (unless (equal current-tags new-tags) +@@ -1745,7 +1745,7 @@ See `notmuch-tag' for information on the format of TAG-CHANGES." + + See `notmuch-tag' for information on the format of TAG-CHANGES." + (interactive) +- (setq tag-changes (funcall 'notmuch-tag (notmuch-show-get-messages-ids-search) tag-changes)) ++ (setq tag-changes (notmuch-tag (notmuch-show-get-messages-ids-search) tag-changes)) + (notmuch-show-mapc + (lambda () + (let* ((current-tags (notmuch-show-get-tags)) +diff --git a/emacs/notmuch.el b/emacs/notmuch.el +index 5a8c957..af107e2 100644 +--- a/emacs/notmuch.el ++++ b/emacs/notmuch.el +@@ -562,7 +562,7 @@ will be signaled." + (defun notmuch-search-tag-region (beg end &optional tag-changes) + "Change tags for threads in the given region." + (let ((search-string (notmuch-search-find-thread-id-region-search beg end))) +- (setq tag-changes (funcall 'notmuch-tag search-string tag-changes)) ++ (setq tag-changes (notmuch-tag search-string tag-changes)) + (notmuch-search-foreach-result beg end + (lambda (pos) + (notmuch-search-set-tags +@@ -576,7 +576,7 @@ See `notmuch-tag' for information on the format of TAG-CHANGES." + (interactive) + (let* ((beg (if (region-active-p) (region-beginning) (point))) + (end (if (region-active-p) (region-end) (point)))) +- (funcall 'notmuch-search-tag-region beg end tag-changes))) ++ (notmuch-search-tag-region beg end tag-changes))) + + (defun notmuch-search-add-tag () + "Same as `notmuch-search-tag' but sets initial input to '+'." +-- +1.8.2.rc2 +