From: Jinwoo Lee Date: Mon, 15 Jun 2015 03:56:57 +0000 (+1700) Subject: Re: [PATCH] lib, ruby: make use of -Wl,--no-undefined configurable X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=c9938b2ceafcf56e5dc981a803d493975a3f4d54;p=notmuch-archives.git Re: [PATCH] lib, ruby: make use of -Wl,--no-undefined configurable --- diff --git a/7d/44abe04da526fbcc960d91c3887859a68afb8f b/7d/44abe04da526fbcc960d91c3887859a68afb8f new file mode 100644 index 000000000..5bb292ed1 --- /dev/null +++ b/7d/44abe04da526fbcc960d91c3887859a68afb8f @@ -0,0 +1,98 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id C9F8D6DE1639 + for ; Sun, 14 Jun 2015 20:57:04 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: -0.297 +X-Spam-Level: +X-Spam-Status: No, score=-0.297 tagged_above=-999 required=5 tests=[AWL=0.254, + DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, + FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, + RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001] autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 3uA_wUAxvOMg for ; + Sun, 14 Jun 2015 20:57:02 -0700 (PDT) +Received: from mail-pa0-f51.google.com (mail-pa0-f51.google.com + [209.85.220.51]) + by arlo.cworth.org (Postfix) with ESMTPS id 3F6C36DE141E + for ; Sun, 14 Jun 2015 20:57:02 -0700 (PDT) +Received: by pabqy3 with SMTP id qy3so56889266pab.3 + for ; Sun, 14 Jun 2015 20:57:01 -0700 (PDT) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; + h=from:to:subject:in-reply-to:references:user-agent:date:message-id + :mime-version:content-type; + bh=/Hh4wzXl3lF9nK1/VyVXusM+ailo1I5KltvQTmgRrQ8=; + b=HRGGQCNQ0pUxxfIHKGd7w1iM0HLVI+V7A4ZbJNuOsYYs3uTL0GzIXYjIHBIC/9xql7 + 4JQ1pxKYsl73U7a5W1ss7yGXP7wczPVa/w8XNsP/ivdeJItQzGayy4IpNAzMWFCKxWZp + 8RY+paR7o+4SFcLxMXtj0QlGr7iZC5U0HyOtAmQBRWfsI/xKGqmxKiKN9yR/IKRgSSUi + MlGSvTETyAlpWeMmzcdS4vhz02vRWFkMljDiSAXizuJ0ojUQEmR/CrRKTHvqnO4RgwLZ + M9947ffnPFS2RfgXwVsJ0Jeje178noUZ0INZxS9hMI5E1jKcnLa2JrnWyAfaZ9pj5olg + +X4A== +X-Received: by 10.68.244.73 with SMTP id xe9mr44141522pbc.98.1434340621383; + Sun, 14 Jun 2015 20:57:01 -0700 (PDT) +Received: from localhost (c-24-130-61-213.hsd1.ca.comcast.net. + [24.130.61.213]) by mx.google.com with ESMTPSA id + q5sm10527129pde.56.2015.06.14.20.56.58 (version=TLSv1.2 + cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 14 Jun 2015 20:56:59 + -0700 (PDT) +From: Jinwoo Lee +To: David Bremner , notmuch@notmuchmail.org +Subject: Re: [PATCH] lib, ruby: make use of -Wl,--no-undefined configurable +In-Reply-To: <87oaki3zrh.fsf@maritornes.cs.unb.ca> +References: <1433142542-2307-3-git-send-email-david@tethera.net> + <1434261524-14139-1-git-send-email-david@tethera.net> + + <87r3peye4q.fsf@maritornes.cs.unb.ca> + + <87oaki3zrh.fsf@maritornes.cs.unb.ca> +User-Agent: Notmuch/0.20.1+21~g4e79903 (http://notmuchmail.org) Emacs/24.5.1 + (x86_64-apple-darwin14.3.0) +Date: Sun, 14 Jun 2015 20:56:57 -0700 +Message-ID: +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.18 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 15 Jun 2015 03:57:04 -0000 + +On Sun, Jun 14, 2015 at 11:34 AM, David Bremner wrote: +> Jinwoo Lee writes: +> +>> When I apply those 2 patches from you, things seem to work. I still get +>> warnings like below, but they don't seem severe. I'm not sure if the +>> ruby binding actually works though. +>> +>> ld: warning: ignoring file ../../lib/libnotmuch.dylib, file was built for x86_64 which is not the architecture being linked (i386): ../../lib/libnotmuch.dylib +>> +> +> That one is a bit worrying, but I don't know enough about OS X to know +> for sure. If you have time/interest, can you try running the tests in +> +> id:1433142542-2307-5-git-send-email-david@tethera.net +> +> Just apply the patch and make tests. That should indicate if the +> bindings are basically working. + +Do you mean `make test', not `make tests'? + +`make test' errors saying that the bash version must be >= 4.0. Bash on +my mac is 3.2.57, which is the default bash installed on Yosemite. + + Error: The notmuch test suite requires a bash version >= 4.0 + due to use of associative arrays within the test suite. + Please try again with a newer bash (or help us fix the + test suite to be more portable). Thanks.