From: Tomi Ollila <tomi.ollila@iki.fi>
Date: Sun, 1 May 2016 17:48:53 +0000 (+0300)
Subject: Re: [Patch v2 04/13] lib/cli: add library API / CLI for compile time options
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=c9680f630a6d90b3016f90803fbc2dde59e7009e;p=notmuch-archives.git

Re: [Patch v2 04/13] lib/cli: add library API / CLI for compile time options
---

diff --git a/37/7af0593f683eece2d2be03cadb735e055bcf57 b/37/7af0593f683eece2d2be03cadb735e055bcf57
new file mode 100644
index 000000000..27360c6c9
--- /dev/null
+++ b/37/7af0593f683eece2d2be03cadb735e055bcf57
@@ -0,0 +1,87 @@
+Return-Path: <tomi.ollila@iki.fi>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+ by arlo.cworth.org (Postfix) with ESMTP id 7A4886DE02AD
+ for <notmuch@notmuchmail.org>; Sun,  1 May 2016 10:49:17 -0700 (PDT)
+X-Virus-Scanned: Debian amavisd-new at cworth.org
+X-Spam-Flag: NO
+X-Spam-Score: 0.606
+X-Spam-Level: 
+X-Spam-Status: No, score=0.606 tagged_above=-999 required=5 tests=[AWL=-0.046,
+  SPF_NEUTRAL=0.652] autolearn=disabled
+Received: from arlo.cworth.org ([127.0.0.1])
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
+ with ESMTP id QQtYWX3XcZIu for <notmuch@notmuchmail.org>;
+ Sun,  1 May 2016 10:49:09 -0700 (PDT)
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
+ by arlo.cworth.org (Postfix) with ESMTP id C6E8E6DE01BE
+ for <notmuch@notmuchmail.org>; Sun,  1 May 2016 10:49:08 -0700 (PDT)
+Received: from guru.guru-group.fi (localhost [IPv6:::1])
+ by guru.guru-group.fi (Postfix) with ESMTP id E322A10004A
+ for <notmuch@notmuchmail.org>; Sun,  1 May 2016 20:48:53 +0300 (EEST)
+From: Tomi Ollila <tomi.ollila@iki.fi>
+To: notmuch@notmuchmail.org
+Subject: Re: [Patch v2 04/13] lib/cli: add library API / CLI for compile time
+ options
+In-Reply-To: <87inyz8g8f.fsf@zancas.localnet>
+References: <1459015043-8460-1-git-send-email-david@tethera.net>
+ <1459015043-8460-5-git-send-email-david@tethera.net>
+ <m27ffjvt9j.fsf@guru.guru-group.fi> <87inyz8g8f.fsf@zancas.localnet>
+User-Agent: Notmuch/0.22+9~gb26b5ad (http://notmuchmail.org) Emacs/24.3.1
+ (x86_64-unknown-linux-gnu)
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
+ $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
+ !)g;OY^,BjTbr)Np:%c_o'jj,Z
+Date: Sun, 01 May 2016 20:48:53 +0300
+Message-ID: <m2mvo94qka.fsf@guru.guru-group.fi>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.20
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+ <notmuch.notmuchmail.org>
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Sun, 01 May 2016 17:49:17 -0000
+
+On Sat, Apr 30 2016, David Bremner <david@tethera.net> wrote:
+
+> Tomi Ollila <tomi.ollila@iki.fi> writes:
+>
+>> On Sat, Mar 26 2016, David Bremner <david@tethera.net> wrote:
+>>
+>>
+>> ... note: if this notmuch_options_present () function prevails, fix
+>> the later #if check ;D
+>>
+>> ... and
+>>
+>> void
+>> _notmuch_config_list_options () {
+>>     printf("options.compact=%s\n",
+>> 	   HAVE_XAPIAN_COMPACT ? "true" : "false");
+>>     printf("options.field_processor=%s\n",
+>> 	   HAVE_XAPIAN_FIELD_PROCESSOR ? "true" : "false");
+>> }
+>>
+>
+> This I'm not so sure about. There's a subtle distinction between what is
+> supported in the CLI and what is supported in the lib, and we really
+> want the latter. So I do think _some_ library routine is needed.
+
+Ah! this is the one thing I did not catch -- we need to know what _library_
+supports from cli/bindings/whatnot. This makes most of the things I wrote
+in my email irrelevant ;/ 
+
+You seem to have sent new series so I stop commenting this and concentrate
+on that...
+
+Tomi
+