From: Austin Clements Date: Thu, 13 Jun 2013 16:20:14 +0000 (+2000) Subject: Re: [RFC PATCH] revert: Removed top level --stderr= option X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=c9076af3eb513fadb73ab8d08179fff0d62d1b56;p=notmuch-archives.git Re: [RFC PATCH] revert: Removed top level --stderr= option --- diff --git a/c5/63e96805f33f2dc1723930b0f1776a4b3bf15d b/c5/63e96805f33f2dc1723930b0f1776a4b3bf15d new file mode 100644 index 000000000..01bebccab --- /dev/null +++ b/c5/63e96805f33f2dc1723930b0f1776a4b3bf15d @@ -0,0 +1,107 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 18CB5431FC2 + for ; Thu, 13 Jun 2013 09:20:31 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id ZJdsOatj3PFT for ; + Thu, 13 Jun 2013 09:20:21 -0700 (PDT) +Received: from dmz-mailsec-scanner-2.mit.edu (dmz-mailsec-scanner-2.mit.edu + [18.9.25.13]) + by olra.theworths.org (Postfix) with ESMTP id 3F47F431FBC + for ; Thu, 13 Jun 2013 09:20:21 -0700 (PDT) +X-AuditID: 1209190d-b7fa26d000004bab-5e-51b9f1434ab8 +Received: from mailhub-auth-3.mit.edu ( [18.9.21.43]) + by dmz-mailsec-scanner-2.mit.edu (Symantec Messaging Gateway) with SMTP + id 5F.A2.19371.341F9B15; Thu, 13 Jun 2013 12:20:19 -0400 (EDT) +Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) + by mailhub-auth-3.mit.edu (8.13.8/8.9.2) with ESMTP id r5DGKHUY001390; + Thu, 13 Jun 2013 12:20:18 -0400 +Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91]) + (authenticated bits=0) + (User authenticated as amdragon@ATHENA.MIT.EDU) + by outgoing.mit.edu (8.13.8/8.12.4) with ESMTP id r5DGKFKC002758 + (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); + Thu, 13 Jun 2013 12:20:17 -0400 +Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.80) + (envelope-from ) + id 1UnAFz-00075b-1o; Thu, 13 Jun 2013 12:20:15 -0400 +From: Austin Clements +To: Tomi Ollila , notmuch@notmuchmail.org +Subject: Re: [RFC PATCH] revert: Removed top level --stderr= option +In-Reply-To: <1370027431-16018-1-git-send-email-tomi.ollila@iki.fi> +References: <1370027431-16018-1-git-send-email-tomi.ollila@iki.fi> +User-Agent: Notmuch/0.15.2+174~g8d6aa60 (http://notmuchmail.org) Emacs/23.4.1 + (i486-pc-linux-gnu) +Date: Thu, 13 Jun 2013 12:20:14 -0400 +Message-ID: <87hah20ypt.fsf@awakening.csail.mit.edu> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Brightmail-Tracker: + H4sIAAAAAAAAA+NgFnrDIsWRmVeSWpSXmKPExsUixCmqrev8cWegwZrtohbXb85ktnizch6r + A5PH4a8LWTyerbrFHMAUxWWTkpqTWZZapG+XwJWx6t5D5oIDnBUT/7SxNzBeY+9i5OSQEDCR + uPr7NCuELSZx4d56ti5GLg4hgX2MEnc+nWeGcDYySpy7+IoVwjnNJLHtei8LhLOEUWJC+zKw + WWwCGhLb9i9nBLFFBGwlriw5CdTBwcEMNLd9XghIWFjAWeLpzpXMIDYnkL164zWw1UICThJN + E8+AtYoKJEqcbL3MDtLKIqAq8fQPWCsv0KXvfy5nhbAFJU7OfMICYjMLaEnc+PeSaQKj4Cwk + qVlIUgsYmVYxyqbkVunmJmbmFKcm6xYnJ+blpRbpGunlZpbopaaUbmIEB6ok7w7GdweVDjEK + cDAq8fBynNsZKMSaWFZcmXuIUZKDSUmUd9EHoBBfUn5KZUZicUZ8UWlOavEhRgkOZiUR3r5X + QDnelMTKqtSifJiUNAeLkjiv6C2glEB6YklqdmpqQWoRTFaGg0NJgtcPZKhgUWp6akVaZk4J + QpqJgxNkOA/QcF2QGt7igsTc4sx0iPwpRkUpcV4tkIQASCKjNA+uF5ZIXjGKA70izOsKUsUD + TEJw3a+ABjMBDS7K2A4yuCQRISXVwOiVd3qShM5Lx1d+d5iN96m2Ghcey/p87cj31loP52e2 + Kyy/vVnaFBixsz5n7+1KxueSau82cM9/2jCjPcjQfFehXb6l72KxeJkrvByX134KvbFx26FS + E1cnzr+eP79cOHbgqnvU+2vJ6l8yy87I5NYZHPx/omhd5PaDk1eINcQfFX+qdOKwp5gSS3FG + oqEWc1FxIgDfOmaR/wIAAA== +Cc: tomi.ollila@iki.fi +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 13 Jun 2013 16:20:31 -0000 + +LGTM. While I thought --stderr was a fine solution originally, now that +we've stumbled across problems that make it difficult to use correctly +and robustly, I think Tomi's right that we should probably revert it. + +On Fri, 31 May 2013, Tomi Ollila wrote: +> While looked good on paper, its attempted use caused confusion, complexity, +> and potential for information leak when passed through wrapper scripts. +> For slimmer code and to lessen demand for maintenance/support the set of +> commits which added top level --stderr= option is now reverted. +> --- +> +> Change was easy, commit message hard. Opinions? Revert is easiest to do now. +> Also, if someone comes with a novel idea how to utilize --stderr option +> please tell it now -- I'd be most eager to hear it :D +> +> +> This change was done the following way: +> +> $ git checkout -b rvrt b9020448bd +> $ git reset --hard HEAD^^^^ +> $ git reset b9020448bd +> $ git commit -a +> $ git diff HEAD~5..HEAD +> +> (last one to reveal HEAD~5 & HEAD have identical trees). +> +> Question why: +> id:20130521195549.6550.53636@thinkbox.jade-hamburg.de +> +> Good reason why not: +> id:1369934016-22308-1-git-send-email-amdragon@mit.edu