From: Mark Hills Date: Mon, 5 May 2008 16:46:42 +0000 (+0100) Subject: Be more careful with objects directory permissions on clone X-Git-Tag: v1.5.6-rc0~90 X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=c904bf392d7621b04c14bb9b2e93c3ed08f7e57b;p=git.git Be more careful with objects directory permissions on clone Honour the setgid and umask when re-creating the objects directory at the destination. cpio in copy-pass mode aims to copy file permissions which causes this problem and cannot be disabled. Be explicit by copying the directory structure first, honouring the permissions at the destination, then copy the files with 0444 permissions. This also avoids bugs in some versions of cpio. Signed-off-by: Mark Hills Signed-off-by: Junio C Hamano --- diff --git a/git-clone.sh b/git-clone.sh index 8c7fc7f63..9d88d1ce6 100755 --- a/git-clone.sh +++ b/git-clone.sh @@ -334,7 +334,10 @@ yes) fi fi && cd "$repo" && - find objects -depth -print | cpio $cpio_quiet_flag -pumd$l "$GIT_DIR/" || \ + # Create dirs using umask and permissions and destination + find objects -type d -print | (cd "$GIT_DIR" && xargs mkdir -p) && + # Copy existing 0444 permissions on content + find objects ! -type d -print | cpio $cpio_quiet_flag -pumd$l "$GIT_DIR/" || \ exit 1 fi git-ls-remote "$repo" >"$GIT_DIR/CLONE_HEAD" || exit 1