From: Marcus Brinkmann <mb@g10code.com>
Date: Mon, 25 Nov 2002 21:12:46 +0000 (+0000)
Subject: 2002-11-25  Marcus Brinkmann  <marcus@g10code.de>
X-Git-Tag: gpgme-1.2.0@1385~751
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=c862e9b50987d750aeec7b2294565c18d703b057;p=gpgme.git

2002-11-25  Marcus Brinkmann  <marcus@g10code.de>

	* rungpg.c (_gpgme_gpg_spawn): Do not set parent fds to -1.
	* posix-io.c (_gpgme_io_spawn): Call _gpgme_io_close instead close
	for parent fds.
	* w32-io.c (_gpgme_io_spawn): Call _gpgme_io_close instead
	CloseHandle for parent fds.
---

diff --git a/trunk/gpgme/ChangeLog b/trunk/gpgme/ChangeLog
index 53799be..a34cf95 100644
--- a/trunk/gpgme/ChangeLog
+++ b/trunk/gpgme/ChangeLog
@@ -1,3 +1,11 @@
+2002-11-25  Marcus Brinkmann  <marcus@g10code.de>
+
+	* rungpg.c (_gpgme_gpg_spawn): Do not set parent fds to -1.
+	* posix-io.c (_gpgme_io_spawn): Call _gpgme_io_close instead close
+	for parent fds.
+	* w32-io.c (_gpgme_io_spawn): Call _gpgme_io_close instead
+	CloseHandle for parent fds.
+
 2002-11-22  Marcus Brinkmann  <marcus@g10code.de>
 
 	* gpgme.h [_MSC_VER]: Define ssize_t as long.
diff --git a/trunk/gpgme/posix-io.c b/trunk/gpgme/posix-io.c
index da7c106..ecd7a21 100644
--- a/trunk/gpgme/posix-io.c
+++ b/trunk/gpgme/posix-io.c
@@ -257,7 +257,7 @@ _gpgme_io_spawn (const char *path, char **argv,
 
   /* .dup_to is not used in the parent list.  */
   for (i = 0; fd_parent_list[i].fd != -1; i++)
-    close (fd_parent_list[i].fd);
+    _gpgme_io_close (fd_parent_list[i].fd);
 
   return 0;
 }
diff --git a/trunk/gpgme/rungpg.c b/trunk/gpgme/rungpg.c
index 05d0718..9a556ce 100644
--- a/trunk/gpgme/rungpg.c
+++ b/trunk/gpgme/rungpg.c
@@ -1137,21 +1137,18 @@ gpg_start (void *engine, void *opaque)
       fd_parent_list[n].fd = gpg->status.fd[1];
       fd_parent_list[n].dup_to = -1;
       n++;
-      gpg->status.fd[1] = -1;
     }
   if (gpg->colon.fd[1] != -1)
     {
       fd_parent_list[n].fd = gpg->colon.fd[1];
       fd_parent_list[n].dup_to = -1;
       n++;
-      gpg->colon.fd[1] = -1;
     }
   for (i = 0; gpg->fd_data_map[i].data; i++)
     {
       fd_parent_list[n].fd = gpg->fd_data_map[i].peer_fd;
       fd_parent_list[n].dup_to = -1;
       n++;
-      gpg->fd_data_map[i].peer_fd = -1;
     }        
   fd_parent_list[n].fd = -1;
   fd_parent_list[n].dup_to = -1;
diff --git a/trunk/gpgme/w32-io.c b/trunk/gpgme/w32-io.c
index df2583b..91dfe87 100644
--- a/trunk/gpgme/w32-io.c
+++ b/trunk/gpgme/w32-io.c
@@ -899,11 +899,8 @@ _gpgme_io_spawn ( const char *path, char **argv,
     }
 
     /* Close the other ends of the pipes */
-    for (i=0; fd_parent_list[i].fd != -1; i++ ) {
-        DEBUG1 ("Closing fd %d\n", fd_parent_list[i].fd );
-        if ( !CloseHandle ( fd_to_handle (fd_parent_list[i].fd) ) )
-            DEBUG1 ("CloseHandle failed: ec=%d", (int)GetLastError());
-    }
+    for (i = 0; fd_parent_list[i].fd != -1; i++)
+      _gpgme_io_close (fd_parent_list[i].fd);
 
     DEBUG4 ("CreateProcess ready\n"
             "-   hProcess=%p  hThread=%p\n"