From: David Bremner Date: Fri, 18 Sep 2015 13:26:00 +0000 (+2100) Subject: Re: [bug] notmuch requires Content-Disposition mime header value to be lower case X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=c81413d699d425d2516e4fe6053783a99d9fba70;p=notmuch-archives.git Re: [bug] notmuch requires Content-Disposition mime header value to be lower case --- diff --git a/20/84d8a74e2162e04caf6933d5ad5d77dde0d570 b/20/84d8a74e2162e04caf6933d5ad5d77dde0d570 new file mode 100644 index 000000000..6f04378fb --- /dev/null +++ b/20/84d8a74e2162e04caf6933d5ad5d77dde0d570 @@ -0,0 +1,82 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id B945D6DE140B + for ; Fri, 18 Sep 2015 06:27:13 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: 0.114 +X-Spam-Level: +X-Spam-Status: No, score=0.114 tagged_above=-999 required=5 tests=[AWL=0.114] + autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id vthQs6nv3g0V for ; + Fri, 18 Sep 2015 06:27:12 -0700 (PDT) +Received: from gitolite.debian.net (gitolite.debian.net [87.98.215.224]) + by arlo.cworth.org (Postfix) with ESMTPS id F3B236DE0AF8 + for ; Fri, 18 Sep 2015 06:27:11 -0700 (PDT) +Received: from remotemail by gitolite.debian.net with local (Exim 4.80) + (envelope-from ) + id 1Zcvg6-0001Tj-Gu; Fri, 18 Sep 2015 13:26:14 +0000 +Received: (nullmailer pid 21542 invoked by uid 1000); Fri, 18 Sep 2015 + 13:26:00 -0000 +From: David Bremner +To: Johannes Schauer , notmuch@notmuchmail.org +Subject: Re: [bug] notmuch requires Content-Disposition mime header value to + be lower case +In-Reply-To: <20150918123724.1941.3900@localhost> +References: <20150917070056.1941.94846@localhost> + <20150917083612.1941.22480@localhost> <20150917083956.1941.35098@localhost> + <87pp1grl2v.fsf@maritornes.cs.unb.ca> <20150918123724.1941.3900@localhost> +User-Agent: Notmuch/0.20.2+61~g005c2f0 (http://notmuchmail.org) Emacs/24.4.1 + (x86_64-pc-linux-gnu) +Date: Fri, 18 Sep 2015 10:26:00 -0300 +Message-ID: <871tdvvoyf.fsf@tesseract.cs.unb.ca> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.18 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Fri, 18 Sep 2015 13:27:13 -0000 + +Johannes Schauer writes: + +> Hi, +> +> Quoting David Bremner (2015-09-18 14:03:20) +>> I'd recommend making your own new test, rather than modifying existing +>> ones to test multiple things. I'd also recommend using json / sexp +>> output for your tests, since the ad-hoc text format is kindof +>> semi-deprecated. +> +> can you take care of that? My goal was actually just to report this bug, not to +> spend more time to develop a proper patch for it :) + +Consider the bug reported. At the moment I'm not completely convinced +the patch is correct, never mind the tests. I agree it looks obvious +enough, but the test results don't make sense to me yet. + +> +> Also, a related problem occurs when the Content-Disposition header contains +> UTF8 characters, in which case the header value gets encoded. Apparently +> notmuch does not attempt to decode it. Example mime header: +> +> --===============7161366892858136962== +> Content-Type: application/pdf +> MIME-Version: 1.0 +> Content-Transfer-Encoding: base64 +> Content-Disposition: =?utf-8?b?YXR0YWNobWVudDsgZmlsZW5hbWU9ImJlZ3LDvMOfdW5n?= +> =?utf-8?b?LnBkZiI=?= + +yes, that sounds like a distinct bug.