From: Lukasz Stelmach Date: Sun, 14 Dec 2014 23:49:17 +0000 (+0100) Subject: Re: [PATCH] emacs: do not change users' mail agent configuration X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=c7c2a8c148744339d9a3ca1f3095d37221f4af80;p=notmuch-archives.git Re: [PATCH] emacs: do not change users' mail agent configuration --- diff --git a/ef/2dfa6c32f164a992cf1caa05788380d6e9a79c b/ef/2dfa6c32f164a992cf1caa05788380d6e9a79c new file mode 100644 index 000000000..524a95686 --- /dev/null +++ b/ef/2dfa6c32f164a992cf1caa05788380d6e9a79c @@ -0,0 +1,183 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 1A1D8431FB6 + for ; Sun, 14 Dec 2014 15:49:37 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0.001 +X-Spam-Level: +X-Spam-Status: No, score=0.001 tagged_above=-999 required=5 + tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, + RCVD_IN_DNSWL_NONE=-0.0001] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id SuzdKh+9rxTi for ; + Sun, 14 Dec 2014 15:49:33 -0800 (PST) +Received: from smtpo.poczta.interia.pl (smtpo.poczta.interia.pl + [217.74.65.157]) + (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 968C9431FAF + for ; Sun, 14 Dec 2014 15:49:33 -0800 (PST) +X-Interia-R: Interia +X-Interia-R-IP: 89.65.17.18 +X-Interia-R-Helo: <[192.168.0.13]> +Received: from [192.168.0.13] (89-65-17-18.dynamic.chello.pl [89.65.17.18]) + (using TLSv1 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) + (No client certificate requested) + by www.poczta.fm (INTERIA.PL) with ESMTPSA; + Mon, 15 Dec 2014 00:49:29 +0100 (CET) +Message-ID: <548E21FD.4040307@poczta.fm> +Date: Mon, 15 Dec 2014 00:49:17 +0100 +From: Lukasz Stelmach +User-Agent: Mozilla/5.0 (X11; Linux x86_64; + rv:24.0) Gecko/20100101 Thunderbird/24.8.0 +MIME-Version: 1.0 +To: Jani Nikula , notmuch@notmuchmail.org +Subject: Re: [PATCH] emacs: do not change users' mail agent configuration +References: <1418410466-26604-1-git-send-email-stlman@poczta.fm> + <87k31vqn1h.fsf@nikula.org> <548CB582.4040807@poczta.fm> + <87h9wyr2bb.fsf@nikula.org> +In-Reply-To: <87h9wyr2bb.fsf@nikula.org> +X-Enigmail-Version: 1.6 +Content-Type: multipart/signed; micalg=pgp-sha1; + protocol="application/pgp-signature"; + boundary="xiub7qWL4WWHAfQqvouWvKPSQIVorrv4x" +X-Interia-Antivirus: OK +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=interia.pl; + s=biztos; t=1418600970; + bh=hiXHmWWNKHd+WVUR/R78+H63XFdUv9+wOxYJqkvQrbU=; + h=X-Interia-R:X-Interia-R-IP:X-Interia-R-Helo:Message-ID:Date:From: + User-Agent:MIME-Version:To:Subject:References:In-Reply-To: + X-Enigmail-Version:Content-Type:X-Interia-Antivirus; + b=CMsX+TxabkXmrItKrlFfTTY2k/qYa04e7V6/BqOnDGE6A+TZz+xbWzao/g0pSQAM7 + +I/1U6P3pqqW8U0gO4+nub55tRX1wDVufDKsONQUpP6CISeczf8ejHzwwob/8S/Zfd + KLQUgns+3SbqDIN1L+/XX0qHxTAC6K0I66sgKjI4= +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 14 Dec 2014 23:49:37 -0000 + +This is an OpenPGP/MIME signed message (RFC 4880 and 3156) +--xiub7qWL4WWHAfQqvouWvKPSQIVorrv4x +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: quoted-printable + +On 14.12.2014 10:46, Jani Nikula wrote: +> On Sat, 13 Dec 2014, Lukasz Stelmach wrote: +>> On 13.12.2014 22:04, Jani Nikula wrote: +>>> On Fri, 12 Dec 2014, =C5=81ukasz Stelmach wrote: +>>>> `mail-user-agent' is defined with defcustom and may be customised +>>>> by users. It should not be set to arbitrary values in modules. +>>> +>>> Point taken. +>>> +>>>> To make use of that configuration value call `compose-mail' which +>>>> starts user's preferred mail composition package as selected with +>>>> the variable `mail-user-agent' instead of notmuch's hardcoded +>>>> `message-mail'. +>>> +>>> So your proposed change is that `notmuch-mua-mail` should start +>>> whichever mua the user has configured in `mail-user-agent` instead of= + +>>> the notmuch mail composition window, as described in the function +>>> documentation? I don't think I like that either. +>>> +>>> Maybe we should let bind `mail-user-agent` instead? +>> +>> +>> Actually `message-mail` isn't a "notmuch mail composition window" but +>> rather a "mail composition window" implemented in message.el which is = +a +>> part of Emacs. Even more, it is the default "mail composition window"= + +>> in Emacs because the default value of `mail-user-agent`, as defined in= + +>> simple.el, is `message-user-agent` (since Emacs 23.3 as described in a= + +>> comment in `compose-mail` function therein) which causes to be launche= +d by +>> `compose-mail`. +>=20 +> Basically notmuch layers its own stuff on top of message mode. + +I need to dig into notmuch-mua a little bit deeper but at the first +glance it doesn't seem that what I want is impossible. What I want is: + +- keep notmuch working as it is for everyone who uses it now, + +- enable clean integration with other MUAs for those who don't use it + yet. + +The second point is very important for me because I use Gnus for +incoming mail but notmuch is definitely better for browsing archives +and I'd love to use it. + +>> TL;DR with the mail-user-agent variable set to the default value nothi= +ng +>> changes for a notmuch user. +>=20 +> Except `message-user-agent` gets used instead of `notmuch-user-agent` +> which does the layering on top. We currently don't do much more, but +> might in the future. As an example, `notmuch-mua-send-hook` won't get +> called. + +Indeed I need to sit down and draw it all. + +> Another question open to debate is, if the user is using the notmuch +> interface, and calls a function named `notmuch-mua-new-mail` to compose= + +> mail, should the function respect `mail-user-agent` and pop up a +> non-notmuch interface? Basically what we do is tested to work on top of= + +> message mode only, so all bets would be off anyway. + +And that should be kept as default. I, on the other hand have tested, +replying from notmuch with Gnus (which is also works on top of message) +and as far as I can tell it works fine. I don't say notmuch has to work +with all possible user agents, I just want it to be able to work with +more than one. + +I will keep investigating the issue. + +BTW There is also the `read-mail-command` variable in simple.el which +which might need some of our attention. + +Kind regards, +--=20 +By=C5=82o mi bardzo mi=C5=82o. Twoje oczy lubi=C4=85 mn= +ie +>=C5=81ukasz< i to mnie zgubi (c)SNL= + + + +--xiub7qWL4WWHAfQqvouWvKPSQIVorrv4x +Content-Type: application/pgp-signature; name="signature.asc" +Content-Description: OpenPGP digital signature +Content-Disposition: attachment; filename="signature.asc" + +-----BEGIN PGP SIGNATURE----- +Version: GnuPG v2 +Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ + +iQEcBAEBAgAGBQJUjiIFAAoJEAC2l2xjkdNxa4AIAIUh9AbpyM2ZeTGiCO33/dZD +cJ1bHkjWnQNZ/80pS9B9AGfaBVOue07XV3p/KQQVbKAYaXYhHwRpVozrIPqVoSdh +svM0FbAK+A7u65bk2gnDy6H489fhHMZcewQXwOkcYdiaTrZ9sLgvE/U1wf3PNsv2 +4ROt0jYxm/1k+OwIJNnoIok8jajtv3JjzUyASQfMQjuMz8aEG6SOs97eRCvUGtzW +0rFwymCfV/C4lXeMCU3WL42FyLrCLDc2Ws5CbLdhbqNkhndedJn18cseGCd/jiDr +/4Ink9JIWLoP5WJM52BwONFD009CG38Yq4N5ar9Ax3HNmzhCXRJJSCMUxAPP4bs= +=BRGt +-----END PGP SIGNATURE----- + +--xiub7qWL4WWHAfQqvouWvKPSQIVorrv4x--