From: Zac Medico Date: Sun, 3 Oct 2010 07:57:35 +0000 (-0700) Subject: TODO: Make elog 'key' parameter more unique. X-Git-Tag: v2.2_rc90~45 X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=c796cb4a86c1a852a267b828b5981be59bc28598;p=portage.git TODO: Make elog 'key' parameter more unique. --- diff --git a/pym/portage/elog/messages.py b/pym/portage/elog/messages.py index 6b4561fe7..9a0e510fb 100644 --- a/pym/portage/elog/messages.py +++ b/pym/portage/elog/messages.py @@ -82,6 +82,15 @@ def _elog_base(level, msg, phase="other", key=None, color=None, out=None): directly. """ + # TODO: Have callers pass in a more unique 'key' parameter than a plain + # cpv, in order to ensure that messages are properly grouped together + # for a given package instance, and also to ensure that each elog module's + # process() function is only called once for each unique package. This is + # needed not only when building packages in parallel, but also to preserve + # continuity in messages when a package is simply updated, since we don't + # want the elog_process() call from the uninstall of the old version to + # cause discontinuity in the elog messages of the new one being installed. + global _msgbuffer if out is None: