From: Stefano Zacchiroli Date: Thu, 21 Apr 2016 18:10:25 +0000 (+2000) Subject: Re: Fwd: [PATCH] notmuch-mutt: deduce perl interpreter location from environment X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=c6bc3b8135985642676b2dc9ffe297b216913ce2;p=notmuch-archives.git Re: Fwd: [PATCH] notmuch-mutt: deduce perl interpreter location from environment --- diff --git a/7a/cb694a65b8b983ab05548b44cc13ba99b59beb b/7a/cb694a65b8b983ab05548b44cc13ba99b59beb new file mode 100644 index 000000000..ced7ea7ac --- /dev/null +++ b/7a/cb694a65b8b983ab05548b44cc13ba99b59beb @@ -0,0 +1,118 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id 16BB56DE034D + for ; Thu, 21 Apr 2016 11:10:48 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: -0.015 +X-Spam-Level: +X-Spam-Status: No, score=-0.015 tagged_above=-999 required=5 tests=[AWL=0.097, + DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, SPF_HELO_PASS=-0.001, + SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id AMo7nAuCssfr for ; + Thu, 21 Apr 2016 11:10:40 -0700 (PDT) +Received: from upsilon.cc (upsilon.cc [178.32.142.91]) + by arlo.cworth.org (Postfix) with ESMTP id C0CA56DE01F7 + for ; Thu, 21 Apr 2016 11:10:37 -0700 (PDT) +Received: from timira.takhisis.invalid (pubnet.fsf.org [74.94.156.218]) + by upsilon.cc (Postfix) with ESMTPSA id E5B081009C; + Thu, 21 Apr 2016 20:10:36 +0200 (CEST) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=upsilon.cc; s=mail; + t=1461262237; bh=JTVMJd0lbUchdnHOh0Uu6gnX+gIMZWjv41HQjrcalKI=; + h=Date:From:To:Cc:Subject:References:In-Reply-To:From; + b=hUh1Mr+1k+m860+4SZz3pMjDoSubLr98TknbINjXcR6AO4WS6Yf6ceN6QUrLpKkQi + p1+qeo2JcmRsrkHGQuicv0S5PWI8nMqwqHyaX/4UF+mhI7SKh0N9x2IryZYhUKCinJ + /wwU/Wm4B4iTvA++MF0EWxLAWiMa5Pm7tM8IFHuc= +Received: by timira.takhisis.invalid (Postfix, from userid 1000) + id C67F560056; Thu, 21 Apr 2016 14:10:25 -0400 (EDT) +Date: Thu, 21 Apr 2016 14:10:25 -0400 +From: Stefano Zacchiroli +To: notmuch@notmuchmail.org +Subject: Re: Fwd: [PATCH] notmuch-mutt: deduce perl interpreter location from + environment +Message-ID: <20160421181025.GB8684@upsilon.cc> +References: <1459019105-4513-1-git-send-email-ato@mozilla.com> + +MIME-Version: 1.0 +Content-Type: multipart/mixed; boundary="bg08WKrSYDhXBjb5" +Content-Disposition: inline +Content-Transfer-Encoding: 8bit +In-Reply-To: + +User-Agent: Mutt/1.5.24 (2015-08-30) +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.20 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 21 Apr 2016 18:10:48 -0000 + + +--bg08WKrSYDhXBjb5 +Content-Type: text/plain; charset=iso-8859-1 +Content-Disposition: inline +Content-Transfer-Encoding: 8bit + +On Thu, Apr 21, 2016 at 06:41:38PM +0100, Andreas Tolfsen wrote: +> The patch is straight forward. You may want to just make the change +> yourself than jumping through the hoops of applying this. + +Thanks Andreas for the suggestion; makes sense to me. + +I just clarified in the commit message that, even if -w is dropped, +there is still use warnings in the script. New patch attached. + +David: can you please push this to master? + +Cheers. +-- +Stefano Zacchiroli . . . . . . . zack@upsilon.cc . . . . o . . . o . o +Maître de conférences . . . . . http://upsilon.cc/zack . . . o . . . o o +Former Debian Project Leader . . . . . @zacchiro . . . . o o o . . . o . +« the first rule of tautology club is the first rule of tautology club » + +--bg08WKrSYDhXBjb5 +Content-Type: text/x-diff; charset=us-ascii +Content-Disposition: attachment; + filename="0001-notmuch-mutt-use-env-to-locate-perl-for-increased-po.patch" + +>From 3e27c59e6ab02fa652b35ce3a23e4d324ed69b6d Mon Sep 17 00:00:00 2001 +From: Stefano Zacchiroli +Date: Thu, 21 Apr 2016 14:04:23 -0400 +Subject: [PATCH] notmuch-mutt: use env to locate perl for increased + portability + +Note: this patch drops -w from the shebang line, but we still have +"use warnings" in the script, which is superior anyhow. + +Thanks Andreas Tolfsen for the suggestion. +--- + contrib/notmuch-mutt/notmuch-mutt | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/contrib/notmuch-mutt/notmuch-mutt b/contrib/notmuch-mutt/notmuch-mutt +index b47b365..97fb2d8 100755 +--- a/contrib/notmuch-mutt/notmuch-mutt ++++ b/contrib/notmuch-mutt/notmuch-mutt +@@ -1,4 +1,4 @@ +-#!/usr/bin/perl -w ++#!/usr/bin/env perl + # + # notmuch-mutt - notmuch (of a) helper for Mutt + # +-- +2.8.0.rc3 + + +--bg08WKrSYDhXBjb5--