From: Austin Clements Date: Sat, 22 Mar 2014 14:50:05 +0000 (+2000) Subject: Re: [Patch v4 0/8] emacs: show tag changes in buffer X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=c58615292967acad780ca842c16395f4ed8ce58d;p=notmuch-archives.git Re: [Patch v4 0/8] emacs: show tag changes in buffer --- diff --git a/7c/fb3e912795b47d72efae78a049e463ec177865 b/7c/fb3e912795b47d72efae78a049e463ec177865 new file mode 100644 index 000000000..1295d5957 --- /dev/null +++ b/7c/fb3e912795b47d72efae78a049e463ec177865 @@ -0,0 +1,99 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 1CFCB431FC0 + for ; Sat, 22 Mar 2014 07:50:18 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id m3h1P2Ct6162 for ; + Sat, 22 Mar 2014 07:50:10 -0700 (PDT) +Received: from dmz-mailsec-scanner-4.mit.edu (dmz-mailsec-scanner-4.mit.edu + [18.9.25.15]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id A23C1431FBC + for ; Sat, 22 Mar 2014 07:50:10 -0700 (PDT) +X-AuditID: 1209190f-f790b6d000000c3a-8e-532da321b511 +Received: from mailhub-auth-3.mit.edu ( [18.9.21.43]) + (using TLS with cipher AES256-SHA (256/256 bits)) + (Client did not present a certificate) + by dmz-mailsec-scanner-4.mit.edu (Symantec Messaging Gateway) with SMTP + id CA.C2.03130.123AD235; Sat, 22 Mar 2014 10:50:09 -0400 (EDT) +Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) + by mailhub-auth-3.mit.edu (8.13.8/8.9.2) with ESMTP id s2MEo8Hj023426; + Sat, 22 Mar 2014 10:50:09 -0400 +Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91]) + (authenticated bits=0) + (User authenticated as amdragon@ATHENA.MIT.EDU) + by outgoing.mit.edu (8.13.8/8.12.4) with ESMTP id s2MEo6hw009058 + (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); + Sat, 22 Mar 2014 10:50:07 -0400 +Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.80) + (envelope-from ) + id 1WRNFN-0001Cx-UG; Sat, 22 Mar 2014 10:50:05 -0400 +Date: Sat, 22 Mar 2014 10:50:05 -0400 +From: Austin Clements +To: Mark Walters +Subject: Re: [Patch v4 0/8] emacs: show tag changes in buffer +Message-ID: <20140322145005.GF31187@mit.edu> +References: <1395489072-19001-1-git-send-email-markwalters1009@gmail.com> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +Content-Disposition: inline +In-Reply-To: <1395489072-19001-1-git-send-email-markwalters1009@gmail.com> +User-Agent: Mutt/1.5.21 (2010-09-15) +X-Brightmail-Tracker: + H4sIAAAAAAAAA+NgFmpileLIzCtJLcpLzFFi42IR4hTV1lVcrBts0PFBx2L1XB6L6zdnMjsw + eeycdZfd49mqW8wBTFFcNimpOZllqUX6dglcGb+WT2IvWMpacbRlOmsD4wKWLkZODgkBE4lt + H/8xQdhiEhfurWcDsYUEZjNJrLii3sXIBWRvZJRYdqubFcI5zSTx7tpiKGcJo8St5i5mkBYW + AVWJuZcawdrZBDQktu1fzghiiwjoSNw+tIAdxGYWkJb49rsZbJ2wgK3E5t3fweK8QDV9Ty6z + QKz2lLh+7C4LRFxQ4uTMJywQvVoSN/69BOrlAJuz/B8HSJhTwEvi5r9NrCC2qICKxJST29gm + MArNQtI9C0n3LITuBYzMqxhlU3KrdHMTM3OKU5N1i5MT8/JSi3RN9HIzS/RSU0o3MYKDWpJ/ + B+O3g0qHGAU4GJV4eA2UdIOFWBPLiitzDzFKcjApifK6zQcK8SXlp1RmJBZnxBeV5qQWH2KU + 4GBWEuF93AOU401JrKxKLcqHSUlzsCiJ88pzaAcLCaQnlqRmp6YWpBbBZGU4OJQkeL8uBGoU + LEpNT61Iy8wpQUgzcXCCDOcBGr4TpIa3uCAxtzgzHSJ/ilFRSpy3FCQhAJLIKM2D64UlnVeM + 4kCvCPNyLAKq4gEmLLjuV0CDmYAG80/VAhlckoiQkmpg5Pw/y3ry7DrW9w4bUk9P3/8vLHbj + 5Fe5SU16Lpl+D3aq+l+/smS637b/MSbTVlt3PpjJzSP19WfRQdbnNZNb9lxTaDwotrjW19lh + 973PvO94Vc+9aX+96lCH2+GaQxlJGyI2ZXhwCrfnya3dlvbEqbk0v02nkfnizlv/3CJSDGye + rr62+4FouxJLcUaioRZzUXEiACo/CPgVAwAA +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 22 Mar 2014 14:50:18 -0000 + +LGTM. Ship it! + +Quoth Mark Walters on Mar 22 at 11:51 am: +> This is v4 of this patch set. V3 is at +> id:1394597397-8486-1-git-send-email-markwalters1009@gmail.com. This +> addresses all the review comments from Austin. +> +> Patches 1-3 and 6-8 are unchanged. For patch 5 I have changed the +> comments slightly, tried to make the unread deleted case clearer by +> using the new `bare-tag' variable, and added all three custom format +> variables to the notmuch-faces group. +> +> For patch 6 I have switched to Austin's suggested approach with the +> changes mentioned in id:87pplek4v0.fsf@qmul.ac.uk and +> id:87mwgih2zx.fsf@qmul.ac.uk +> +> Best wishes +> +> Mark