From: Ken Raeburn <raeburn@mit.edu>
Date: Mon, 17 Nov 2008 21:34:48 +0000 (+0000)
Subject: Set krb4 and priocntl flags via site.exp instead of command line
X-Git-Tag: krb5-1.7-alpha1~201
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=c568a520f516297701bdf5a556a6b873b66c6ae5;p=krb5.git

Set krb4 and priocntl flags via site.exp instead of command line

Update set of files to clean out at test suite startup, or when
deleting the database.

Improve support for setting up slave test environment.  Don't set
KRB5_KDC_PROFILE except in KDC master and slave environments.  Create
distinct env.sh and env.csh files for different configurations.  Move
kpropd setup proc into common initialization.

Add incremental propagation test: Create new kiprop/$host principal,
update kproplog test for the new data.  "Propagate" the master
database to the slave, add a new principal, start up kpropd, watch for
the "OK" message, and check to see if the new principal exists on the
slave.

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@21134 dc483132-0cff-0310-8789-dd5450dbe970
---

diff --git a/src/tests/dejagnu/Makefile.in b/src/tests/dejagnu/Makefile.in
index 75db99789..83d73e9bf 100644
--- a/src/tests/dejagnu/Makefile.in
+++ b/src/tests/dejagnu/Makefile.in
@@ -21,8 +21,9 @@ check-runtest-no::
 	@echo "+++ runtest is unavailable."
 	@echo "+++"
 
+# Set VALGRIND at run time, that may be changed when running 'make'.
 check-runtest-yes:: t_inetd site.exp
-	$(RUNTEST) --tool krb --srcdir $(srcdir) $(KRB4_RUNTESTFLAGS) PRIOCNTL_HACK=@PRIOCNTL_HACK@ VALGRIND="$(VALGRIND)" $(RUNTESTFLAGS)
+	$(RUNTEST) --tool krb --srcdir $(srcdir) VALGRIND="$(VALGRIND)" $(RUNTESTFLAGS)
 
 t_inetd:: t_inetd.o $(KRB5_BASE_DEPLIBS)
 	$(CC_LINK) -o t_inetd t_inetd.o $(KRB5_BASE_LIBS)
@@ -45,6 +46,8 @@ site.exp: runenv.vals Makefile
 	echo "set runvarlist [list `cat runenv.vals | tr '\n' ' '`]" | \
 		sed -e 's%=\.%='`pwd`'/.%g' > site.exp
 	echo "set KRB5_DB_MODULE_DIR {$(KRB5_DB_MODULE_DIR)}" >> site.exp
+	echo "set PRIOCNTL_HACK @PRIOCNTL_HACK@" >> site.exp
+	echo set $(KRB4_RUNTESTFLAGS) | sed -e 's/=/ /' >> site.exp
 
 # +++ Dependency line eater +++
 # 
diff --git a/src/tests/dejagnu/config/default.exp b/src/tests/dejagnu/config/default.exp
index 9e6320728..50e563e2c 100644
--- a/src/tests/dejagnu/config/default.exp
+++ b/src/tests/dejagnu/config/default.exp
@@ -408,16 +408,21 @@ if ![info exists KEY] {
 # Clear away any files left over from a previous run.
 # We can't use them now because we don't know the right KEY.
 # krb5.conf might change if running tests on another host
-file delete $tmppwd/krb5.conf $tmppwd/kdc.conf $tmppwd/krb.realms $tmppwd/krb.conf
+file delete $tmppwd/krb5.conf $tmppwd/kdc.conf $tmppwd/slave.conf \
+    $tmppwd/krb.realms $tmppwd/krb.conf \
+    $tmppwd/krb5.client.conf $tmppwd/krb5.server.conf \
+    $tmppwd/krb5.kdc.conf $tmppwd/krb5.slave.conf
 
 proc delete_db {} {
     global tmppwd
+    # Master and slave db files
     file delete $tmppwd/kdc-db $tmppwd/kdc-db.ok $tmppwd/kdc-db.kadm5 \
 	$tmppwd/kdc-db.kadm5.lock \
 	$tmppwd/kdc-db.ulog \
 	$tmppwd/slave-db $tmppwd/slave-db.ok $tmppwd/slave-db.kadm5 $tmppwd/slave-db.kadm5.lock \
-	$tmppwd/slave-db~ $tmppwd/slave-db~.ok $tmppwd/slave-db~.kadm5 $tmppwd/slave-db~.kadm5.lock \
-	$tmppwd/srvtab $tmppwd/cpw_srvtab
+	$tmppwd/slave-db~ $tmppwd/slave-db~.ok $tmppwd/slave-db~.kadm5 $tmppwd/slave-db~.kadm5.lock
+    # Creating a new database means we need a new srvtab.
+    file delete $tmppwd/srvtab $tmppwd/cpw_srvtab
 }
 
 delete_db
@@ -961,6 +966,7 @@ proc setup_kerberos_files { } {
     if ![file exists $tmppwd/acl] {
 	set aclfile [open $tmppwd/acl w]
 	puts $aclfile "krbtest/admin@$REALMNAME *"
+	puts $aclfile "kiprop/$hostname@$REALMNAME p"
 	close $aclfile
     }
 
@@ -993,7 +999,7 @@ proc setup_kerberos_files { } {
 
 proc reset_kerberos_files { } {
     global tmppwd
-    file delete $tmppwd/kdc.conf $tmppwd/krb5.client.conf \
+    file delete $tmppwd/kdc.conf $tmppwd/slave.conf $tmppwd/krb5.client.conf \
 	$tmppwd/krb5.server.conf $tmppwd/krb5.kdc.conf
     setup_kerberos_files
 }
@@ -1141,18 +1147,30 @@ proc setup_kerberos_env { {type client} } {
     # Get the run time environment variables... (including LD_LIBRARY_PATH)
     setup_runtime_env
 
-    # Set our kdc config file.
-    set env(KRB5_KDC_PROFILE) $tmppwd/kdc.conf
-    verbose "KRB5_KDC_PROFILE=$env(KRB5_KDC_PROFILE)"
+    # Set our kdc config file, if needed.
+    switch $type {
+	client	-
+	server	{ catch {unset env(KRB5_KDC_PROFILE)} }
+	kdc	{ set env(KRB5_KDC_PROFILE) $tmppwd/kdc.conf }
+	slave	{ set env(KRB5_KDC_PROFILE) $tmppwd/slave.conf }
+	default	{ error "unknown config file type $type" }
+    }
+    if [info exists env(KRB5_KDC_PROFILE)] {
+	verbose "KRB5_KDC_PROFILE=$env(KRB5_KDC_PROFILE)"
+    }
 
     # Create an environment setup script.  (For convenience)
-    if ![file exists $tmppwd/env.sh] {
-	set envfile [open $tmppwd/env.sh w]
+    if ![file exists $tmppwd/$type-env.sh] {
+	set envfile [open $tmppwd/$type-env.sh w]
 	puts $envfile "KRB5_CONFIG=$env(KRB5_CONFIG)"
 	puts $envfile "KRB5CCNAME=$env(KRB5CCNAME)"
 	puts $envfile "KRB5RCACHEDIR=$env(KRB5RCACHEDIR)"
 	puts $envfile "KERBEROS_SERVER=$env(KERBEROS_SERVER)"
-	puts $envfile "KRB5_KDC_PROFILE=$env(KRB5_KDC_PROFILE)"
+	if [info exists env(KRB5_KDC_PROFILE)] {
+	    puts $envfile "KRB5_KDC_PROFILE=$env(KRB5_KDC_PROFILE)"
+	} else {
+	    puts $envfile "unset KRB5_KDC_PROFILE"
+	}
 	puts $envfile "export KRB5_CONFIG KRB5CCNAME KRB5RCACHEDIR"
 	puts $envfile "export KERBEROS_SERVER KRB5_KDC_PROFILE"
 	foreach i $krb5_init_vars {
@@ -1162,13 +1180,17 @@ proc setup_kerberos_env { {type client} } {
 	}
 	close $envfile
     }
-    if ![file exists $tmppwd/env.csh] {
-	set envfile [open $tmppwd/env.csh w]
+    if ![file exists $tmppwd/$type-env.csh] {
+	set envfile [open $tmppwd/$type-env.csh w]
 	puts $envfile "setenv KRB5_CONFIG $env(KRB5_CONFIG)"
 	puts $envfile "setenv KRB5CCNAME $env(KRB5CCNAME)"
 	puts $envfile "setenv KRB5RCACHEDIR $env(KRB5RCACHEDIR)"
 	puts $envfile "setenv KERBEROS_SERVER $env(KERBEROS_SERVER)"
-	puts $envfile "setenv KRB5_KDC_PROFILE $env(KRB5_KDC_PROFILE)"
+	if [info exists env(KRB5_KDC_PROFILE)] {
+	    puts $envfile "setenv KRB5_KDC_PROFILE $env(KRB5_KDC_PROFILE)"
+	} else {
+	    puts $envfile "unsetenv KRB5_KDC_PROFILE"
+	}
 	foreach i $krb5_init_vars {
 		regexp "^(\[^=\]*)=(.*)" $i foo evar evalue
 		puts $envfile "setenv $evar $env($evar)"
@@ -1219,16 +1241,11 @@ proc restore_kerberos_env { } {
 # pass at relevant points.  Returns 1 on success, 0 on failure.
 
 proc setup_kerberos_db { standalone } {
-    global REALMNAME
-    global KDB5_UTIL
-    global KADMIN_LOCAL
-    global KEY
-    global tmppwd
+    global REALMNAME KDB5_UTIL KADMIN_LOCAL KEY
+    global tmppwd hostname
     global spawn_id
-    global des3_krbtgt
-    global tgt_support_desmd5
-    global multipass_name
-    global last_passname_db
+    global des3_krbtgt tgt_support_desmd5
+    global multipass_name last_passname_db
 
     set failall 0
 
@@ -1237,12 +1254,8 @@ proc setup_kerberos_db { standalone } {
 	return 1
     }
 
-#    catch "file delete [glob -nocomplain $tmppwd/db* $tmppwd/adb*]"
     delete_db
 
-    # Creating a new database means we need a new srvtab.
-    file delete $tmppwd/srvtab
-
     envstack_push
     if { ![setup_kerberos_files] || ![setup_kerberos_env kdc] } {
 	set failall 1
@@ -1339,8 +1352,6 @@ proc setup_kerberos_db { standalone } {
     }
 
     # Add an admin user.
-#send_user "will run: $KADMIN_LOCAL -r $REALMNAME\n"
-#exec xterm
     set test "kadmin.local ank krbtest/admin"
     set body {
 	if $failall {
@@ -1378,7 +1389,52 @@ proc setup_kerberos_db { standalone } {
 	if $standalone {
 	    fail $test
 	} else {
-#	    file delete $tmppwd/db.ok $tmppwd/adb.db
+	    delete_db
+	}
+    } else {
+	if $standalone {
+	    pass $test
+	}
+    }
+
+    # Add an incremental-propagation service.
+    set test "kadmin.local ank kiprop/$hostname"
+    set body {
+	if $failall {
+	    break
+	}
+	spawn $KADMIN_LOCAL -r $REALMNAME
+	verbose "starting $test"
+	expect_after $def_exp_after
+
+	expect "kadmin.local: "
+	send "ank kiprop/$hostname@$REALMNAME\r"
+	# It echos...
+	expect "ank kiprop/$hostname@$REALMNAME\r"
+	expect "Enter password for principal \"kiprop/$hostname@$REALMNAME\":"
+	send "kiproppass$KEY\r"
+	expect "Re-enter password for principal \"kiprop/$hostname@$REALMNAME\":"
+	send "kiproppass$KEY\r"
+	expect {
+	    "Principal \"kiprop/$hostname@$REALMNAME\" created" { }
+	    "Principal or policy already exists while creating*" { }
+	}
+	expect "kadmin.local: "
+	send "quit\r"
+	expect eof
+	catch expect_after
+	if ![check_exit_status kadmin_local] {
+	    break
+	}
+    }
+    set ret [catch $body]
+    catch "expect eof"
+    catch expect_after
+    if $ret {
+	set failall 1
+	if $standalone {
+	    fail $test
+	} else {
 	    delete_db
 	}
     } else {
@@ -1421,7 +1477,6 @@ proc setup_kerberos_db { standalone } {
 	    if $standalone {
 		fail $test
 	    } else {
-#		file delete $tmppwd/db.ok $tmppwd/adb.db
 		delete_db
 	    }
 	} else {
@@ -1464,7 +1519,6 @@ proc setup_kerberos_db { standalone } {
 	    if $standalone {
 		fail $test
 	    } else {
-#		file delete $tmppwd/db.ok $tmppwd/adb.db
 		delete_db
 	    }
 	} else {
@@ -1482,6 +1536,122 @@ proc setup_kerberos_db { standalone } {
     return 1
 }
 
+# setup_slave_db
+# Initialize the slave Kerberos database.  Returns 1 on success, 0 on
+# failure.
+
+proc setup_slave_db { } {
+    global REALMNAME
+    global KDB5_UTIL
+    global KADMIN_LOCAL
+    global KEY
+    global tmppwd
+    global spawn_id
+
+    set failall 0
+
+    envstack_push
+    if { ![setup_kerberos_files] || ![setup_kerberos_env slave] } {
+	set failall 1
+    }
+
+    # Set up a common expect_after for use in multiple places.
+    set def_exp_after {
+	timeout {
+	    set test "$test (timeout)"
+	    break
+	}
+	eof {
+	    set test "$test (eof)"
+	    break
+	}
+    }
+
+    set test "slave kdb5_util create "
+    set body {
+	if $failall {
+	    break
+	}
+	#exec xterm
+	verbose "starting $test"
+	spawn $KDB5_UTIL -r $REALMNAME create
+	expect_after $def_exp_after
+
+	expect "Enter KDC database master key:"
+
+	set test "slave kdb5_util create (verify)"
+	send "masterkey$KEY\r"
+	expect "Re-enter KDC database master key to verify:"
+
+	set test "slave kdb5_util create"
+	send "masterkey$KEY\r"
+	expect {
+	    -re "\[Cc\]ouldn't" {
+		expect eof
+		break
+	    }
+	    "Cannot find/read stored" exp_continue
+	    "Warning: proceeding without master key" exp_continue
+	    eof { }
+	}
+	catch expect_after
+	if ![check_exit_status kdb5_util] {
+	    break
+	}
+    }
+    set ret [catch $body]
+    catch expect_after
+    if $ret {
+	set failall 1
+    }
+
+    # Stash the master key in a file.
+    set test "slave kdb5_util stash"
+    set body {
+	if $failall {
+	    break
+	}
+	spawn $KDB5_UTIL  -r $REALMNAME stash
+	verbose "starting $test"
+	expect_after $def_exp_after
+	expect "Enter KDC database master key:"
+	send "masterkey$KEY\r"
+	expect eof
+	catch expect_after
+	if ![check_exit_status kdb5_util] {
+	    break
+	}
+    }
+    set ret [catch $body]
+    catch "expect eof"
+    catch expect_after
+    if $ret {
+	set failall 1
+	delete_db
+    }
+
+    if !$failall {
+	# create the admin database lock file
+	catch "exec touch $tmppwd/slave-adb.lock"
+    }
+
+    return [expr !$failall]
+}
+
+proc start_kpropd {} {
+    global kpropd_pid kpropd_spawn_id KPROPD T_INETD KDB5_UTIL portbase tmppwd
+    global spawn_id
+
+    envstack_push
+    setup_kerberos_env slave
+    spawn $KPROPD -S -d -P [expr 10 + $portbase] -s $tmppwd/srvtab -f $tmppwd/incoming-slave-datatrans -p $KDB5_UTIL -a $tmppwd/kpropd-acl
+    set kpropd_pid [exp_pid]
+    set kpropd_spawn_id $spawn_id
+#    send_user [list $KPROPD -S -d -P [expr 10 + $portbase] -s $tmppwd/srvtab -f $tmppwd/incoming-slave-datatrans -p $KDB5_UTIL -a $tmppwd/kpropd-acl]\n
+#    spawn_shell
+    envstack_pop
+}
+
 proc start_tail { fname spawnid_var pid_var which standalone } {
     upvar $spawnid_var spawnid
     upvar $pid_var pid
@@ -1980,8 +2150,8 @@ proc setup_srvtab { standalone {id host} } {
 	}
     }
     expect "kadmin.local:  "
-    send "xst -k $hostname-new-srvtab $id/$hostname\r"
-    expect "xst -k $hostname-new-srvtab $id/$hostname\r\n"
+    send "xst -k $hostname-new-srvtab $id/$hostname kiprop/$hostname\r"
+    expect "xst -k $hostname-new-srvtab $id/$hostname kiprop/$hostname\r\n"
     expect {
 	-re ".*Entry for principal $id/$hostname.* added to keytab WRFILE:$hostname-new-srvtab." { }
 	-re "\r\nkadmin.local:  " {
@@ -2804,7 +2974,7 @@ proc krb_exit { } {
 # helpful sometimes for debugging the test suite
 proc export_debug_envvars { } {
     global env
-    foreach i {KDB5_UTIL KRB5KDC KADMIND KADMIN KADMIN_LOCAL KINIT KTUTIL KLIST RLOGIN RLOGIND FTP FTPD KPASSWD REALMNAME GSSCLIENT} {
+    foreach i {KDB5_UTIL KRB5KDC KADMIND KADMIN KADMIN_LOCAL KINIT KTUTIL KLIST RLOGIN RLOGIND FTP FTPD KPASSWD REALMNAME GSSCLIENT KPROPLOG} {
 	global $i
 	if [info exists $i] { set env($i) [set $i] }
     }
diff --git a/src/tests/dejagnu/krb-standalone/iprop.exp b/src/tests/dejagnu/krb-standalone/iprop.exp
index 9f3940800..91c8b7da4 100644
--- a/src/tests/dejagnu/krb-standalone/iprop.exp
+++ b/src/tests/dejagnu/krb-standalone/iprop.exp
@@ -1,25 +1,44 @@
 # Password-changing Kerberos test.
 # This is a DejaGnu test script.
 
+proc setup_slave {} {
+    global tmppwd hostname REALMNAME KDB5_UTIL
+    file delete $tmppwd/slave-stash $tmppwd/slave-acl
+    file copy -force $tmppwd/acl $tmppwd/slave-acl
+    if ![file exists $tmppwd/kpropdacl] {
+	set aclfile [open $tmppwd/kpropd-acl w]
+	puts $aclfile "host/$hostname@$REALMNAME"
+	close $aclfile
+    }
+    setup_slave_db
+    # copy database - must be used after master db set up
+    envstack_push
+    setup_kerberos_env kdc
+    set dumpfile $tmppwd/dump-file
+    file delete $dumpfile $dumpfile.dump_ok
+    if [catch {exec $KDB5_UTIL dump -i $dumpfile} msg] {
+	error "master dump failed: $msg"
+    }
+    setup_kerberos_env slave
+    foreach suffix { .kadm5.lock .ok } {
+	file copy -force $tmppwd/kdc-db$suffix $tmppwd/slave-db$suffix
+    }
+    if [catch {exec $KDB5_UTIL load -i $dumpfile} msg] {
+	send_user "slave load failed: $msg"
+	spawn_shell
+	error "slave load failed: $msg"
+    }
+}
+
 # We are about to start up a couple of daemon processes.  We do all
 # the rest of the tests inside a proc, so that we can easily kill the
 # processes when the procedure ends.
 
 proc doit { } {
-    global REALMNAME
-    global KLIST
-    global KDESTROY
-    global KEY
-    global KADMIN_LOCAL
-    global KTUTIL
-    global hostname
-    global tmppwd
-    global spawn_id
-    global supported_enctypes
-    global KRBIV
-    global portbase
-    global mode
-    global KPROPLOG
+    global REALMNAME KEY
+    global KLIST KDESTROY KADMIN_LOCAL KTUTIL KPROPLOG KPROPD KDB5_UTIL
+    global hostname tmppwd spawn_id kpropd_spawn_id kpropd_pid
+    global supported_enctypes KRBIV portbase mode
     global ulog des3_krbtgt
 
     # Delete any db, ulog files
@@ -45,12 +64,15 @@ proc doit { } {
 	fail "create update log"
     }
 
+    setup_slave
+
     # Use kadmin to add a key.
     if ![add_kerberos_key wakawaka 0] {
 	return
     }
 
     # Run kproplog, look at output.
+    setup_kerberos_env kdc
     spawn $KPROPLOG
     expect_after {
 	timeout {
@@ -67,7 +89,7 @@ proc doit { } {
 	expect -re "Update log dump"
 	expect -re "First serial \# : 1"
 	if $des3_krbtgt {
-	    expect -re "Last serial \# : 3"
+	    expect -re "Last serial \# : 4"
 	    expect -re "Update Entry"
 	    expect -re "Update serial \# : 1"
 	    expect -re "Attributes changed : 15"
@@ -76,13 +98,19 @@ proc doit { } {
 	    expect -re "Attributes changed : 6"
 	    expect -re "Update Entry"
 	    expect -re "Update serial \# : 3"
+	    expect -re "Attributes changed : 15"
+	    expect -re "Update Entry"
+	    expect -re "Update serial \# : 4"
 	} else {
-	    expect -re "Last serial \# : 2"
+	    expect -re "Last serial \# : 3"
 	    expect -re "Update Entry"
 	    expect -re "Update serial \# : 1"
 	    expect -re "Attributes changed : 15"
 	    expect -re "Update Entry"
 	    expect -re "Update serial \# : 2"
+	    expect -re "Attributes changed : 15"
+	    expect -re "Update Entry"
+	    expect -re "Update serial \# : 3"
 	}
 	expect -re "Update operation : Add"
 	expect -re "Update principal : wakawaka@KRBTEST.COM"
@@ -94,17 +122,74 @@ proc doit { } {
 	}
 	expect -re "Attributes changed : 15"
 	expect eof
+	pass "kproplog output"
     } foo
-    pass "kproplog output"
     catch expect_after
     if [check_exit_status kproplog] {
-	pass "kproplog exit status"
-    } else {
-	fail "kproplog exit status"
+	pass "kproplog"
+    }
+    add_random_key host/$hostname 0
+    add_random_key kiprop/$hostname 0
+
+    # Already have kadmind running.
+
+    # Get a keytab file.
+    setup_srvtab 0
+
+    # Sleep 11s for built-in delay.
+    verbose "Delaying to bypass contention-avoidance code in kadmind/iprop"
+    sleep 11
+
+    # Launch slave kpropd.
+    start_kpropd
+#    send_user [list $KPROPD -S -d -P [expr 10 + $portbase] -s $tmppwd/srvtab -f $tmppwd/incoming-slave-datatrans -p $KDB5_UTIL -a $tmppwd/kpropd-acl]\n
+#    spawn_shell
+    expect {
+	-i $kpropd_spawn_id
+	"Update transfer from master was OK" {
+	    exec kill $kpropd_pid
+	    wait -i $kpropd_spawn_id
+	    unset kpropd_spawn_id kpropd_pid
+	}
+	-re ..* { exp_continue }
+	timeout {
+	    catch { exec kill $kpropd_pid }
+	    exp_continue
+	}
+	eof {
+	    wait -i $kpropd_spawn_id
+	    unset kpropd_spawn_id kpropd_pid
+	}
     }
+
+    # Wait briefly?
+    # Check slave db for new principal.
+    setup_kerberos_env slave
+    spawn $KADMIN_LOCAL -r $REALMNAME -q listprincs
+    expect {
+	wakawaka@ {
+	    expect eof
+	}
+	eof {
+	    fail "kprop (updated slave data)"
+	    return
+	}
+	timeout {
+	    fail "kprop (examining new db)"
+	    return
+	}
+    }
+    pass "iprop"
+
+    # What about testing for full propagation?  (Small number of
+    # entries in update log, change one principal's record a lot of
+    # times, then fire up incremental kpropd...)  Do later.
 }
 
 run_once iprop {
+    catch "unset kpropd_pid"
+    catch "unset kpropd_spawn_id"
+
     # Set up the Kerberos files and environment.
     if {![get_hostname] || ![setup_kerberos_files] || ![setup_kerberos_env]} {
 	return
@@ -114,9 +199,19 @@ run_once iprop {
 
     stop_kerberos_daemons
 
+    # if kpropd is running, kill it
+    if [info exists kpropd_pid] {
+	catch {
+	    exec kill $kpropd_pid
+	    expect -i $kpropd_spawn_id eof
+	    wait -i $kpropd_spawn_id
+	    unset kpropd_pid kpropd_spawn_id
+	}
+    }
+
     set ulog 0
     reset_kerberos_files
-    file delete $tmppwd/adb $tmppwd/adb.ok $tmppwd/db.ulog
+    delete_db
 
     if { $status != 0 } {
 	send_error "ERROR: error in iprop.exp\n"
diff --git a/src/tests/dejagnu/krb-standalone/kprop.exp b/src/tests/dejagnu/krb-standalone/kprop.exp
index cb0c16133..ed7ed684f 100644
--- a/src/tests/dejagnu/krb-standalone/kprop.exp
+++ b/src/tests/dejagnu/krb-standalone/kprop.exp
@@ -21,20 +21,6 @@ proc setup_slave {} {
     }
 }
 
-proc start_kpropd {} {
-    global kpropd_pid kpropd_spawn_id KPROPD T_INETD KDB5_UTIL portbase tmppwd
-    global spawn_id
-
-    envstack_push
-    setup_kerberos_env slave
-#    spawn $T_INETD [expr 10 + $portbase] $KPROPD -f $tmppwd/incoming-slave-datatrans -p $KDB5_UTIL
-    spawn $KPROPD -S -d -P [expr 10 + $portbase] -s $tmppwd/srvtab -f $tmppwd/incoming-slave-datatrans -p $KDB5_UTIL -a $tmppwd/kpropd-acl
-#    spawn strace -o /tmp/3 -f $KPROPD -S -d -P [expr 10 + $portbase] -s $tmppwd/srvtab -f $tmppwd/incoming-slave-datatrans -p $KDB5_UTIL -a $tmppwd/kpropd-acl
-    set kpropd_pid [exp_pid]
-    set kpropd_spawn_id $spawn_id
-    envstack_pop
-}
-
 proc scan_kpropd_output {} {
     global kpropd_spawn_id kpropd_pid