From: Tomi Ollila <tomi.ollila@iki.fi>
Date: Wed, 20 May 2015 10:45:08 +0000 (+0300)
Subject: Re: [PATCH] configure: Add sanity checking for environment variables
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=c4437fe060f49ad6808e4e862eb30d9b42141e47;p=notmuch-archives.git

Re: [PATCH] configure: Add sanity checking for environment variables
---

diff --git a/67/222a9e84d16309d60a9e6f70d5f148f04f70db b/67/222a9e84d16309d60a9e6f70d5f148f04f70db
new file mode 100644
index 000000000..48aededb6
--- /dev/null
+++ b/67/222a9e84d16309d60a9e6f70d5f148f04f70db
@@ -0,0 +1,138 @@
+Return-Path: <tomi.ollila@iki.fi>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+ by arlo.cworth.org (Postfix) with ESMTP id 99C6E6DE1A17
+ for <notmuch@notmuchmail.org>; Wed, 20 May 2015 03:45:34 -0700 (PDT)
+X-Virus-Scanned: Debian amavisd-new at cworth.org
+X-Spam-Flag: NO
+X-Spam-Score: 1.03
+X-Spam-Level: *
+X-Spam-Status: No, score=1.03 tagged_above=-999 required=5 tests=[AWL=0.378,
+ SPF_NEUTRAL=0.652] autolearn=disabled
+Received: from arlo.cworth.org ([127.0.0.1])
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
+ with ESMTP id Of1qauYB3QPT for <notmuch@notmuchmail.org>;
+ Wed, 20 May 2015 03:45:32 -0700 (PDT)
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
+ by arlo.cworth.org (Postfix) with ESMTP id C7E5F6DE19F6
+ for <notmuch@notmuchmail.org>; Wed, 20 May 2015 03:45:31 -0700 (PDT)
+Received: from guru.guru-group.fi (localhost [IPv6:::1])
+ by guru.guru-group.fi (Postfix) with ESMTP id 0F49A1000F2;
+ Wed, 20 May 2015 13:45:09 +0300 (EEST)
+From: Tomi Ollila <tomi.ollila@iki.fi>
+To: David Bremner <david@tethera.net>
+Subject: Re: [PATCH] configure: Add sanity checking for environment variables
+In-Reply-To: <1432115106-15806-1-git-send-email-david@tethera.net>
+References: <m2pp5v7hyb.fsf@guru.guru-group.fi>
+ <1432115106-15806-1-git-send-email-david@tethera.net>
+User-Agent: Notmuch/0.19+115~g9a981cb (http://notmuchmail.org) Emacs/24.3.1
+ (x86_64-unknown-linux-gnu)
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
+ $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
+ !)g;OY^,BjTbr)Np:%c_o'jj,Z
+Date: Wed, 20 May 2015 13:45:08 +0300
+Message-ID: <m2a8wz34uj.fsf@guru.guru-group.fi>
+MIME-Version: 1.0
+Content-Type: text/plain
+Cc: notmuch@notmuchmail.org
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.18
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+ <notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Wed, 20 May 2015 10:45:34 -0000
+
+On Wed, May 20 2015, David Bremner <david@tethera.net> wrote:
+
+> Passing in environment variables incompatible with the compiler may
+> cause other parts of the configure script to fail in hard to
+> understand ways, so we abort early.
+> ---
+> Gah, I left out the one line I actually wanted feedback on.
+
+This version looks simplest and most readable to me (personally i don't
+like the variable naming but that is just (*))
+
+Just 's/${CPPFLAGS}  minimal.c/${CPPFLAGS} minimal.c/
+
+Tomi
+
+(*) http://martinfowler.com/bliki/TwoHardThings.html
+
+
+>
+>  configure | 32 ++++++++++++++++++++++++++++++--
+>  1 file changed, 30 insertions(+), 2 deletions(-)
+>
+> diff --git a/configure b/configure
+> index 4af7ba9..9b01025 100755
+> --- a/configure
+> +++ b/configure
+> @@ -47,6 +47,7 @@ CC=${CC:-cc}
+>  CXX=${CXX:-c++}
+>  CFLAGS=${CFLAGS:--g -O2}
+>  CPPFLAGS=${CPPFLAGS:-}
+> +CXXFLAGS_for_sh=${CXXFLAGS:-${CFLAGS}}
+>  CXXFLAGS=${CXXFLAGS:-\$(CFLAGS)}
+>  LDFLAGS=${LDFLAGS:-}
+>  XAPIAN_CONFIG=${XAPIAN_CONFIG:-xapian-config}
+> @@ -269,6 +270,35 @@ dependencies are available:
+>  EOF
+>  
+>  errors=0
+> +printf "int main(void){return 0;}\n" > minimal.c
+> +
+> +printf "Sanity checking C compilation environment... "
+> +if ${CC} ${CFLAGS} ${CPPFLAGS}  minimal.c ${LDFLAGS} -o minimal > /dev/null 2>&1
+> +then
+> +    printf "OK.\n"
+> +else
+> +    printf "Fail.\n"
+> +    errors=$((errors + 1))
+> +fi
+> +
+> +printf "Sanity checking C++ compilation environment... "
+> +if ${CXX} ${CXXFLAGS_for_sh} ${CPPFLAGS} minimal.c ${LDFLAGS} -o minimal > /dev/null 2>&1
+> +then
+> +    printf "OK.\n"
+> +else
+> +    printf "Fail.\n"
+> +    errors=$((errors + 1))
+> +fi
+> +
+> +if [ $errors -gt 0 ]; then
+> +    cat <<EOF
+> +*** Error: Initial sanity checking of environment failed.  Please try
+> +running configure in a clean environment, and if the problem persists,
+> +report a bug.
+> +EOF
+> +    rm -f minimal minimal.c
+> +    exit 1
+> +fi
+>  
+>  if pkg-config --version > /dev/null 2>&1; then
+>      have_pkg_config=1
+> @@ -690,8 +720,6 @@ else
+>  fi
+>  rm -f compat/check_asctime
+>  
+> -printf "int main(void){return 0;}\n" > minimal.c
+> -
+>  printf "Checking for rpath support... "
+>  if ${CC} -Wl,--enable-new-dtags -Wl,-rpath,/tmp/ -o minimal minimal.c >/dev/null 2>&1
+>  then
+> -- 
+> 2.1.4
+>
+> _______________________________________________
+> notmuch mailing list
+> notmuch@notmuchmail.org
+> http://notmuchmail.org/mailman/listinfo/notmuch