From: Mark Walters Date: Sun, 21 Jul 2013 08:36:38 +0000 (+0100) Subject: Re: [PATCH 00/11] contrib: pick: keybindings X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=c3dd3090e73564134a96a18bbf554f4234ef26c7;p=notmuch-archives.git Re: [PATCH 00/11] contrib: pick: keybindings --- diff --git a/f7/6931e2c8d1459b9f60afae6e920c024b4c3371 b/f7/6931e2c8d1459b9f60afae6e920c024b4c3371 new file mode 100644 index 000000000..7b1ecc601 --- /dev/null +++ b/f7/6931e2c8d1459b9f60afae6e920c024b4c3371 @@ -0,0 +1,178 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 6CE56431FC2 + for ; Sun, 21 Jul 2013 01:36:48 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 1.401 +X-Spam-Level: * +X-Spam-Status: No, score=1.401 tagged_above=-999 required=5 + tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, + FREEMAIL_REPLY=2.499, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id Yy6I6E2970gC for ; + Sun, 21 Jul 2013 01:36:41 -0700 (PDT) +Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 0CBB5431FB6 + for ; Sun, 21 Jul 2013 01:36:41 -0700 (PDT) +Received: from smtp.qmul.ac.uk ([138.37.6.40]) + by mail2.qmul.ac.uk with esmtp (Exim 4.71) + (envelope-from ) + id 1V0p8B-0006BQ-6j; Sun, 21 Jul 2013 09:36:39 +0100 +Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost) + by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71) + (envelope-from ) + id 1V0p8A-0002hH-Sg; Sun, 21 Jul 2013 09:36:39 +0100 +From: Mark Walters +To: Tomi Ollila , notmuch@notmuchmail.org +Subject: Re: [PATCH 00/11] contrib: pick: keybindings +In-Reply-To: +References: <1373047878-20822-1-git-send-email-markwalters1009@gmail.com> + +User-Agent: Notmuch/0.15.2+192~g8222af3 (http://notmuchmail.org) Emacs/23.4.1 + (i486-pc-linux-gnu) +Date: Sun, 21 Jul 2013 09:36:38 +0100 +Message-ID: <87ehas8g2x.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Sender-Host-Address: 93.97.24.31 +X-QM-SPAM-Info: Sender has good ham record. :) +X-QM-Body-MD5: 6ad08e95498472513f982c37411e7c70 (of first 20000 bytes) +X-SpamAssassin-Score: 0.6 +X-SpamAssassin-SpamBar: / +X-SpamAssassin-Report: The QM spam filters have analysed this message to + determine if it is + spam. We require at least 5.0 points to mark a message as spam. + This message scored 0.6 points. Summary of the scoring: + * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail + provider * (markwalters1009[at]gmail.com) + * 1.0 FREEMAIL_REPLY From and body contain different freemails + * -0.4 AWL AWL: From: address is in the auto white-list +X-QM-Scan-Virus: ClamAV says the message is clean +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 21 Jul 2013 08:36:48 -0000 + +Tomi Ollila writes: + +> On Fri, Jul 05 2013, Mark Walters wrote: +> +>> This series adds lots of keybindings and funtionality to pick: in +>> particular it adds the stash keymap, the ability to tab between and +>> activate buttons in the message pane, and it reduces a lot of code +>> duplication between pick and show. +>> +>> It is a large series: but most of it is a lot of small changes. These +>> small changes are mostly logically independent but as they add +>> keybindings their contexts all clash. I have made most of the +>> keybindings as single separate patches to make discussion of them +>> individually easier. +>> +>> The key patches for review/discussion (apart from bike-shedding on +>> key-bindings!) are patches 1, 5 and 8. + +Hi + +Thanks for the review. + +> Now that you "asked", I'd ask what was used as a reason to decide "/" +> as keybinding for notmuch-pick-button-activate -- something common +> or as a convenience. In US/UK keyboard "/" is left to Right Shift, +> but for example in my keyboard it is Shift-7... + +That is just my not knowing (and I regret to say even thinking of) other +keyboard layouts. I agree that makes it a silly key. What about 'e' +(Enter as the mnemonic)? +> +>> Patch 1 is the most "controversial": it over-rides +>> notmuch-show-get-prop so that whether it uses +>> notmuch-show-get-message-properties or +>> notmuch-pick-get-message-properties depends on the major-mode (ie +>> whether it is called from pick or show). +> +> At the moment the code comments could have something like XXX to +> emphasize the situation. IMHO it is ok to have this in contrib +> code -- when this is going to be "official" part of emacs MUA +> then this code needs to be ... well, at least moved to other place :D + +Yes that is a good point. I will add this in the next version. + +Best wishes + +Mark + + +> Apart from these code LGTM. +> +> Tomi +> +> +>> This means that functions from show which just use message properties +>> (most often just the message id) "just work" when called from pick. In +>> particular it gives us access to lots of functions without having to +>> duplicate the code. +>> +>> In the longer term it would be better to have some show/pick common +>> file and migrate the common functions there. +>> +>> Patch 5 and 8 add in functions for creating fucntions ready to be used +>> in keybindings. The one in patch 5 takes a show fucntion and creates a +>> function which switches from pick to the message pane, applies the +>> function and then switches back to pick. The one in patch 8 takes a +>> function and creates a function which closes the message pane and the +>> calls this function. +>> +>> Both of these make the keybinding section clearer. They also have the +>> advantage that the user can use them easily to create their own +>> keybindings which do this. +>> +>> This completes all the keybindings I use and I think means that pick +>> doesn't have any glaring omissions. +>> +>> Finally, this will clash with the thread archive patches +>> id:1371195472-441-1-git-send-email-markwalters1009@gmail.com +>> +>> Best wishes +>> +>> Mark +>> +>> Mark Walters (11): +>> contrib: pick: override notmuch-show-get-prop +>> contrib: pick: Link in notmuch-show-pipe-message +>> contrib: pick: Link in attachment functions straight from +>> notmuch-show +>> contrib: pick: Link in stash map straight from notmuch-show +>> contrib: pick: add in to-message-window function +>> contrib: pick: add button press helper +>> contrib: pick: pass tab through to the message pane +>> contrib: pick: close window function +>> contrib: pick: make help close the message pane first +>> contrib: pick: add in binding to view raw message +>> contrib: pick: use close-message-pane for reply etc +>> +>> contrib/notmuch-pick/notmuch-pick.el | 139 +++++++++++++++++----------------- +>> 1 files changed, 70 insertions(+), 69 deletions(-) +>> +>> -- +>> 1.7.9.1 +>> +>> _______________________________________________ +>> notmuch mailing list +>> notmuch@notmuchmail.org +>> http://notmuchmail.org/mailman/listinfo/notmuch