From: David Bremner Date: Mon, 9 Dec 2013 01:17:41 +0000 (+0800) Subject: Re: [PATCH 3/4] test: sanitize dates in emacs, raw, and text output X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=c3b0440bc4cb55ac9adca5df755363a574b97522;p=notmuch-archives.git Re: [PATCH 3/4] test: sanitize dates in emacs, raw, and text output --- diff --git a/88/f5923c6a1f171dfc2e7c3bf2f8d974a07dd812 b/88/f5923c6a1f171dfc2e7c3bf2f8d974a07dd812 new file mode 100644 index 000000000..417f2456e --- /dev/null +++ b/88/f5923c6a1f171dfc2e7c3bf2f8d974a07dd812 @@ -0,0 +1,75 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 20968431FCB + for ; Sun, 8 Dec 2013 17:18:15 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id b6EoFEi+lvTw for ; + Sun, 8 Dec 2013 17:17:52 -0800 (PST) +Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155]) + (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 23BA2431FC3 + for ; Sun, 8 Dec 2013 17:17:52 -0800 (PST) +Received: from remotemail by yantan.tethera.net with local (Exim 4.80) + (envelope-from ) + id 1VppTo-0000a2-Qw; Sun, 08 Dec 2013 21:17:48 -0400 +Received: (nullmailer pid 22711 invoked by uid 1000); Mon, 09 Dec 2013 + 01:17:41 -0000 +From: David Bremner +To: Austin Clements +Subject: Re: [PATCH 3/4] test: sanitize dates in emacs, raw, and text output +In-Reply-To: <20131209002519.GH8854@mit.edu> +References: <1386517946-22054-1-git-send-email-david@tethera.net> + <1386517946-22054-4-git-send-email-david@tethera.net> + <20131209002519.GH8854@mit.edu> +User-Agent: Notmuch/0.17~rc3 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-pc-linux-gnu) +Date: Mon, 09 Dec 2013 09:17:41 +0800 +Message-ID: <87ob4qlt56.fsf@maritornes.cs.unb.ca> +MIME-Version: 1.0 +Content-Type: text/plain +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 09 Dec 2013 01:18:15 -0000 + +Austin Clements writes: + +> This may be orthogonal to this series, but I don't get why we have +> both notmuch_show_sanitize and notmuch_show_sanitize_all (especially +> when the "all" version is not obviously a superset of the non-"all" +> version!) Do you have a sense for whether these two functions could +> be easily merged? + +Yeah, I don't really understand the reason for these two functions +either. I also discovered (and deleted) another duplicate file name +sanitization function elsewhere in the series, so it wouldn't surprise +me if it's just collective sloppiness. + +> +> Rather than (nearly) duplicating the regexp, does it work to pipe this +> through notmuch_date_sanitize? Or do the minor differences matter? +> + +I'll try this out. + +d