From: W. Trevor King Date: Mon, 10 Feb 2014 18:40:39 +0000 (+1600) Subject: [PATCH v2 18/20] nmbug-status: Color threads in HTML output X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=c2b2a22c976131beefabb98224704bb849fa88b4;p=notmuch-archives.git [PATCH v2 18/20] nmbug-status: Color threads in HTML output --- diff --git a/93/d9b222b5c8e9acb64d5887fdad1949d850d925 b/93/d9b222b5c8e9acb64d5887fdad1949d850d925 new file mode 100644 index 000000000..852b7a1e4 --- /dev/null +++ b/93/d9b222b5c8e9acb64d5887fdad1949d850d925 @@ -0,0 +1,188 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 198A1431FBD + for ; Mon, 10 Feb 2014 10:45:00 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Amavis-Alert: BAD HEADER SECTION, Duplicate header field: "References" +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 + tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id m3tWjQ0i8FV6 for ; + Mon, 10 Feb 2014 10:44:52 -0800 (PST) +Received: from qmta02.westchester.pa.mail.comcast.net + (qmta02.westchester.pa.mail.comcast.net [76.96.62.24]) + by olra.theworths.org (Postfix) with ESMTP id 58D5B429E3C + for ; Mon, 10 Feb 2014 10:44:01 -0800 (PST) +Received: from omta23.westchester.pa.mail.comcast.net ([76.96.62.74]) + by qmta02.westchester.pa.mail.comcast.net with comcast + id QeCb1n0041c6gX851ik15n; Mon, 10 Feb 2014 18:44:01 +0000 +Received: from odin.tremily.us ([24.18.63.50]) + by omta23.westchester.pa.mail.comcast.net with comcast + id Qii01n01j152l3L3jii1BP; Mon, 10 Feb 2014 18:42:01 +0000 +Received: from mjolnir.tremily.us (unknown [192.168.0.140]) + by odin.tremily.us (Postfix) with ESMTPS id 7669C10167C5; + Mon, 10 Feb 2014 10:42:00 -0800 (PST) +Received: (nullmailer pid 1283 invoked by uid 1000); + Mon, 10 Feb 2014 18:40:46 -0000 +From: "W. Trevor King" +To: notmuch@notmuchmail.org +Subject: [PATCH v2 18/20] nmbug-status: Color threads in HTML output +Date: Mon, 10 Feb 2014 10:40:39 -0800 +Message-Id: + +X-Mailer: git-send-email 1.8.5.2.8.g0f6c0d1 +In-Reply-To: +References: +In-Reply-To: +References: +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcast.net; + s=q20121106; t=1392057841; + bh=/eNlbKSlvqbpPCKNbPB0mi5Sz4mrjC10jKq+iyjztCs=; + h=Received:Received:Received:Received:From:To:Subject:Date: + Message-Id; + b=CQ+xtU2V4b3fHkSeF8cBnvwaPJ+5yu9qbZh0Enq2x9AGj1O75weqb7OmBjFgNi60T + mhe7E/x94c94q46oKyWniYSuL9BQsZ/6Nrb141kqYo93YrrSw6ONz/Cmpk245Ip2Fx + qaV1/yhUQ8V00u2GshE3OT1ZYO0dTOWqEU+hRdJFFT6jtQHDNIkvMbmLmCvN9Oh97W + BMox4bV4Hrkily3tQYIoAREdKqQBnAi0ETtuypU28ysZkiCF/gfp38L8g6qgMxr7ez + D1Un23umFVWAK/9004vC2UQmhp8nQRyGAtiVc4iIUEN3LshStg4PTy/iHyafvSMi/Z + ls8ruywJ6SoFQ== +Cc: Tomi Ollila +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 10 Feb 2014 18:45:00 -0000 + +Add tbody sections so we don't have to color every row. Multiple +tbody sections are allowed [1]. Use CSS 3's nth-child to handle +even/odd coloring (skipping the spacer rows) [2], which is supported +on the major browsers [3]. + +border-spacing is from CCS 2.1 [4,5]. I'm using it to avoid +whitespace between td cells. + +border-radius is from CCS 3 [6,7]. I'm using it to make the colored +sections a bit less harsh. I tried adding rounded borders to the +tbody itself doesn't work, but I couldn't get that to work without +setting the tbody's display to 'block'. That rounded the corners, but +collapsed the cell spacing (e.g. columns were no longer aligned). +This commit's by-corner-td approach is not particularly elegant, but +it works. The td padding entries just ensure that the cell body is +suitably far from the edges that it doesn't fall outside of the +rounded corners. + +The doubled-braces are escapes from Python's str.format. + +[1]: http://www.w3.org/TR/html5/tabular-data.html#the-table-element +[2]: http://www.w3.org/TR/css3-selectors/#nth-child-pseudo +[3]: https://developer.mozilla.org/en-US/docs/Web/CSS/:nth-child#Browser_compatibility +[4]: http://www.w3.org/TR/CSS2/tables.html#propdef-border-spacing +[5]: https://developer.mozilla.org/en-US/docs/Web/CSS/border-spacing#Browser_compatibility +[6]: http://www.w3.org/TR/css3-background/#the-border-radius +[7]: https://developer.mozilla.org/en-US/docs/Web/CSS/border-radius#Browser_compatibility +--- + devel/nmbug/nmbug-status | 55 +++++++++++++++++++++++++++++++++++++----------- + 1 file changed, 43 insertions(+), 12 deletions(-) + +diff --git a/devel/nmbug/nmbug-status b/devel/nmbug/nmbug-status +index c45b763..1f0873a 100755 +--- a/devel/nmbug/nmbug-status ++++ b/devel/nmbug/nmbug-status +@@ -204,19 +204,22 @@ class HtmlPage (Page): + return + stream.write('\n') + for thread in threads: ++ stream.write(' \n') + for message_display_data in thread: + stream.write(( +- '\n' +- ' \n' +- ' \n' +- '\n' +- '\n' +- ' \n' +- ' \n' +- '\n' ++ ' \n' ++ ' \n' ++ ' \n' ++ ' \n' ++ ' \n' ++ ' \n' ++ ' \n' ++ ' \n' + ).format(**message_display_data)) ++ stream.write(' \n') + if thread != threads[-1]: +- stream.write('\n') ++ stream.write( ++ ' \n') + stream.write('
{date}{message-id-term}
{from}{subject}
{date}{message-id-term}
{from}{subject}


\n') + + def _message_display_data(self, *args, **kwargs): +@@ -242,8 +245,35 @@ _PAGES['html'] = HtmlPage( + header=''' + + +- +-Notmuch Patches ++ ++ Notmuch Patches ++ + + +

Notmuch Patches

+@@ -253,7 +283,8 @@ For more infomation see nmbug +

+

Views

+ '''.format(date=datetime.datetime.utcnow().date(), +- encoding=_ENCODING), ++ encoding=_ENCODING, ++ border_radius='0.5em'), + footer='\n\n', + ) + +-- +1.8.5.2.8.g0f6c0d1 +