From: Tomi Ollila <tomi.ollila@iki.fi>
Date: Sat, 28 Nov 2015 15:02:50 +0000 (+0200)
Subject: Re: [PATCH] configure: Use $prefix for emacs, even when pkg-config is available.
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=c29213c064af35d19ea57f7b9618367613587df9;p=notmuch-archives.git

Re: [PATCH] configure: Use $prefix for emacs, even when pkg-config is available.
---

diff --git a/0c/ea6ae2821ab8e27c054f41c43c6203f8d63d2d b/0c/ea6ae2821ab8e27c054f41c43c6203f8d63d2d
new file mode 100644
index 000000000..d23c70b33
--- /dev/null
+++ b/0c/ea6ae2821ab8e27c054f41c43c6203f8d63d2d
@@ -0,0 +1,92 @@
+Return-Path: <tomi.ollila@iki.fi>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+ by arlo.cworth.org (Postfix) with ESMTP id A1DAC6DE1216
+ for <notmuch@notmuchmail.org>; Sat, 28 Nov 2015 07:02:45 -0800 (PST)
+X-Virus-Scanned: Debian amavisd-new at cworth.org
+X-Spam-Flag: NO
+X-Spam-Score: 0.714
+X-Spam-Level: 
+X-Spam-Status: No, score=0.714 tagged_above=-999 required=5 tests=[AWL=0.062, 
+ SPF_NEUTRAL=0.652] autolearn=disabled
+Received: from arlo.cworth.org ([127.0.0.1])
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
+ with ESMTP id Alc753xHfAnx for <notmuch@notmuchmail.org>;
+ Sat, 28 Nov 2015 07:02:43 -0800 (PST)
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
+ by arlo.cworth.org (Postfix) with ESMTP id 8157B6DE0ACD
+ for <notmuch@notmuchmail.org>; Sat, 28 Nov 2015 07:02:43 -0800 (PST)
+Received: from guru.guru-group.fi (localhost [IPv6:::1])
+ by guru.guru-group.fi (Postfix) with ESMTP id BAEBB1000CA;
+ Sat, 28 Nov 2015 17:02:50 +0200 (EET)
+From: Tomi Ollila <tomi.ollila@iki.fi>
+To: David Bremner <david@tethera.net>,
+ Andrew Burgess <andrew.burgess@embecosm.com>, notmuch@notmuchmail.org
+Subject: Re: [PATCH] configure: Use $prefix for emacs,
+ even when pkg-config is available.
+In-Reply-To: <87egfa2rye.fsf@zancas.localnet>
+References: <1448472725-11684-1-git-send-email-andrew.burgess@embecosm.com>
+ <87egfa2rye.fsf@zancas.localnet>
+User-Agent: Notmuch/0.21+32~g73439f8 (http://notmuchmail.org) Emacs/24.3.1
+ (x86_64-unknown-linux-gnu)
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
+ $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
+ !)g;OY^,BjTbr)Np:%c_o'jj,Z
+Date: Sat, 28 Nov 2015 17:02:50 +0200
+Message-ID: <m2k2p2rwth.fsf@guru.guru-group.fi>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.20
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+ <notmuch.notmuchmail.org>
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Sat, 28 Nov 2015 15:02:45 -0000
+
+On Sat, Nov 28 2015, David Bremner <david@tethera.net> wrote:
+
+> Andrew Burgess <andrew.burgess@embecosm.com> writes:
+>
+>> Assumming that you have pkg-config installed, emacs installed, and the
+>> command 'pkg-config emacs --variable sitepkglispdir' returns a
+>> directory that only root can write to, then the make install above
+>> should fail.
+>
+> I agree that the current behaviour is probably wrong. I'm not sure if we
+> need more control here as Tomi suggests. My biggest concern is that
+> emacs.pc seems to be rather specific to fedora / redhat packaging, which
+> makes it hard for me to evaluate both the current handling and this
+> patch. Do any any Fedora users have opinions on just dropping the
+> handling of "pkg-config emacs"? Or am I missing other places that
+> pkg-config file is available?
+
+Now that I looked this a bit more I tend to agree with David:
+
+default PREFIX is /usr/local
+
+and $ pkg-config emacs --variable sitepkglispdir
+
+outputs
+
+/usr/share/emacs/site-lisp
+
+(in default case we should mangle /local/ there in between ... :/ ).
+
+package managers can add 
+
+./configure ---emacslispdir=`pkg-config emacs --variable sitepkglispdir`
+
+in their build scripts.
+
+>
+> d
+
+Tomi