From: David Bremner <david@tethera.net>
Date: Sat, 23 Aug 2014 00:08:39 +0000 (+1700)
Subject: Re: [PATCH] completion: fail silently if _init_completion is not found
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=c16e6535ed62bd52876c7f576a0eee366d6ac696;p=notmuch-archives.git

Re: [PATCH] completion: fail silently if _init_completion is not found
---

diff --git a/41/9ed935a20e5d7a2910a45b1d8880c7055beea8 b/41/9ed935a20e5d7a2910a45b1d8880c7055beea8
new file mode 100644
index 000000000..0708376e0
--- /dev/null
+++ b/41/9ed935a20e5d7a2910a45b1d8880c7055beea8
@@ -0,0 +1,66 @@
+Return-Path: <david@tethera.net>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+	by olra.theworths.org (Postfix) with ESMTP id 502D0431FB6
+	for <notmuch@notmuchmail.org>; Fri, 22 Aug 2014 17:08:55 -0700 (PDT)
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
+X-Spam-Flag: NO
+X-Spam-Score: 0
+X-Spam-Level: 
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
+	autolearn=disabled
+Received: from olra.theworths.org ([127.0.0.1])
+	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
+	with ESMTP id 9XgN+8scU4fJ for <notmuch@notmuchmail.org>;
+	Fri, 22 Aug 2014 17:08:50 -0700 (PDT)
+Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])
+	(using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
+	(No client certificate requested)
+	by olra.theworths.org (Postfix) with ESMTPS id DE315431FAF
+	for <notmuch@notmuchmail.org>; Fri, 22 Aug 2014 17:08:50 -0700 (PDT)
+Received: from remotemail by yantan.tethera.net with local (Exim 4.80)
+	(envelope-from <david@tethera.net>)
+	id 1XKysu-0005uB-2l; Fri, 22 Aug 2014 21:08:44 -0300
+Received: (nullmailer pid 10186 invoked by uid 1000); Sat, 23 Aug 2014
+	00:08:39 -0000
+From: David Bremner <david@tethera.net>
+To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org
+Subject: Re: [PATCH] completion: fail silently if _init_completion is not
+ found
+In-Reply-To: <1408379601-31994-1-git-send-email-jani@nikula.org>
+References: <1408379601-31994-1-git-send-email-jani@nikula.org>
+User-Agent: Notmuch/0.18.1+72~g028c560 (http://notmuchmail.org) Emacs/24.3.1
+	(x86_64-pc-linux-gnu)
+Date: Fri, 22 Aug 2014 17:08:39 -0700
+Message-ID: <87lhqggj94.fsf@maritornes.cs.unb.ca>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.13
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+	<notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Sat, 23 Aug 2014 00:08:55 -0000
+
+Jani Nikula <jani@nikula.org> writes:
+
+> The completion script depends on bash-completion 1.90 or later, with
+> _init_completion function. If that's not present, for some reason, the
+> completion currently fails with an ugly message, messing up user's
+> command line:
+>
+> $ notmuch -bash: _init_completion: command not found
+>
+> It's better to just not complete
+
+pushed.
+
+d