From: Austin Clements Date: Mon, 12 Aug 2013 18:40:34 +0000 (+2000) Subject: [PATCH 1/6] lib: Correct out-of-date doc comment X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=c0ac67f043fc5d6b69ce51c11bd74f5adfcd820d;p=notmuch-archives.git [PATCH 1/6] lib: Correct out-of-date doc comment --- diff --git a/9c/9a9fc0f5da7625af2fc3453a23ff0d93462581 b/9c/9a9fc0f5da7625af2fc3453a23ff0d93462581 new file mode 100644 index 000000000..3e8b11b91 --- /dev/null +++ b/9c/9a9fc0f5da7625af2fc3453a23ff0d93462581 @@ -0,0 +1,99 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 34C79431FD0 + for ; Mon, 12 Aug 2013 11:40:59 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id DX+DxqMv2KUi for ; + Mon, 12 Aug 2013 11:40:53 -0700 (PDT) +Received: from dmz-mailsec-scanner-8.mit.edu (dmz-mailsec-scanner-8.mit.edu + [18.7.68.37]) + by olra.theworths.org (Postfix) with ESMTP id DFFEA431FAF + for ; Mon, 12 Aug 2013 11:40:52 -0700 (PDT) +X-AuditID: 12074425-b7f0c8e000000953-9f-52092c34f7bb +Received: from mailhub-auth-3.mit.edu ( [18.9.21.43]) + by dmz-mailsec-scanner-8.mit.edu (Symantec Messaging Gateway) with SMTP + id 09.BF.02387.43C29025; Mon, 12 Aug 2013 14:40:52 -0400 (EDT) +Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) + by mailhub-auth-3.mit.edu (8.13.8/8.9.2) with ESMTP id r7CIepwH029101; + Mon, 12 Aug 2013 14:40:51 -0400 +Received: from drake.dyndns.org (26-4-172.dynamic.csail.mit.edu [18.26.4.172]) + (authenticated bits=0) + (User authenticated as amdragon@ATHENA.MIT.EDU) + by outgoing.mit.edu (8.13.8/8.12.4) with ESMTP id r7CIemSB003741 + (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT); + Mon, 12 Aug 2013 14:40:50 -0400 +Received: from amthrax by drake.dyndns.org with local (Exim 4.77) + (envelope-from ) + id 1V8x2u-0005yU-K1; Mon, 12 Aug 2013 14:40:48 -0400 +From: Austin Clements +To: notmuch@notmuchmail.org +Subject: [PATCH 1/6] lib: Correct out-of-date doc comment +Date: Mon, 12 Aug 2013 14:40:34 -0400 +Message-Id: <1376332839-22825-2-git-send-email-amdragon@mit.edu> +X-Mailer: git-send-email 1.7.10.4 +In-Reply-To: <1376332839-22825-1-git-send-email-amdragon@mit.edu> +References: <1376332839-22825-1-git-send-email-amdragon@mit.edu> +X-Brightmail-Tracker: + H4sIAAAAAAAAA+NgFtrIIsWRmVeSWpSXmKPExsUixCmqrWuiwxlkMOeVvMX1mzOZHRg9nq26 + xRzAGMVlk5Kak1mWWqRvl8CVMeXBP7aCuRwVD7/tZm9gPMnWxcjJISFgIrFl62x2CFtM4sK9 + 9UBxLg4hgX2MElvbFzBDOBsZJU5s7mEEqRISOMIksXy5JURiLqPE9dNdYO1sAhoS2/YvBysS + EZCW2Hl3NmsXIwcHs4CaxJ8uFRBTWMBS4tVKeZAKFgFViTv3t4B18go4SEy8/5cZ4ghFie5n + E8CO4xRwlLi//BwLxFoHiY27ehgnMPIvYGRYxSibklulm5uYmVOcmqxbnJyYl5dapGuhl5tZ + opeaUrqJERQy7C6qOxgnHFI6xCjAwajEw5vxkSNIiDWxrLgy9xCjJAeTkijvJE3OICG+pPyU + yozE4oz4otKc1OJDjBIczEoivFtYgXK8KYmVValF+TApaQ4WJXHe50/PBgoJpCeWpGanphak + FsFkZTg4lCR4hbSBGgWLUtNTK9Iyc0oQ0kwcnCDDeYCGu4PU8BYXJOYWZ6ZD5E8xKkqJ81qA + JARAEhmleXC9sJh+xSgO9IowryBIFQ8wHcB1vwIazAQ02KiZA2RwSSJCSqqBUcG0Okn3ZbJ4 + q5HeascPproWE2IbVKW25L4Vsdrto2UavUngYObxjl1utzvqbu5ctlLgZOWHHQq3hCJdBG+t + 9tjaxbh8c+NTz+DDHlP0zFckXVfwmy1udON54+ToX3sFurgtvT3bp5x+umy7lzjLZTZD72xr + Sdkjt/auF57E7f+a7cC9FGN2JZbijERDLeai4kQAaO/GcsQCAAA= +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 12 Aug 2013 18:40:59 -0000 + +notmuch_message_get_header started returning some headers straight +from the database in 567bcbc, but this comment explicitly claimed all +headers were read from the message file. +--- + lib/notmuch.h | 7 +++++-- + 1 file changed, 5 insertions(+), 2 deletions(-) + +diff --git a/lib/notmuch.h b/lib/notmuch.h +index 73c85a4..9fc34ef 100644 +--- a/lib/notmuch.h ++++ b/lib/notmuch.h +@@ -1015,8 +1015,11 @@ notmuch_message_get_date (notmuch_message_t *message); + + /* Get the value of the specified header from 'message'. + * +- * The value will be read from the actual message file, not from the +- * notmuch database. The header name is case insensitive. ++ * Common headers are stored in the database when the message is ++ * indexed and will be returned from the database. Other headers will ++ * be read from the actual message file. ++ * ++ * The header name is case insensitive. + * + * The returned string belongs to the message so should not be + * modified or freed by the caller (nor should it be referenced after +-- +1.7.10.4 +