From: David Bremner Date: Sat, 28 Mar 2015 14:35:02 +0000 (+0100) Subject: Re: [PATCH] emacs: show: hide large text attachments by default X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=c0659995dfe2806e7b98f06bdc96d2dbe1072652;p=notmuch-archives.git Re: [PATCH] emacs: show: hide large text attachments by default --- diff --git a/f1/8613fd1adc0fcfd3a75583353f76a0173189e7 b/f1/8613fd1adc0fcfd3a75583353f76a0173189e7 new file mode 100644 index 000000000..1c272f734 --- /dev/null +++ b/f1/8613fd1adc0fcfd3a75583353f76a0173189e7 @@ -0,0 +1,66 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 63705431FB6 + for ; Sat, 28 Mar 2015 07:36:45 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 2.438 +X-Spam-Level: ** +X-Spam-Status: No, score=2.438 tagged_above=-999 required=5 + tests=[DNS_FROM_AHBL_RHSBL=2.438] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id VxFC1C+rWLk2 for ; + Sat, 28 Mar 2015 07:36:42 -0700 (PDT) +Received: from mx.xen14.node3324.gplhost.com (gitolite.debian.net + [87.98.215.224]) + (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 24F11431FAE + for ; Sat, 28 Mar 2015 07:36:42 -0700 (PDT) +Received: from remotemail by mx.xen14.node3324.gplhost.com with local (Exim + 4.80) (envelope-from ) + id 1YbrpT-0004Uu-H7; Sat, 28 Mar 2015 14:35:15 +0000 +Received: (nullmailer pid 24498 invoked by uid 1000); Sat, 28 Mar 2015 + 14:35:02 -0000 +From: David Bremner +To: Mark Walters , notmuch@notmuchmail.org +Subject: Re: [PATCH] emacs: show: hide large text attachments by default +In-Reply-To: <1427540939-10055-1-git-send-email-markwalters1009@gmail.com> +References: <1427540939-10055-1-git-send-email-markwalters1009@gmail.com> +User-Agent: Notmuch/0.19+86~gbed8b67 (http://notmuchmail.org) Emacs/24.4.1 + (x86_64-pc-linux-gnu) +Date: Sat, 28 Mar 2015 15:35:02 +0100 +Message-ID: <87zj6xp4vd.fsf@maritornes.cs.unb.ca> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 28 Mar 2015 14:36:45 -0000 + +Mark Walters writes: + +> notmuch-show can be slow displaying large attachments so hide them by +> default. The default maximum size is 10000 bytes/characters but it is +> customizable. +> +> Note that notmuch-show-insert-bodypart is also called from the reply +> code so we need to be a little careful. + +I didn't look at the code yet, but I can confirm it makes a huge (about +17 times faster) difference for the problematic thread I have been +profiling. + +d