From: Daniel Kahn Gillmor Date: Wed, 10 Feb 2016 14:34:22 +0000 (+1900) Subject: Re: [PATCH v3 02/16] Move crypto.c into libutil X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=bf163a6678bb93e3381ae9b82474dc6c44cbb7be;p=notmuch-archives.git Re: [PATCH v3 02/16] Move crypto.c into libutil --- diff --git a/47/cc580f86ef6936aa6929154325fbffa51d089a b/47/cc580f86ef6936aa6929154325fbffa51d089a new file mode 100644 index 000000000..4d7c8f767 --- /dev/null +++ b/47/cc580f86ef6936aa6929154325fbffa51d089a @@ -0,0 +1,101 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id 37D0E6DE0BF6 + for ; Wed, 10 Feb 2016 06:34:29 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: -0.019 +X-Spam-Level: +X-Spam-Status: No, score=-0.019 tagged_above=-999 required=5 + tests=[AWL=-0.019] autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 3xY04vBiQpRb for ; + Wed, 10 Feb 2016 06:34:27 -0800 (PST) +Received: from che.mayfirst.org (che.mayfirst.org [209.234.253.108]) + by arlo.cworth.org (Postfix) with ESMTP id 507C66DE0B36 + for ; Wed, 10 Feb 2016 06:34:27 -0800 (PST) +Received: from fifthhorseman.net (unknown [38.109.115.130]) + by che.mayfirst.org (Postfix) with ESMTPSA id AB729F997; + Wed, 10 Feb 2016 09:34:21 -0500 (EST) +Received: by fifthhorseman.net (Postfix, from userid 1000) + id DCF382017F; Wed, 10 Feb 2016 09:34:22 -0500 (EST) +From: Daniel Kahn Gillmor +To: David Bremner , Notmuch Mail +Subject: Re: [PATCH v3 02/16] Move crypto.c into libutil +In-Reply-To: <87wpqduwz6.fsf@maritornes.cs.unb.ca> +References: <1454272801-23623-1-git-send-email-dkg@fifthhorseman.net> + <1454272801-23623-3-git-send-email-dkg@fifthhorseman.net> + <87wpqduwz6.fsf@maritornes.cs.unb.ca> +User-Agent: Notmuch/0.21+72~gd8c4f1c (http://notmuchmail.org) Emacs/24.5.1 + (x86_64-pc-linux-gnu) +Date: Wed, 10 Feb 2016 09:34:22 -0500 +Message-ID: <87io1wocr5.fsf@alice.fifthhorseman.net> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.20 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 10 Feb 2016 14:34:29 -0000 + +On Tue 2016-02-09 21:21:01 -0500, David Bremner wrote: +> Daniel Kahn Gillmor writes: +> +>> This prepares us for using the crypto object in both the library and +>> the client. +>> +>> i've prefixed notmuch_crypto with _ to indicate that while this can be +>> built into the library when needed, it's not something to be exported +>> or used externally. +> +> [...] snip +> +>> diff --git a/mime-node.c b/mime-node.c +>> index e96e663..a8f5670 100644 +>> --- a/mime-node.c +>> +++ b/mime-node.c +>> @@ -33,7 +33,7 @@ typedef struct mime_node_context { +>> GMimeMessage *mime_message; +>> +>> /* Context provided by the caller. */ +>> - notmuch_crypto_t *crypto; +>> + _notmuch_crypto_t *crypto; +>> } mime_node_context_t; +> +> is this maybe search and replace gone wild? or did you mean +> to rename the type as well as the functions? + +this is a type in the util library (which is shared between libnotmuch +and the cli, but not exposed by libnotmuch). As such, i deliberately +renamed the type to appear more explicitly "private". I do not think we +want to expose it to the library API, in part because it "contaminates" +libnotmuch with the gmime API (because it explicitly contemplates the +use of GMimeCryptoContext, see below). + +>> static void +>> node_verify (mime_node_t *node, GMimeObject *part, +>> - notmuch_crypto_context_t *cryptoctx) +>> + GMimeCryptoContext *cryptoctx) +>> { +> +> This change of parameter type seems significant. Does it deserve a +> comment in the commit message? + +I don't think this is a big change. notmuch_crypto_context was +originally a typedef to GMimeCryptoContext, and it wasn't being exposed +by the library API. Rather than pretend that it's something distinct, i +think it makes more explicit that this internal part of util deals with +libgmime. + + --dkg