From: W. Trevor King Date: Mon, 22 Sep 2014 16:59:54 +0000 (+1700) Subject: Re: [PATCH] lib: Simplify close and codify aborting atomic section X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=bda7aad0ce552ed690c5179fb3359f89ada1d1b0;p=notmuch-archives.git Re: [PATCH] lib: Simplify close and codify aborting atomic section --- diff --git a/1b/4fc1af8bc590afde0e7315068f48814fe4b3dd b/1b/4fc1af8bc590afde0e7315068f48814fe4b3dd new file mode 100644 index 000000000..ad9930b99 --- /dev/null +++ b/1b/4fc1af8bc590afde0e7315068f48814fe4b3dd @@ -0,0 +1,125 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 2512F431FC0 + for ; Mon, 22 Sep 2014 10:00:01 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.1 +X-Spam-Level: +X-Spam-Status: No, score=-0.1 tagged_above=-999 required=5 + tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, + RCVD_IN_DNSWL_NONE=-0.0001] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id LAbHfIG1WLmX for ; + Mon, 22 Sep 2014 09:59:57 -0700 (PDT) +Received: from resqmta-po-05v.sys.comcast.net (resqmta-po-05v.sys.comcast.net + [96.114.154.164]) + (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 29A9D431FB6 + for ; Mon, 22 Sep 2014 09:59:57 -0700 (PDT) +Received: from resomta-po-08v.sys.comcast.net ([96.114.154.232]) + by resqmta-po-05v.sys.comcast.net with comcast + id uGyT1o006516pyw01GzvlS; Mon, 22 Sep 2014 16:59:55 +0000 +Received: from odin.tremily.us ([24.18.63.50]) + by resomta-po-08v.sys.comcast.net with comcast + id uGzu1o00a152l3L01GzuA1; Mon, 22 Sep 2014 16:59:55 +0000 +Received: by odin.tremily.us (Postfix, from userid 1000) + id 6574A13A74B5; Mon, 22 Sep 2014 09:59:54 -0700 (PDT) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tremily.us; s=odin; + t=1411405194; bh=/IxcCaEY7mm7iOULiiwQDy7izpMnJDuHwvick5cS5B4=; + h=Date:From:To:Cc:Subject:References:In-Reply-To; + b=O0aVxTmXaVsXtyz91gbJ+3ZToO4gaNooGyFRQZ2ZdnGupi9T8NsShaQ0ueGtQGTn5 + 3P2+nUGU6WyFI1iXZnInFxA80nOF0d7iLYRyPnJ3TCPoXxIqEyt6zPhMHrsNLviVXH + sDx6BC/9I54xzrEoBM4Uog0kliKwgy/PMBTN++wc= +Date: Mon, 22 Sep 2014 09:59:54 -0700 +From: "W. Trevor King" +To: Austin Clements +Subject: Re: [PATCH] lib: Simplify close and codify aborting atomic section +Message-ID: <20140922165954.GI20827@odin.tremily.us> +References: <1411400615-20934-1-git-send-email-amdragon@mit.edu> +MIME-Version: 1.0 +Content-Type: multipart/signed; micalg=pgp-sha1; + protocol="application/pgp-signature"; boundary="zgY/UHCnsaNnNXRx" +Content-Disposition: inline +In-Reply-To: <1411400615-20934-1-git-send-email-amdragon@mit.edu> +OpenPGP: id=39A2F3FA2AB17E5D8764F388FC29BDCDF15F5BE8; + url=http://tremily.us/pubkey.txt +User-Agent: Mutt/1.5.23 (2014-03-12) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcast.net; + s=q20140121; t=1411405195; + bh=2bO80aFKD78S5G4i+hKBP/ZqERuWDCPzP+ylWiXiBoU=; + h=Received:Received:Received:Date:From:To:Subject:Message-ID: + MIME-Version:Content-Type; + b=luaN6xdDIZyZmEGiW5ByHpmlR8W/JmkAq25OZ9GlWmtVbKHjmlggfAJJpFsIHwK09 + vpRYTj4pRF+YgAucrB4YmKJF5TLvRrCYGadNTCXg+9BTI8JEtt/seFSa+xODCTWrxz + 2H3Qt8Bg2F1iRwIu1fnkjcqBUsBinlCcRCIsQvc+G55zqptrYs7xg8zaMMTmDYYWzL + AsyXIlLr33XbrpM1BzKVpInZABYTSlSf0OTgT4tJlAJB2f+tpw1xnTsDJENFBYTyPZ + FDqG89JUg+AP/iqejOchJZPD7g/s5xZ7YY0REldkDhTTNKLxDubmekVk17NcO/TnDf + p2CvaoIgyEhnQ== +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 22 Sep 2014 17:00:01 -0000 + + +--zgY/UHCnsaNnNXRx +Content-Type: text/plain; charset=us-ascii +Content-Disposition: inline +Content-Transfer-Encoding: quoted-printable + +On Mon, Sep 22, 2014 at 11:43:35AM -0400, Austin Clements wrote: +> This patch simplifies notmuch_database_close to just call +> Database::close. This works for both read-only and read/write +> databases, takes care of committing changes, unifies the exception +> handling path, and codifies aborting outstanding transactions. + +If we're dropping the flush call here, where will it be triggered +instead? We'll need to flush/commit our changes to the database at +some point before closing. Do clients now need an explicit +flush/commit command (explicit, client-initiated flushes sound like a +good idea to me). + +Cheers, +Trevor + +--=20 +This email may be signed or encrypted with GnuPG (http://www.gnupg.org). +For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy + +--zgY/UHCnsaNnNXRx +Content-Type: application/pgp-signature; name="signature.asc" +Content-Description: OpenPGP digital signature + +-----BEGIN PGP SIGNATURE----- +Version: GnuPG v2 + +iQIcBAEBAgAGBQJUIFWJAAoJEG8/JgBt8ol8cAkP/jGJGVE54E2keqkqx1uevBic +Zb/RQMyr7uC88m9qLKl6PQpnEhHYcRZzGxl4W6nYv58T08+nqb0n1mLDdim0Elsf +0BiVo8ou6p6u2NEJzpsyN9n7ZeDujzv0AzaBk/Nof++ZskHU+jxg6QLE8UMbYYKK +xC+OBtEaNYmyDjdmNU7/sSQVW6E6y2q1WiWDgsRoX7nJxCA7UVR0tVT2I4t9Dg+M +tUUyhnvivRKligUIM/Bqhvtbnh951y9BLWfCMfErqnmK3Q70GvN8nmlljJ83aTHT +qrKuGr+uUqQt6qd2KVbEsrw3BmdzRLxCUsmQhQHFfvCh5Dvdi06LkqAheBB72BXV +rHCZnefeJz75N1DF6ZLh13A/WfJDIqp7kwoHA1aaTI6QsLApXxHhMFe/n4cMCkOz +b/sUI6K4/WgECLcp3vIDDvcjFpxDOapzPZYitdO3ljScsOBIwsRLF5h1+GsLZHFT +jiUXlP4+sCkQD24Oi4RKYMKu43DZ1D6MirE9eYf+QlKb8ilUi3/cMxSb2uBTbRV1 +iI7YesYfViOKLT6Gp9hlEaKKlkPJ5SogFA4bpJSkwVEXJSibzx0af/p13yXrOUMh +hG1nDY8A1/gd4okABLJ/+73QlQb2RYFkOFqWUrKBca7akLyVdOBZDqJ00LnFPsmW +05U/jwDZI1rCzawoPH30 +=lmZL +-----END PGP SIGNATURE----- + +--zgY/UHCnsaNnNXRx--