From: Jani Nikula Date: Mon, 9 Dec 2013 09:46:18 +0000 (+0100) Subject: Re: [PATCH WIP v3 0/3] emacs: show: change the unread handling X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=bc6624619d8513b4f9390a8a7f7b3fe2e35e0d5c;p=notmuch-archives.git Re: [PATCH WIP v3 0/3] emacs: show: change the unread handling --- diff --git a/61/9df86f2bda77a832bd52abdbcbf77eceb5dddc b/61/9df86f2bda77a832bd52abdbcbf77eceb5dddc new file mode 100644 index 000000000..a6311f86e --- /dev/null +++ b/61/9df86f2bda77a832bd52abdbcbf77eceb5dddc @@ -0,0 +1,131 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 03CEA431FC0 + for ; Mon, 9 Dec 2013 01:46:49 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id gsew80BioBkd for ; + Mon, 9 Dec 2013 01:46:39 -0800 (PST) +Received: from mail-qc0-f178.google.com (mail-qc0-f178.google.com + [209.85.216.178]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 80017431FAE + for ; Mon, 9 Dec 2013 01:46:39 -0800 (PST) +Received: by mail-qc0-f178.google.com with SMTP id i17so2453196qcy.37 + for ; Mon, 09 Dec 2013 01:46:37 -0800 (PST) +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=1e100.net; s=20130820; + h=x-gm-message-state:from:to:subject:in-reply-to:references + :user-agent:date:message-id:mime-version:content-type; + bh=dOGDABA/+on1QZCCs2j/HQQF9CCwcjOG0Kb9gAlzlDY=; + b=dwvPn7N/hb6TgG6gHWC4QmcFY5ZTXIa732tGql/BcL+3wyw1yQSykiYUysUqjLfujZ + PQnSwRGtPLqHId8sUk9SxzahPl1r8SsA30e84IRPgm8GxLCVT07VekZ/psqZG1mkXaWj + UyJuu620ZrpZQL9/VpqvaZf2gm6NmVbik+OTR8ogLLhKhxonrSA2ewIEx7pBq9j4I0PZ + 5BR+mk8bvePHBfmwnmqJX4JOipkRsAMtmyF/J6bhvcyWohkYPywAUfrfkujsCI4Smkmg + QgiL9lDrZbZZpChbjFuaix1U860axM6grawguCq5c6lkhHmiO27uN/GJtjRkWqw88uW6 + 13vg== +X-Gm-Message-State: + ALoCoQlrXQnTFTrYs0Y+v74PNuKWsqLJQeOM9le9+WiW2RIJ2l3PtaHjDryfX5e0R9UTCBVxJ639 +X-Received: by 10.49.1.35 with SMTP id 3mr80135689qej.43.1386582397890; + Mon, 09 Dec 2013 01:46:37 -0800 (PST) +Received: from localhost ([2001:4b98:dc0:43:216:3eff:fe1b:25f3]) + by mx.google.com with ESMTPSA id r5sm31243406qaj.13.2013.12.09.01.46.36 + for + (version=TLSv1.1 cipher=RC4-SHA bits=128/128); + Mon, 09 Dec 2013 01:46:37 -0800 (PST) +From: Jani Nikula +To: Mark Walters , notmuch@notmuchmail.org +Subject: Re: [PATCH WIP v3 0/3] emacs: show: change the unread handling +In-Reply-To: <1386273871-24214-1-git-send-email-markwalters1009@gmail.com> +References: <1386273871-24214-1-git-send-email-markwalters1009@gmail.com> +User-Agent: Notmuch/0.17~rc2+11~gef943e9 (http://notmuchmail.org) Emacs/23.2.1 + (x86_64-pc-linux-gnu) +Date: Mon, 09 Dec 2013 10:46:18 +0100 +Message-ID: <871u1ms6fp.fsf@nikula.org> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 09 Dec 2013 09:46:49 -0000 + +On Thu, 05 Dec 2013, Mark Walters wrote: +> This is the next iteration of this WIP patch series. v2 was at +> id:1385892147-16994-1-git-send-email-markwalters1009@gmail.com +> +> I would just like to emphasise that *all* feedback is appreciated +> including "I HATE IT" etc. + +I LIKE IT. :) + +It's not perfect, but IMHO it's a nice, incremental improvement over +what we have, and it's discoverable: you can see what it does and +when. If anything is surprising, the user has a better chance of +explaining what happened, and what he liked and didn't. + +Good work, Mark! + +BR, +Jani. + + +PS. I didn't look at the code, I only tried it. + + +> I have followed Jani's suggestion and removed the delayed updates to +> unread status: it makes it harder to see if the heuristics are doing +> what you want. +> +> The first patch is completely new: it makes all tag changes in a +> buffer (in particular the unread tag) clearly visible to the user: a +> deleted tag is displayed with red strike-through and an added tag is +> displayed underlined in green. (This may have strange interactions with +> notmuch-tag-formats in some cases.) +> +> This makes the visual feedback when a message is marked unread very +> clear: the unread tag is struck-through. +> +> As always with the previous series lots of tests will fail for the +> obvious reason that marking read is done differently and displayed +> differently. +> +> Best wishes +> +> Mark +> +> +> +> +> Mark Walters (3): +> emacs: show: mark tags changed since buffer loaded +> emacs: show: add an update seen function to post-command-hook +> emacs: show: make `seen' mean user viewed whole message +> +> emacs/notmuch-show.el | 136 +++++++++++++++++++++++++++++++++++++++++------- +> emacs/notmuch-tag.el | 30 +++++++---- +> 2 files changed, 136 insertions(+), 30 deletions(-) +> +> -- +> 1.7.9.1 +> +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> http://notmuchmail.org/mailman/listinfo/notmuch