From: Mark Walters Date: Sat, 1 Jun 2013 21:45:27 +0000 (+0100) Subject: Re: [PATCH 2/2] contrib: pick: thread tagging (including archiving) implemented X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=bc38577dda54e052ac821321146b77a2306ca470;p=notmuch-archives.git Re: [PATCH 2/2] contrib: pick: thread tagging (including archiving) implemented --- diff --git a/59/4b9c8bced0889e48af317aaf0d08112541a7e3 b/59/4b9c8bced0889e48af317aaf0d08112541a7e3 new file mode 100644 index 000000000..b5623181f --- /dev/null +++ b/59/4b9c8bced0889e48af317aaf0d08112541a7e3 @@ -0,0 +1,116 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 09634429E59 + for ; Sat, 1 Jun 2013 14:45:42 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -1.098 +X-Spam-Level: +X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5 + tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, + NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id APBTparPkFGM for ; + Sat, 1 Jun 2013 14:45:34 -0700 (PDT) +Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id B72CC431FDE + for ; Sat, 1 Jun 2013 14:45:33 -0700 (PDT) +Received: from smtp.qmul.ac.uk ([138.37.6.40]) + by mail2.qmul.ac.uk with esmtp (Exim 4.71) + (envelope-from ) + id 1Uitc9-0003Pv-Dv; Sat, 01 Jun 2013 22:45:29 +0100 +Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost) + by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71) + (envelope-from ) + id 1Uitc9-0004On-48; Sat, 01 Jun 2013 22:45:29 +0100 +From: Mark Walters +To: David Bremner , notmuch@notmuchmail.org +Subject: Re: [PATCH 2/2] contrib: pick: thread tagging (including archiving) + implemented +In-Reply-To: <87zjv91uki.fsf@zancas.localnet> +References: <1354970914-18342-1-git-send-email-markwalters1009@gmail.com> + <1354970914-18342-3-git-send-email-markwalters1009@gmail.com> + <87zjv91uki.fsf@zancas.localnet> +User-Agent: Notmuch/0.14+255~gff3cc55 (http://notmuchmail.org) Emacs/23.4.1 + (x86_64-pc-linux-gnu) +Date: Sat, 01 Jun 2013 22:45:27 +0100 +Message-ID: <87r4gly07c.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Sender-Host-Address: 93.97.24.31 +X-QM-SPAM-Info: Sender has good ham record. :) +X-QM-Body-MD5: cc5973d852c514d45253f4140caf3088 (of first 20000 bytes) +X-SpamAssassin-Score: -0.1 +X-SpamAssassin-SpamBar: / +X-SpamAssassin-Report: The QM spam filters have analysed this message to + determine if it is + spam. We require at least 5.0 points to mark a message as spam. + This message scored -0.1 points. + Summary of the scoring: + * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail + provider * (markwalters1009[at]gmail.com) + * -0.1 AWL AWL: From: address is in the auto white-list +X-QM-Scan-Virus: ClamAV says the message is clean +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 01 Jun 2013 21:45:42 -0000 + + +Thanks for the review. A couple of comments below: + +On Sat, 01 Jun 2013, David Bremner wrote: +> Mark Walters writes: +> +>> Previously pick had no actions based on the entire thread: this adds +>> some. Note in this version '*' is bound to `tag thread' which is not +>> consistent with search or show. However it still might be the most +>> natural thing (as it is similar to running * in the show pane). +> +> Hmm. not sure about this. But since nobody complained in six months, +> let's go with it unless they wake up. + +Ok + +>> + (setq tag-changes (funcall 'notmuch-tag +>> (notmuch-pick-get-messages-ids-thread-search) tag-changes)) +> +> Why "(funcall 'notmuch-tag ...) instead of a "(notmuch-tag ...)" here? +> Personally I'd use let instead of setq here, but ymmv. + +I agree with both of these but this is almost identical code to that in +notmuch-show-tag-all. + +>> +Archive each message currently shown by applying the tag changes +>> +in `notmuch-archive-tags' to each (remove the \"inbox\" tag by +>> +default). If a prefix argument is given, the messages will be +>> +\"unarchived\", i.e. the tag changes in `notmuch-archive-tags' +>> +will be reversed. +> +> It seems to me the default value for notmuch-archive-tags should not be +> hard-coded into this docstring, especially since notmuch-archive-tags +> turns into a link in the help text. + +I am happy either way on this one but again this is the same as +notmuch-show-archive-thread. + +I think it's probably best to keep show and pick the same where they are +similar but I can change the above if you disagree. + +Best wishes + +Mark