From: Tom Yu <tlyu@mit.edu>
Date: Wed, 19 May 2010 21:23:14 +0000 (+0000)
Subject: memory leak in process_tgs_req in r23724
X-Git-Tag: krb5-1.7.2-final~9
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=baaf8dd1189ab9f1c6d2d111ff42d7fb4f313435;p=krb5.git

memory leak in process_tgs_req in r23724

pull up r23959 from trunk

 ------------------------------------------------------------------------
 r23959 | tlyu | 2010-04-30 17:10:55 -0400 (Fri, 30 Apr 2010) | 8 lines

 ticket: 6711
 subject: memory leak in process_tgs_req in r23724
 tags: pullup
 target_version: 1.8.2

 Fix a KDC memory leak that was introduced by r23724 that could leak
 the decoded request.

ticket: 6728
target_version: 1.7.2
version_fixed: 1.7.2
tags: pullup
status: resolved

git-svn-id: svn://anonsvn.mit.edu/krb5/branches/krb5-1-7@24066 dc483132-0cff-0310-8789-dd5450dbe970
---

diff --git a/src/kdc/do_tgs_req.c b/src/kdc/do_tgs_req.c
index 2db5baf4a..2426510cb 100644
--- a/src/kdc/do_tgs_req.c
+++ b/src/kdc/do_tgs_req.c
@@ -135,8 +135,10 @@ process_tgs_req(krb5_data *pkt, const krb5_fulladdr *from,
     retval = decode_krb5_tgs_req(pkt, &request);
     if (retval)
         return retval;
-    if (request->msg_type != KRB5_TGS_REQ)
+    if (request->msg_type != KRB5_TGS_REQ) {
+        krb5_free_kdc_req(kdc_context, request);
         return KRB5_BADMSGTYPE;
+    }
 
     /*
      * setup_server_realm() sets up the global realm-specific data pointer.