From: David Bremner Date: Wed, 10 Feb 2016 02:21:01 +0000 (+2000) Subject: Re: [PATCH v3 02/16] Move crypto.c into libutil X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=ba33134c1e994ea3ad17a402efca7f1a7195abfa;p=notmuch-archives.git Re: [PATCH v3 02/16] Move crypto.c into libutil --- diff --git a/25/c34de86f0b50fad78969e860967f265c7c4ec8 b/25/c34de86f0b50fad78969e860967f265c7c4ec8 new file mode 100644 index 000000000..e1c3e6698 --- /dev/null +++ b/25/c34de86f0b50fad78969e860967f265c7c4ec8 @@ -0,0 +1,86 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id 5D6516DE0231 + for ; Tue, 9 Feb 2016 18:21:09 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: -0.308 +X-Spam-Level: +X-Spam-Status: No, score=-0.308 tagged_above=-999 required=5 tests=[AWL=0.243, + RP_MATCHES_RCVD=-0.55, SPF_PASS=-0.001] autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id jCnQh-uiztbk for ; + Tue, 9 Feb 2016 18:21:07 -0800 (PST) +Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) + by arlo.cworth.org (Postfix) with ESMTPS id 4CA6D6DE021E + for ; Tue, 9 Feb 2016 18:21:07 -0800 (PST) +Received: from remotemail by fethera.tethera.net with local (Exim 4.84) + (envelope-from ) + id 1aTKOE-0001Ro-Q5; Tue, 09 Feb 2016 21:20:22 -0500 +Received: (nullmailer pid 9755 invoked by uid 1000); + Wed, 10 Feb 2016 02:21:01 -0000 +From: David Bremner +To: Daniel Kahn Gillmor , + Notmuch Mail +Subject: Re: [PATCH v3 02/16] Move crypto.c into libutil +In-Reply-To: <1454272801-23623-3-git-send-email-dkg@fifthhorseman.net> +References: <1454272801-23623-1-git-send-email-dkg@fifthhorseman.net> + <1454272801-23623-3-git-send-email-dkg@fifthhorseman.net> +User-Agent: Notmuch/0.21+5~gca076ce (http://notmuchmail.org) Emacs/24.5.1 + (x86_64-pc-linux-gnu) +Date: Tue, 09 Feb 2016 22:21:01 -0400 +Message-ID: <87wpqduwz6.fsf@maritornes.cs.unb.ca> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.20 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 10 Feb 2016 02:21:09 -0000 + +Daniel Kahn Gillmor writes: + +> This prepares us for using the crypto object in both the library and +> the client. +> +> i've prefixed notmuch_crypto with _ to indicate that while this can be +> built into the library when needed, it's not something to be exported +> or used externally. + +[...] snip + +> diff --git a/mime-node.c b/mime-node.c +> index e96e663..a8f5670 100644 +> --- a/mime-node.c +> +++ b/mime-node.c +> @@ -33,7 +33,7 @@ typedef struct mime_node_context { +> GMimeMessage *mime_message; +> +> /* Context provided by the caller. */ +> - notmuch_crypto_t *crypto; +> + _notmuch_crypto_t *crypto; +> } mime_node_context_t; + +is this maybe search and replace gone wild? or did you mean +to rename the type as well as the functions? + +> static void +> node_verify (mime_node_t *node, GMimeObject *part, +> - notmuch_crypto_context_t *cryptoctx) +> + GMimeCryptoContext *cryptoctx) +> { + +This change of parameter type seems significant. Does it deserve a +comment in the commit message? +