From: W. Trevor King Date: Fri, 31 Oct 2014 18:18:13 +0000 (+1700) Subject: Re: [PATCH] test: Make gen-threads work with python3 X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=b975cfc459a90b4725a8b001a6d0d0f3215948c8;p=notmuch-archives.git Re: [PATCH] test: Make gen-threads work with python3 --- diff --git a/7b/2e3ad2b218af024fc3be9987f42e670125b481 b/7b/2e3ad2b218af024fc3be9987f42e670125b481 new file mode 100644 index 000000000..17fa7c5c7 --- /dev/null +++ b/7b/2e3ad2b218af024fc3be9987f42e670125b481 @@ -0,0 +1,134 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 67FF9431FBC + for ; Fri, 31 Oct 2014 11:18:24 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.1 +X-Spam-Level: +X-Spam-Status: No, score=-0.1 tagged_above=-999 required=5 + tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, + RCVD_IN_DNSWL_NONE=-0.0001] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 9PgrCZlUVBkK for ; + Fri, 31 Oct 2014 11:18:16 -0700 (PDT) +Received: from resqmta-ch2-02v.sys.comcast.net + (resqmta-ch2-02v.sys.comcast.net [69.252.207.34]) + (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id C07FE431FAF + for ; Fri, 31 Oct 2014 11:18:16 -0700 (PDT) +Received: from resomta-ch2-03v.sys.comcast.net ([69.252.207.99]) + by resqmta-ch2-02v.sys.comcast.net with comcast + id 9uJ81p00729Cfhx01uJFXF; Fri, 31 Oct 2014 18:18:15 +0000 +Received: from odin.tremily.us ([24.18.63.50]) + by resomta-ch2-03v.sys.comcast.net with comcast + id 9uJD1p00Y152l3L01uJEqz; Fri, 31 Oct 2014 18:18:15 +0000 +Received: by odin.tremily.us (Postfix, from userid 1000) + id 2C2CE1440C36; Fri, 31 Oct 2014 11:18:13 -0700 (PDT) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tremily.us; s=odin; + t=1414779493; bh=Gpjho2Ci/yDqr/kti83DN0jrgE1l+AdrCNrx75kDB74=; + h=Date:From:To:Cc:Subject:References:In-Reply-To; + b=QdvP/arKYzbGxLYnVLWjHN5i+z1eoqyZroliYqqSogyU3XE0z4KMHy5Wi+MSlWFtJ + Vx70N2kmGoLSvIC78Dvk6FJVyPHSIJEDXBLjQi3nPFVUUhZyRYVnS8unb+/4534Vf7 + Ms9uWcHjYksSkeMbuR8CTNEIcag+DPiQnMVkDGLE= +Date: Fri, 31 Oct 2014 11:18:13 -0700 +From: "W. Trevor King" +To: Jesse Rosenthal +Subject: Re: [PATCH] test: Make gen-threads work with python3 +Message-ID: <20141031181812.GS15443@odin.tremily.us> +References: <1414776805-30000-1-git-send-email-jrosenthal@jhu.edu> + <20141031174153.GQ15443@odin.tremily.us> <87bnosdsjh.fsf@jhu.edu> +MIME-Version: 1.0 +Content-Type: multipart/signed; micalg=pgp-sha1; + protocol="application/pgp-signature"; boundary="vdyjigDobekge4RG" +Content-Disposition: inline +In-Reply-To: <87bnosdsjh.fsf@jhu.edu> +OpenPGP: id=39A2F3FA2AB17E5D8764F388FC29BDCDF15F5BE8; + url=http://tremily.us/pubkey.txt +User-Agent: Mutt/1.5.23 (2014-03-12) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcast.net; + s=q20140121; t=1414779495; + bh=A0Ii2kqfM7UR3h0csNuXi2dv2aQjU6l2ly1VayuhkiA=; + h=Received:Received:Received:Date:From:To:Subject:Message-ID: + MIME-Version:Content-Type; + b=aAHmRL+ROdxjA5yKlnR4EpjmJeelqTWMuwsXhEhe5i9ecU1Haa7HSxo8pNLzAye/Z + fTF9yeBBhDQzQfBEUixIsT3OfsyczzaMrPogwBg3GhXAu99QCTsvCOvy6snXMyrGu9 + QR610B47SyXK+qPBRgvYTyyUBdxsuEJ75vQ2Ub8bmwn8NzkBtIzWguisBhDp96JIHz + t2QVa4LGTqNcSNEOtTUiBJLZ3zKI60c0/gMx4qXqQGLNwwcqaVGHH21WXy55J0rcG7 + H+Dqb81Y9WXJOzgROCOvr4rKNeYj/6gz/pDLZ6usXYukqcSZmI64YQCiisrwL+ufe0 + byP9m4+oYic/A== +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Fri, 31 Oct 2014 18:18:24 -0000 + + +--vdyjigDobekge4RG +Content-Type: text/plain; charset=utf-8 +Content-Disposition: inline +Content-Transfer-Encoding: quoted-printable + +On Fri, Oct 31, 2014 at 02:04:50PM -0400, Jesse Rosenthal wrote: +> W. Trevor King writes: +> > On Fri, Oct 31, 2014 at 01:33:25PM -0400, Jesse Rosenthal wrote: +> >> We instead initalize the dictionary using the dict comprehension +> >> and then update it with the values from the tree. This will work +> >> with both python2 and python3. +> > +> > Dict comprehensions are new in 2.7 [1,2], so this drops support +> > for systems where =E2=80=98python=E2=80=99 means =E2=80=98python2.6=E2= +=80=99. Personally, I'm +> > fine with that, but I thought I'd point it out in case 2.6 users +> > wanted to push back ;). +>=20 +> The comprehension was already in the previous version, so I figured that +> people were already cool with 2.7+. + +Ah, good point :). Besides looking good to me, I can confirm that I +see a TypeError (and a lot of CPU usage ;) from T260-thread-order.sh +before this patch which is fixed by this patch. + +Cheers, +Trevor + +--=20 +This email may be signed or encrypted with GnuPG (http://www.gnupg.org). +For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy + +--vdyjigDobekge4RG +Content-Type: application/pgp-signature; name="signature.asc" +Content-Description: OpenPGP digital signature + +-----BEGIN PGP SIGNATURE----- +Version: GnuPG v2 + +iQIcBAEBAgAGBQJUU9JiAAoJEG8/JgBt8ol88CgP/3eB+Xr4T2KBCWgdCCHV3M/G +xhcpqPnXZGw8jVQLn4RVbthrg4Z0ZbbMrpMstdqPnh6+SPlqzXUdvverz6ILlcdL +MCWHDll3wiq6d9Fa2FkdQZMD3UUpYdEP/JzVM77VDQGB0EYytDs1jIHh6K1a00uE +UvdBlT87ik1yoHWIBbb/n56ZWcRq3wTMcveDBaPo0Z0nrxtT8kZM0RNX6ONuYvFF +8DZeREVeImjy/vgIltuXTTpZ7QdDrnuxYpv3JE08vOc2hLPtJNXhQJDypmGX7N55 +JfumCL0cOjlQe18tChxnlfPj7X6QqVy0wvwG+8GtJhNPAmiVhATQDpM9AxCslk4a +d3LFEus1jrIysq5q86gRTmWJeGTz+XmJNqvod35cPKsWOR2WI4nvwVuqarktvFZi +2kvyCqVJ80gYCyGqhQ1VkpeNf8vk1g/+isrd9Ja928pfYnfSeVRz4t2PnlCuigZA +5HeKGQVTyEf6xamR9SrB2nfTMLUW9inXofEhpzX4n5uRTyPvf4ifxuqhLGBDtj+h +R01COJy1Jd7x2CBErqABjk+ygKWzZd5GKoCStzFVJeAQvwm7TSAcNyPZsE/x+sLw +m0Q9yCP56i4fQDTjbP4Xj0F3pnmamI0TDu31POk0LyxQmA4rK1XlHoOHxu8rNzcv +sgTX8zho6VJ3NVP6TzQJ +=WRqI +-----END PGP SIGNATURE----- + +--vdyjigDobekge4RG--