From: David Bremner Date: Sun, 20 Sep 2015 11:31:16 +0000 (+2100) Subject: Re: [PATCH] make test: NOTMUCH_TEST_QUIET=1 is now the default X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=b942d70036afc941ed6a12b60aca1d68fa06755b;p=notmuch-archives.git Re: [PATCH] make test: NOTMUCH_TEST_QUIET=1 is now the default --- diff --git a/19/a06604952a8fb27954f775169617fca1529443 b/19/a06604952a8fb27954f775169617fca1529443 new file mode 100644 index 000000000..33b093267 --- /dev/null +++ b/19/a06604952a8fb27954f775169617fca1529443 @@ -0,0 +1,80 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id 0E5F46DE1AE0 + for ; Sun, 20 Sep 2015 04:36:12 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: 0.114 +X-Spam-Level: +X-Spam-Status: No, score=0.114 tagged_above=-999 required=5 tests=[AWL=0.114] + autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id Y8PjE9KWzh4y for ; + Sun, 20 Sep 2015 04:36:10 -0700 (PDT) +Received: from gitolite.debian.net (gitolite.debian.net [87.98.215.224]) + by arlo.cworth.org (Postfix) with ESMTPS id 072816DE1ADF + for ; Sun, 20 Sep 2015 04:36:09 -0700 (PDT) +Received: from remotemail by gitolite.debian.net with local (Exim 4.80) + (envelope-from ) + id 1Zdctk-0006gf-N4; Sun, 20 Sep 2015 11:35:12 +0000 +Received: (nullmailer pid 15237 invoked by uid 1000); Sun, 20 Sep 2015 + 11:31:16 -0000 +From: David Bremner +To: Tomi Ollila , notmuch@notmuchmail.org +Subject: Re: [PATCH] make test: NOTMUCH_TEST_QUIET=1 is now the default +In-Reply-To: <1442004251-32325-1-git-send-email-tomi.ollila@iki.fi> +References: <1442004251-32325-1-git-send-email-tomi.ollila@iki.fi> +User-Agent: Notmuch/0.20.2+73~gd432116 (http://notmuchmail.org) Emacs/24.5.1 + (x86_64-pc-linux-gnu) +Date: Sun, 20 Sep 2015 08:31:16 -0300 +Message-ID: <87io75tji3.fsf@maritornes.cs.unb.ca> +MIME-Version: 1.0 +Content-Type: text/plain +Cc: tomi.ollila@iki.fi +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.18 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 20 Sep 2015 11:36:12 -0000 + +Tomi Ollila writes: + +> make test V=1 (or any other value than 0) and make test V=0 +> works similar way as build in general +> --- +> +> This is 2nd try: In first one I changed test-lib.sh -- there problem +> was the precedence between command line argument and NOTMUCH_TEST_QUIET +> environment variable. Here I don't see a problem there (although +> env NOTMUCH_TEST_QUIET=1 make test V=1 will make environment variable +> overrule the V=1 -- I am not sure who cares, though :D) +> +> Anyway, Someone(TM) may have better solution in mind, so let's +> get bikeshedding going! +> + +One thing I thought of was that we could replace the use of +NOTMUCH_TEST_QUIET with e.g. NOTMUCH_TEST_VERBOSE, and have that set by +the command line argument --verbose. This would be less work on the +Makefile side, but I guess a bit more on the test-lib.sh side. I suppose +it might also be an annoyance for some people currently using +NOTMUCH_TEST_QUIET in some autobuilder setup. At the moment I can't +think of what would really break by changing this "API", but knows. The +current behaviour of having NOTMUCH_TEST_QUIET and --verbose completely +independent is pretty surprising. + +d + +P.S. I hope you appreciate my classic "scope-creep" technique in +bikeshedding. ;)