From: Tomi Ollila <tomi.ollila@iki.fi>
Date: Sat, 2 Nov 2013 13:39:28 +0000 (+0200)
Subject: Re: [PATCH 0/3] General fixes
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=b93e20c1f3c14113934f05ecb0910ab6ec7ab6a6;p=notmuch-archives.git

Re: [PATCH 0/3] General fixes
---

diff --git a/bc/685ed61467a879b5d87040c0ddb38497ba3c22 b/bc/685ed61467a879b5d87040c0ddb38497ba3c22
new file mode 100644
index 000000000..b2afbc375
--- /dev/null
+++ b/bc/685ed61467a879b5d87040c0ddb38497ba3c22
@@ -0,0 +1,102 @@
+Return-Path: <tomi.ollila@iki.fi>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+	by olra.theworths.org (Postfix) with ESMTP id 97990431FC3
+	for <notmuch@notmuchmail.org>; Sat,  2 Nov 2013 06:39:37 -0700 (PDT)
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
+X-Spam-Flag: NO
+X-Spam-Score: 0
+X-Spam-Level: 
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
+	autolearn=disabled
+Received: from olra.theworths.org ([127.0.0.1])
+	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
+	with ESMTP id 8CbLeXOlMf52 for <notmuch@notmuchmail.org>;
+	Sat,  2 Nov 2013 06:39:32 -0700 (PDT)
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
+	by olra.theworths.org (Postfix) with ESMTP id A25D4431FAF
+	for <notmuch@notmuchmail.org>; Sat,  2 Nov 2013 06:39:32 -0700 (PDT)
+Received: from guru.guru-group.fi (localhost [IPv6:::1])
+	by guru.guru-group.fi (Postfix) with ESMTP id 3D2DF10005D;
+	Sat,  2 Nov 2013 15:39:28 +0200 (EET)
+From: Tomi Ollila <tomi.ollila@iki.fi>
+To: Felipe Contreras <felipe.contreras@gmail.com>,
+	David Bremner <david@tethera.net>, notmuch@notmuchmail.org
+Subject: Re: [PATCH 0/3] General fixes
+In-Reply-To: <5274fc9ef3925_6f56937e844a@nysa.notmuch>
+References: <1380558523-6913-1-git-send-email-felipe.contreras@gmail.com>
+	<87txgpv16s.fsf@zancas.localnet>
+	<5274ed4d5126a_46fcefbe747f@nysa.notmuch>
+	<87d2mjrlh3.fsf@zancas.localnet>
+	<5274fc9ef3925_6f56937e844a@nysa.notmuch>
+User-Agent: Notmuch/0.16+119~g219c55f (http://notmuchmail.org) Emacs/24.3.1
+	(x86_64-unknown-linux-gnu)
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
+	$[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
+	!)g;OY^,BjTbr)Np:%c_o'jj,Z
+Date: Sat, 02 Nov 2013 15:39:28 +0200
+Message-ID: <m2iowa3otr.fsf@guru.guru-group.fi>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.13
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+	<notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Sat, 02 Nov 2013 13:39:37 -0000
+
+On Sat, Nov 02 2013, Felipe Contreras <felipe.contreras@gmail.com> wrote:
+
+> David Bremner wrote:
+>> Felipe Contreras <felipe.contreras@gmail.com> writes:
+>> 
+>> > David Bremner wrote:
+>> >> Felipe Contreras <felipe.contreras@gmail.com> writes:
+>> >> 
+>> >> > Felipe Contreras (3):
+>> >> >   query: bind queries to database objects
+>> >> >   ruby: allow build with RUNPATH
+>> >> >   ruby: bind database close()/destroy() properly
+>> >> 
+>> >> I agree with the discussion on IRC that the change in the first patch
+>> >> makes sense.
+>> >
+>> > Shall I push it to the master branch then?
+>> 
+>> sure.
+>
+> Done.
+>
+>> > I don't really care that much about patch #2, but #3 should probably be
+>> > applied.
+>> 
+>> Just to be clear, I wasn't objecting to patch 2, just asking for a few
+>> more words of commit message.
+>
+> Yes, that's what I understood, but at the moment I don't thin it's worth my
+> time to do that. There's mor interesting stuff to do, maybe later.
+
+Lame excuse >;)
+
+>
+>> For patch 3, since it's ruby specific and
+>> nobody complained, I'd say go for it.
+>
+> All right. I'll probably wait a bit more, maybe a week to see if somebody
+> shouts.
+
+Remember Feature freeze: November 8
+
+>
+> -- 
+> Felipe Contreras
+
+Tomi