From: Jani Nikula Date: Sun, 19 Jun 2016 20:15:28 +0000 (+0300) Subject: [RFC PATCH 0/6] cli/reply: refactoring part 2 X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=b926067516ada039735f0d74f06411589cb00bc0;p=notmuch-archives.git [RFC PATCH 0/6] cli/reply: refactoring part 2 --- diff --git a/6f/a7c6b9cb1cd906bf43270449053740264c0bdd b/6f/a7c6b9cb1cd906bf43270449053740264c0bdd new file mode 100644 index 000000000..569c1a1c7 --- /dev/null +++ b/6f/a7c6b9cb1cd906bf43270449053740264c0bdd @@ -0,0 +1,107 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id 165D96DE0355 + for ; Sun, 19 Jun 2016 13:17:11 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: -0.568 +X-Spam-Level: +X-Spam-Status: No, score=-0.568 tagged_above=-999 required=5 tests=[AWL=0.152, + DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_LOW=-0.7, + RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01] autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id sZL8uBU3xs3a for ; + Sun, 19 Jun 2016 13:17:03 -0700 (PDT) +Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com + [74.125.82.54]) by arlo.cworth.org (Postfix) with ESMTPS id B3DD16DE00B8 for + ; Sun, 19 Jun 2016 13:17:02 -0700 (PDT) +Received: by mail-wm0-f54.google.com with SMTP id r201so35834569wme.1 + for ; Sun, 19 Jun 2016 13:17:02 -0700 (PDT) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=nikula-org.20150623.gappssmtp.com; s=20150623; + h=from:to:cc:subject:date:message-id:in-reply-to:references; + bh=gPyrvjGT2ojk74j/NJWxLEgByugDyYtW3610kx+48Kk=; + b=oE8M/ggnrBmz3A/3SFHmfQ5kQZqekFrJ0wVIw7LVq1wgDWOPzfjSmbmKip65YHLvjI + UJCNMYd1RuqS7M8dRQqeLQo/HHg7KWGvKRYLe2nGpvq0wVkziCg8OQmMfSWgHhJH0H3S + mBTng/hO9cCyIZJPAz6ELgh1Tgglu79avs9pwBeu7dGN2MEyii0f/mPkAXOoRHxZmBLC + pc9A5Ni/5kh/N9bjmxKCkk0wEY1AXxXayv5bYxS0/5knlvAt6bOfDqj85aHM9Su4fC7D + li57guhskj61O5fC4AbGL6UFM9zpHEuJrprflMdrcuK5kgMpfv0BHv+f08f4NrcemGvt + nuBg== +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=1e100.net; s=20130820; + h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to + :references; + bh=gPyrvjGT2ojk74j/NJWxLEgByugDyYtW3610kx+48Kk=; + b=RL8yd+mTY49tWUQEknF7p65OdTlZk+7d1ojDfqm1g2IO5LP3FqVPSOU7KWKcgQJhXi + QKjnzxG8E8zNpZloqUiRPbZxzkK3bP2j1i5tcwfVe3LEQ+ckkQsk0K82496nJShSH+O/ + Qw29bp5BBEUNLe1VsvYJxdWu8jAwd6bz+PatgoDBlFq/C/s25X5NbDlK56DOcOOhTgH+ + 3mENZX0dPILiDteFQiYDedhrui8Afl9uME0OitJN/gXT1li/6ykCSiCvDth2s5CXGMw0 + VdljWNQ2XH+FZqL+PKzhoNvcVyh+5wFiStIjHeee+s9ChXzp38yt9R2Zt/RPUxZfsq+C + XtwQ== +X-Gm-Message-State: + ALyK8tLVcHCBZXFmA8bJvJjNfo99y+dYtbSfEfRF0I/h/eOipfjeQQpUmep50xZ8xx81kQ== +X-Received: by 10.28.158.132 with SMTP id h126mr7423779wme.43.1466367420687; + Sun, 19 Jun 2016 13:17:00 -0700 (PDT) +Received: from localhost (mobile-access-bcee4e-81.dhcp.inet.fi. + [188.238.78.81]) + by smtp.gmail.com with ESMTPSA id ze10sm8031476wjb.2.2016.06.19.13.16.59 + (version=TLSv1/SSLv3 cipher=OTHER); + Sun, 19 Jun 2016 13:17:00 -0700 (PDT) +From: Jani Nikula +To: Jani Nikula , + notmuch@notmuchmail.org +Cc: Daniel Kahn Gillmor +Subject: [RFC PATCH 0/6] cli/reply: refactoring part 2 +Date: Sun, 19 Jun 2016 23:15:28 +0300 +Message-Id: +X-Mailer: git-send-email 2.1.4 +In-Reply-To: +References: +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.20 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 19 Jun 2016 20:17:11 -0000 + +This one expands on [1] to use GMimeMessage more. There are some less +than perfect intermediate steps in order to split the stuff into +reasonable sized patches, but it gets better in the end. There's still +more to do, but I ran out of steam a bit (thus RFC), and it's better to +get the first series merged first anyway. + +This should fix the issue Daniel saw [2], but I haven't really tested +that, as there are no dedicated tests for it. Daniel, care to try this +on the problematic message? Reindexing is not needed. + +BR, +Jani. + +[1] id:cover.1466284726.git.jani@nikula.org +[2] id:87d1ngv95p.fsf@alice.fifthhorseman.net + + +Jani Nikula (6): + cli/reply: use dedicated functions for reply to mapping + cli/reply: check for NULL list first in scan_address_list() + cli/reply: return internet address list from get header funcs + cli/reply: pass internet address list to munge detect + cli/reply: pass gmime message to munge detection + cli/reply: only pass gmime message to add recipients to reply message + + notmuch-reply.c | 171 +++++++++++++++++++++++++++++--------------------------- + 1 file changed, 90 insertions(+), 81 deletions(-) + +-- +2.1.4 +