From: Marco Costalba <mcostalba@yahoo.it>
Date: Sat, 20 Aug 2005 16:02:16 +0000 (+0200)
Subject: [PATCH] Fix git-commit-script to output on stderr when -v fails
X-Git-Tag: v0.99.5~7^2~3
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=b909a15edef8c79b2b045bd90d25e19ea58f299c;p=git.git

[PATCH] Fix git-commit-script to output on stderr when -v fails

When git-commit-script is called with -v option and
verify test fails result is print on stdout
instead of stderr.

[jc: The original patch from Marco updated git-commit-script that
still had the piece of code in question, which has been moved to
an example hook script on its own, so I transplanted the patch to
that new file instead.]

Signed-off-by: Marco Costalba <mcostalba@yahoo.it>
Signed-off-by: Junio C Hamano <junkio@cox.net>
---

diff --git a/templates/hooks--pre-commit b/templates/hooks--pre-commit
index dad99bcf1..075eb3c1f 100644
--- a/templates/hooks--pre-commit
+++ b/templates/hooks--pre-commit
@@ -19,17 +19,17 @@ perl -e '
     sub bad_line {
 	my ($why, $line) = @_;
 	if (!$found_bad) {
-	    print "*\n";
-	    print "* You have some suspicious patch lines:\n";
-	    print "*\n";
+	    print STDERR "*\n";
+	    print STDERR "* You have some suspicious patch lines:\n";
+	    print STDERR "*\n";
 	    $found_bad = 1;
 	}
 	if ($reported_filename ne $filename) {
-	    print "* In $filename\n";
+	    print STDERR "* In $filename\n";
 	    $reported_filename = $filename;
 	}
-	print "* $why (line $lineno)\n";
-	print "$filename:$lineno:$line\n";
+	print STDERR "* $why (line $lineno)\n";
+	print STDERR "$filename:$lineno:$line\n";
     }
     open $fh, "-|", qw(git-diff-cache -p -M --cached HEAD);
     while (<$fh>) {